Repository navigation
Add web support - #4
Merged
Merged
Conversation
j-piasecki
approved these changes
Mar 21, 2024
j-piasecki
left a comment
j-piasecki
left a comment
There was a problem hiding this comment.
LGTM but please add a description with an explanation of why it can be done this way 😅.
48 of 50 tasks
Author
|
cc @roryabraham |
roryabraham
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're adding web support. All three platforms (iOS, Windows, and now Web) use the same implementation of the
getSizefunction. That's why we are just renaming.ios.jsto the.js, which will cover all platforms except for Android.This is needed to solve this issue.