Replace `Image.getSize` with `react-native-image-size` by kosmydel · Pull Request #38746 · Expensify/App

kosmydel · 2024-03-21T13:49:28Z

Details

Fixed Issues

$ #38500
PROPOSAL: N/A

Tests

Go to the Account settings.
Press the edit avatar button.
Upload a new avatar, crop it, and save it.
On native: add a new image attachment
Dev only tests:
Try to import Image from the react-native and use the getSize method.
Verify the lint error is visible.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console
Do the tests from the above

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-android.mov

iOS: Native

ios.mp4

iOS: mWeb Safari

mweb-ios.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

j-piasecki · 2024-03-21T14:01:00Z

    "react-native-haptic-feedback": "^2.2.0",
    "react-native-image-picker": "^7.0.3",
-    "react-native-image-size": "git+https://github.com/Expensify/react-native-image-size#8393b7e58df6ff65fd41f60aee8ece8822c91e2b",
+    "react-native-image-size": "file:../react-native-image-size/react-native-image-size-1.1.3.tgz",


Don't forget to update this once Expensify/react-native-image-size#4 (review) gets merged

kosmydel · 2024-03-25T13:25:35Z

+                'no-restricted-properties': [
+                    'error',
+                    {
+                        object: 'Image',
+                        property: 'getSize',
+                        message: 'Usage of Image.getImage is restricted. Please use the `react-native-image-size`.',
+                    },
+                ],


This error can be ignored by changing the import name like this:
import {Image as Image2} from '...'

I couldn't find a way to block this one as well.

melvin-bot · 2024-03-25T14:51:49Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-03-27T17:27:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Record_2024-03-28-21-36-13.mp4

Record_2024-03-28-21-47-38.mp4

Android: mWeb Chrome

Record_2024-03-28-21-41-51.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-03-28.at.8.55.38.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-28.at.8.32.01.PM.mov

MacOS: Desktop

Screen.Recording.2024-03-28.at.8.32.01.PM.mov

ishpaul777 · 2024-03-27T17:28:10Z

@kosmydel Can you please resolve conflicts

kosmydel · 2024-03-28T08:42:30Z

@kosmydel Can you please resolve conflicts

Done. I've quickly tested it.

melvin-bot · 2024-03-30T02:39:40Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-30T02:47:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-02T11:14:24Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham · 2024-04-02T23:19:41Z

emergency label was applied in error

OSBotify · 2024-04-08T10:54:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kosmydel added 3 commits March 21, 2024 14:11

use react-native-image-size

9e22ed1

add eslint rule

909eb5f

use local react-native-image-size

9877f24

j-piasecki approved these changes Mar 21, 2024

View reviewed changes

kosmydel mentioned this pull request Mar 21, 2024

[HOLD for payment 2024-04-15] [$500] Investigate and address Image.getSize / react-native-image-size discrepancy #38500

Closed

kosmydel added 2 commits March 25, 2024 14:16

update the library

27ad96c

Merge branch 'main' into @kosmydel/react-native-image-size

a33dcd3

kosmydel commented Mar 25, 2024

View reviewed changes

Merge branch 'Expensify:main' into @kosmydel/react-native-image-size

7afcaf6

kosmydel marked this pull request as ready for review March 25, 2024 14:51

kosmydel requested a review from a team as a code owner March 25, 2024 14:51

melvin-bot Bot requested review from ishpaul777 and removed request for a team March 25, 2024 14:51

Merge branch 'main' into @kosmydel/react-native-image-size

f61babb

ishpaul777 approved these changes Mar 28, 2024

View reviewed changes

melvin-bot Bot requested a review from roryabraham March 28, 2024 16:21

roryabraham approved these changes Mar 30, 2024

View reviewed changes

roryabraham merged commit 14ff944 into Expensify:main Mar 30, 2024

melvin-bot Bot added the Emergency label Mar 30, 2024

github-actions Bot mentioned this pull request Apr 2, 2024

Deploy Checklist: New Expensify 2024-04-02 #39399

Closed

87 tasks done

roryabraham removed the Emergency label Apr 2, 2024

Navigation Menu

Repository navigation

Replace `Image.getSize` with `react-native-image-size` - #38746

Replace `Image.getSize` with `react-native-image-size`#38746
roryabraham merged 7 commits into
Expensify:mainfrom
software-mansion-labs:@kosmydel/react-native-image-size

kosmydel commented Mar 21, 2024 •

edited

Loading

Uh oh!

j-piasecki Mar 21, 2024

Uh oh!

kosmydel Mar 25, 2024

Uh oh!

melvin-bot Bot commented Mar 25, 2024

Uh oh!

ishpaul777 commented Mar 27, 2024 •

edited

Loading

Uh oh!

ishpaul777 commented Mar 27, 2024

Uh oh!

kosmydel commented Mar 28, 2024 •

edited

Loading

Uh oh!

melvin-bot Bot commented Mar 30, 2024

Uh oh!

OSBotify commented Mar 30, 2024

Uh oh!

OSBotify commented Apr 2, 2024

Uh oh!

roryabraham commented Apr 2, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

kosmydel commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

j-piasecki Mar 21, 2024

Choose a reason for hiding this comment

Uh oh!

kosmydel Mar 25, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Mar 25, 2024

Uh oh!

ishpaul777 commented Mar 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Mar 27, 2024

Uh oh!

kosmydel commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Mar 30, 2024

Uh oh!

OSBotify commented Mar 30, 2024

Uh oh!

OSBotify commented Apr 2, 2024

Uh oh!

roryabraham commented Apr 2, 2024

Uh oh!

OSBotify commented Apr 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kosmydel commented Mar 21, 2024 •

edited

Loading

ishpaul777 commented Mar 27, 2024 •

edited

Loading

kosmydel commented Mar 28, 2024 •

edited

Loading