Skip to content

[No QA] Docs updates for E/A#99247 document Submit to my employer on tracked expense menu - #99480

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-submit-to-employer-99247
Aug 27, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
melvin-docs-submit-to-employer-99247

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs update for #99247

#99247 adds a Submit to my employer option to a tracked (personal) expense's More menu, alongside the existing Send to someone option. This gives users a second entry point — besides the Concierge actionable message in the Expense chat — to submit a self‑tracked expense to a workspace for approval and reimbursement (creating a Submit workspace automatically if they don't have one).

What changed

Updated docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md, in the What you can do with tracked expenses section, to document that you can open a tracked expense and select More to:

  • Send to someone – Send the expense to another person to request payment.
  • Submit to my employer – Submit the expense to a workspace for approval and reimbursement.

Labels used (verified against source of truth)

The exact menu labels come from src/languages/en.ts (iou.sendToSomeone → "Send to someone", iou.submitToEmployer → "Submit to my employer"), which the source PR renders in MoneyRequestHeaderSecondaryActions.tsx.


@shawnborton, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 25, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99247 document Submit to my employer on tracked expense menu [No QA] Docs updates for E/A#99247 document Submit to my employer on tracked expense menu Aug 25, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://eedef7e1.helpdot.pages.dev ⚡️

Updated articles:

@shawnborton

Copy link
Copy Markdown
Contributor

Looks good, @MelvinBot mark as ready for review please

@MelvinBot
MelvinBot marked this pull request as ready for review August 26, 2026 00:24
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done — this PR is now marked as Ready for review. 🚀


view run

- **Submit it to someone** – Send it for approval or reimbursement.
- **Nothing for now** – Leave it stored for later.

You can also open the tracked expense and select **More** to submit it:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation phrasing (deterministic writing): "open the tracked expense" is vague about the action. The parallel bullet below uses "click into the expense" — match that phrasing for consistency, e.g. "You can also click into the tracked expense and select More to submit it:". Per HELPSITE_NAMING_CONVENTIONS.md (Deterministic Writing / Prohibited Language), navigation should be exact and consistent.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds 4 lines to Track-Expenses.md, documenting a second entry point for submitting a tracked expense: opening the expense and selecting More to reveal Send to someone and Submit to my employer options. It slots cleanly into the existing What you can do with tracked expenses section using the same bullet pattern as the surrounding content.

Scores Summary

  • Readability: 8/10 - Clear, concise, and parallel to the adjacent list. One minor mismatch: the lead-in says "...select More to submit it," but the first bullet (Send to someone) is about requesting payment from a person, not submitting for approval/reimbursement.
  • AI Readiness: 8/10 - Content nests correctly under the existing task-based What you can do with tracked expenses heading, uses full feature/option names, and adds no forbidden heading levels. No new metadata was needed since the change is additive. Not penalized for pre-existing structure outside the diff.
  • Style Compliance: 8/10 - Option labels are bold and in Sentence case matching the UI, verified against src/languages/en.ts (iou.sendToSomeone, iou.submitToEmployer) per the PR description, showing strong adherence to the Core UI Referencing and Button Naming standards.

Key Findings

  • Option labels match the source of truth exactly and are formatted per the Button Naming Standards (bold, Sentence case, no quotes).
  • The new bullets mirror the existing list structure, keeping the section scannable and consistent.
  • The lead-in "...select More to submit it" slightly over-generalizes, since Send to someone is a payment-request flow rather than a submission-for-approval flow.
  • Confirm More is the exact UI label. If the entry point is a three-dots icon, the Three Dots Menu Rule requires the three-dots (vertical dots) phrasing instead.

Recommendations

  • Reword the lead-in to cover both actions, e.g. "You can also open the tracked expense and select More to send or submit it:" to resolve the submit/send mismatch.
  • Verify More is the literal UI label (vs. a three-dots menu) so the correct naming convention is applied.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md - Additive change (4 lines); compliant with governance, minor wording refinement suggested.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit 7c5f935 into main Aug 27, 2026
20 of 22 checks passed
@stephanieelliott
stephanieelliott deleted the melvin-docs-submit-to-employer-99247 branch August 27, 2026 04:21
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.63-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.63-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants