Skip to content

[No QA] Docs updates for E/A#96922 held-expense split and all-on-hold submit block - #99026

Merged
zanyrenney merged 2 commits into
mainfrom
claude-docsHeldExpenseSplitOnSubmit
Aug 31, 2026
Merged

zanyrenney merged 2 commits into
mainfrom
claude-docsHeldExpenseSplitOnSubmit

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Overview

Follow-up help site update for #96922, which mirrors the backend behavior so that submitting a report with held expenses splits the held expenses onto a new Draft report (offline and online). This behavior was not documented on the help site.

What changed

Updated Create-and-Submit-Reports.md:

  • Added a note under How to manually submit an expense report explaining that held expenses move to a new Draft report on submit, while unheld expenses stay on the submitted report.
  • Added an FAQ entry: What happens to held expenses when I submit a report?
  • Added an FAQ entry: Why can't I submit a report when all expenses are on hold? — including the exact in-app error copy ("You can't submit this report because all expenses are on hold. Remove the hold to submit.").

Verified against the live UI

Behavior and copy were confirmed in the current web app:

  • Submitting a report with one held + one unheld expense splits the held expense onto a new Draft report; the unheld expense stays on the submitted report (which moves to Outstanding).
  • Submitting a report where every expense is on hold is blocked with the dialog "Unable to submit report" / "You can't submit this report because all expenses are on hold. Remove the hold to submit."
  • The primary action stays labeled Submit on workspaces with an approval workflow.

Authoring guidelines

Followed HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md: task/question-based ## headings, exact bolded UI labels (Submit, Draft), a single relative cross-link to the hold instructions, and no new # headings.


@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 20, 2026
@MelvinBot MelvinBot self-assigned this Aug 20, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#96922 held-expense split and all-on-hold submit block [No QA] Docs updates for E/A#96922 held-expense split and all-on-hold submit block Aug 20, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review August 28, 2026 03:53
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 28, 2026 03:53
Comment thread docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md Outdated
Comment thread docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4cb7a344e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR adds 10 lines to Create-and-Submit-Reports.md documenting held-expense behavior on report submit: a Note under the manual-submit section, plus two new FAQ entries covering the held/unheld split and the all-on-hold submit block. The additions are accurate, concise, and well-targeted to real user search intent. Content quality is high overall, with one clear governance fix needed.

Scores Summary

  • Readability: 9/10 - Clear, scannable sentences; the note and FAQ answers are concise and actionable. Quoting the exact in-app error copy helps users match what they see.
  • AI Readiness: 9/10 - Both new second-level headings are question-based ("What happens to held expenses when I submit a report?" and "Why cant I submit a report when all expenses are on hold?") and correctly placed under the FAQ section. Heading hierarchy stays at the allowed levels; full feature terminology is used.
  • Style Compliance: 7/10 - UI labels (Draft, Submit) are correctly bolded and exact. The one deduction is the cross-link, which uses a full URL instead of the required relative link.

Key Findings

  • Full URL cross-link: the note links via a full help.expensify.com URL to Approve-Expenses. HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting) requires relative links only and prohibits full URLs.
  • Strong positive: the new FAQ questions match likely search phrasing and are correctly placed under the FAQ heading, satisfying the task/question-based heading rules.
  • Strong positive: the exact error dialog copy is reproduced verbatim ("You cant submit this report because all expenses are on hold. Remove the hold to submit."), aligning with the exact-UI-text rule.
  • Minor: the anchor text ("Approve, hold, reject, and unapprove expenses") is descriptive and acceptable, though broader than the Approve-Expenses slug.

Recommendations

  • Priority: convert the full URL to a relative link pointing at /articles/new-expensify/reports-and-expenses/Approve-Expenses.
  • Optional: consider echoing the held-expense note near the "Why dont I see the Submit button?" FAQ for discoverability. Not required.

Files Reviewed

  • Create-and-Submit-Reports.md - approve with one required fix (relative link). Content is accurate and well-structured.

Note: This review covers only the proposed additions in the diff.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://880a8d0e.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott requested a review from a team August 28, 2026 05:05
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

ALL CHECKED.

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @zanyrenney

@melvin-bot
melvin-bot Bot requested review from zanyrenney and removed request for a team August 28, 2026 05:05
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@zanyrenney
zanyrenney merged commit bf5952e into main Aug 31, 2026
15 of 16 checks passed
@zanyrenney
zanyrenney deleted the claude-docsHeldExpenseSplitOnSubmit branch August 31, 2026 12:00
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.4.65-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants