[Payment due @marufsharifi] Show export status in one app-level modal instead of per screen - #98521
Conversation
|
@codex review |
mollfpr
changed the title
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
…-manager # Conflicts: # src/components/MoneyReportHeader.tsx # src/components/MoneyReportHeaderActions/ExportDownloadStatusProvider.tsx # src/hooks/useExportActions.ts # src/hooks/useSearchBulkActions.ts # tests/unit/hooks/useExportActionsTest.ts # tests/unit/hooks/useSearchBulkActionsTest.ts
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@codex review |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e3b37d85e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e945114cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06a0792cb6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
melvin-bot
Bot
changed the title
|
🎯 @marufsharifi, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
Beamanator
left a comment
Beamanator
left a comment
There was a problem hiding this comment.
A bunch of the same kind of NAB comment, sorry 😅
Co-authored-by: Alex Beaman <dabeamanator@gmail.com>
Co-authored-by: Alex Beaman <dabeamanator@gmail.com>
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.65-0 🚀
|
|
Yes — help site changes are required, and I opened a draft PR for them: #99954 What changed for membersMost of this PR is an internal refactor (one app-level An export that is still preparing or already ready now survives a page refresh. No UI labels were renamed, so no existing wording needed correcting. What the docs PR doesAdds one FAQ entry to each of the three articles that describe the export status window. No existing wording touched.
Label verificationLabels used in the new copy — Reports, More, Download file, Send me the file when it's ready, Your file is ready!, Preparing download... — match I also drove dev NewDot web to check navigation labels. The test account has no reports, so the export flow itself could not be exercised.
@mollfpr, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #100090 |
7 participants
Explanation of Change
Before, each screen that could start an export (the money report header, Search, and so on) rendered it's own export status modal, and those had to kept in sync.
This moves it to single app-level component,
ExportDownloadStatusManager, that watches theexportDownloadOnyx collection and owns the one modal. A screen now just starts an export, which writes the record, andExportDownloadStatusManagerhandles the rest.ExportDownloadStatusManagerwill skips any record withshouldSendFromConciergeand the modal just closes.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/662909
PROPOSAL:
Tests
Same as QA steps.
Offline tests
QA Steps
Prerequisite:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.Aug.16.2026.mp4