Repository navigation
Docs updates for E/A#97209 Clarify invoicing details not copied on workspace duplication - #98212
Conversation
…kspace Co-authored-by: Lorre Naga <lorretheboy@users.noreply.github.com>
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a top-level summary review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e45b3da73
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@stephanieelliott Do we have to validate anything in this PR? |
|
🚀 Deployed to staging by https://github.com/johncschuster in version: 9.4.76-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.76-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Follow-up documentation update for #97209, which $ Expensify/App#92166 — "Invoice created via duplicate workspace shows error."
That PR corrected the workspace duplication flow so that a source workspace's Invoicing details (Company name, Company website, and the connected bank account) are no longer copied to the duplicate. These details are provisioned per workspace, and copying them caused an error when opening an invoice created from a duplicated workspace.
The existing Duplicate Workspace article lists Invoices as one of the settings that can be carried over, but did not clarify that only the invoicing feature is enabled — the invoicing details themselves are not copied and must be re-entered. This PR adds a short FAQ entry to set that expectation.
Change
docs/articles/new-expensify/workspaces/Duplicate-Workspace.mdclarifying that Invoicing details (Company name, Company website, and connected bank account) are not copied when duplicating a workspace and must be set up again in the new workspace.UI labels (Invoices, Invoicing details, Company name, Company website) were verified against the current app copy in
src/languages/en.ts.Applied guidelines
docs/HELPSITE_NAMING_CONVENTIONS.md— exact, bolded UI labels; sentence case.docs/HELP_AUTHORING_GUIDELINES.md— single workflow; FAQ##question headings under the exempt# FAQ.docs/TEMPLATE.md— kept the change scoped to the existing article's FAQ.@lorretheboy, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.