Skip to content

feat: Replace Delete with Archive behind the archivePolicies beta - #98029

Merged
rlinoz merged 27 commits into
Expensify:mainfrom
truph01:feat/97123
Oct 6, 2026
Merged

rlinoz merged 27 commits into
Expensify:mainfrom
truph01:feat/97123

Conversation

@truph01

@truph01 truph01 commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Behind the archivePolicies beta:

  • Replace the Delete menu item with Archive at the WorkspaceRowThreeDotsMenu and WorkspaceOverviewPage entry points (archive icon, workspace.common.archive label).
  • Point Archive at a flow modeled on DeleteWorkspaceFlow that calls a new archivePolicy action invoking the ArchivePolicy command.
  • Keep the card confirmation copy and reuse the existing pre-checks (Invoicify block, outstanding-balance guard, bill calculation, pay-and-downgrade).

Fixed Issues

$ #97123
PROPOSAL:

Tests

  1. Open "workspaces" tab
  2. Click on three dot button in any workspace where user is owner
  3. Verify the "Archive workspace" option is shown
  4. Click on "Archive workspace" option > Click "CTA button" > Verify the workspace is archived successfully
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above

  • I wrote clear testing steps that cover the changes made in this PR

    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms

  • I ran the tests on all platforms & verified they passed on:

    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

  • I followed proper code patterns (see Reviewing the code)

    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

  • I followed the guidelines as stated in the Review Guidelines

  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

  • If a new CSS style is added I verified that:

    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:

    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.

  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:

    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.

  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-09-24.at.10.05.43.mov
iOS: mWeb Safari
Screen.Recording.2026-09-24.at.10.02.33.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-24.at.09.55.42.mov

@melvin-bot

melvin-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ts/Tables/WorkspaceListTable/WorkspaceTableRow.tsx 89.13% <100.00%> (ø)
src/components/Tables/WorkspaceListTable/index.tsx 71.42% <100.00%> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
src/selectors/Policy.ts 88.70% <100.00%> (ø)
src/pages/workspace/WorkspacesListPage.tsx 86.51% <66.66%> (-0.70%) ⬇️
...s/WorkspaceListTable/WorkspaceRowThreeDotsMenu.tsx 68.29% <50.00%> (-0.94%) ⬇️
src/libs/actions/Policy/Policy.ts 70.63% <0.00%> (-0.40%) ⬇️
src/pages/workspace/WorkspaceOverviewPage.tsx 0.00% <0.00%> (ø)
...orkspace/archiveWorkspace/ArchiveWorkspaceFlow.tsx 0.00% <0.00%> (ø)
... and 5 files with indirect coverage changes

@truph01
truph01 marked this pull request as ready for review September 23, 2026 03:16
@truph01
truph01 requested review from a team as code owners September 23, 2026 03:16
@melvin-bot
melvin-bot Bot requested review from a team, daledah and garrettmknight and removed request for a team September 23, 2026 03:16
@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team September 23, 2026 03:16
Comment thread src/pages/workspace/archiveWorkspace/ArchiveWorkspaceFlow.tsx Outdated
Comment thread src/pages/workspace/archiveWorkspace/ArchiveWorkspaceFlow.tsx Outdated
Comment thread src/pages/workspace/archiveWorkspace/ArchiveWorkspaceFlow.tsx
@truph01

truph01 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

@Expensify/design Could you give me the "Archive workspace" icon which used in

Screenshot 2026-09-23 at 10 39 06

@daledah

daledah commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@truph01, the code changes look good overall, with only one remaining comment above. Could you please take another look?

@truph01

truph01 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@daledah I resolved your comment. Could you review it again?

@rlinoz

rlinoz commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@daledah let's get this one merged today if possible! 🙇

@truph01 can you also update the author's checklist please?

@daledah daledah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from rlinoz October 5, 2026 11:27
Comment thread src/pages/workspace/archiveWorkspace/ArchiveWorkspaceFlow.tsx Outdated
Comment thread src/libs/actions/Policy/Policy.ts Outdated
Comment thread src/pages/workspace/archiveWorkspace/ArchiveWorkspaceFlow.tsx Outdated

@rlinoz rlinoz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things to match the backend behavior.

@truph01

truph01 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Could you review this PR again @daledah @rlinoz ?

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@rlinoz
rlinoz merged commit f1d0513 into Expensify:main Oct 6, 2026
39 of 43 checks passed
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 6, 2026
100 tasks done
@OSBotify

OSBotify commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.5.4-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #103290 was identified to be related to this PR.

@OSBotify

OSBotify commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants