Repository navigation
Conversation
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@KJ21-ENG please include solutions for other blockers here. |
@ChavdaSachin Can you please take a look at my these comments to calrify that do we realy need to apply fix for them as a follow-up of this PR #94678 ? From what I can see here is a very clear pattern that a bunch of things I have reused from the Expensify cards module, and it seems that some of the things are already broken there. That got exposed in this PR. I have no issues with fixing them or following up on this PR, but just thought to clarify this thing here. Thanks! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ChavdaSachin over to you |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-08-05.at.12.59.47.PM.moviOS: mWeb Safari |
…any-cards-dropdown-alignment
…any-cards-dropdown-alignment
|
@ChavdaSachin please review |
|
Hmm I suppose the Company Cards version feels more like the Spend page, but the Expensify Card version looks more like other parts of the workspace editor. I'd probably lean on doing something more like the Spend page for now? And then I would love to follow up and move the create buttons on all tables to be to the right of the Display button - again, the same as Spend. Then we can normalize the bulk action button (maybe do the floating bar idea) from there. |
|
Agree with all of those thoughts Shawn 👍 |
|
@KJ21-ENG please complete the checklist |
|
Having some native iOS build-related issue, planning for updating the checklist shortly |
|
@JS00001 Done, sorry for the bit of the delay. |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Hi @KJ21-ENG. Can we skip these steps?
|
|
@IuliiaHerets Done! , honestly, my bad. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.52-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under Why: The changes are purely presentational/interaction refinements to the Company cards page, not changes to any documented workflow:
None of this alters what a card admin does — assigning/unassigning cards, exporting, configuring feed settings, or reconnecting feeds all behave and read the same. I checked the relevant articles ( Because no changes are required, I did not create a draft help site PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |




Explanation of Change
This PR now combines the related Company Cards follow-ups requested after #94678.
On wide layouts, the company cards bulk-actions popover now receives a caller-specific left/top anchor. It opens into the company cards content area, matching the nearby Search dropdown, without changing the default alignment of other dropdowns.
On narrow layouts, selection mode now uses the focused layout proposed by Danny: the page shows the Select multiple header, selected-count action, Search, Filters, Display, and the selectable table. The feed selector, Settings action, illustration, and unrelated page header content are hidden until selection mode ends. The selected-count action remains visible and disabled at
0 selected, so selection mode does not lose its only action control.Pressing Back clears selected rows and exits selection mode. This intentionally does not add a feed-change auto-exit effect. The normal narrow-layout flow cannot change feeds while selection mode is active because the feed selector is hidden. If the feed changes indirectly, the feed-scoped row selection resets while selection mode remains active.
Design direction: #97412 (comment)
Fixed Issues
$ #97394
$ #97411
$ #97412
PROPOSAL: #97394 (comment)
Tests
Wide layout and popover alignment
Narrow selection mode
Offline tests
The focused layout and selection cleanup are client-side. Existing card actions retain their existing offline behavior.
QA Steps
Same as Tests and Offline tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Unchecked items remain pending. Checked conditional items with no matching scope, such as CSS, assets, messaging, and form inputs, indicate that the condition was reviewed and does not apply.
Screenshots/Videos
Android: Native
97412-native-android-smooth-transition.mp4
The final commit still needs a physical-device rerun. No Android device is currently connected to the development machine.
Android: mWeb Chrome
Screen.Recording.2026-08-06.at.3.40.46.AM.mov
iOS: Native
Screen.Recording.2026-08-06.at.1.54.50.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-06.at.3.15.18.AM.mov
MacOS: Chrome / Safari
Brave (Chromium) on macOS, using the GitHub-hosted PR build for the popover-alignment change:
The final combined head still needs a manual macOS rerun.