Repository navigation
[Due for payment 2026-08-19] Company cards - Dropdown menu overlaps with LHN #97394
Description
Activity
- addedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deployment
on Jul 29, 2026 - addedBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.
on Jul 29, 2026 While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/86fe9490e583a998172ff47aa307ae84b9dfc1b615501795ece034fcfb2177b3You have been assigned to this deploy blocker because you recently merged this PR: #94678
@JS00001 @ChavdaSachin you have been assigned to this deploy blocker because you reviewed the offending PR: #94678
💬 A slack conversation has been started in #expensify-open-source
github-actions commented
on Jul 29, 2026 on Jul 29, 2026 – with GitHub ActionsContributorMore actions👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #94678 - "Add bulk actions for company cards" by @KJ21-ENG (High confidence)
Related Issues: #93334, #96047 (features implemented by the causing PR)Recommendation: ROLL FORWARD
The fix is a one-line prop addition, whereas reverting #94678 is problematic: it also ships shared
Table.FilterBar/ Display "Sort by" changes that affect many other tables (members, categories, tags, rooms), so a revert would remove/regress those unrelated surfaces. A targeted fix is far safer.Assigned: @KJ21-ENG (PR author), @ChavdaSachin (approving reviewer), @JS00001 (approving reviewer) from the causing PR #94678
Labels: No changes.DeployBlockerCashis correctly kept (an App PR caused this, so the App deploy is blocked).DeployBlockeris not present and should not be added.📋 Detailed Analysis
Evidence
- PR [Payment due @ChavdaSachin] Add bulk actions for company cards #94678 introduces the multi-select "1 selected" bulk-actions dropdown on the Company cards page. It created
WorkspaceCompanyCardsTableControls.tsx(+199 / -0), which renders the exact dropdown described in the repro (theButtonWithDropdownMenuwithcustomText={translate('workspace.common.selected', {count})}). - Merged 2026-07-29 (
a0d8671), matching version 9.4.46-0. The feature is brand new, which is consistent with "N/A - doesn't exist in prod" and "reproducible in staging only". - PR [Payment due @ChavdaSachin] Add bulk actions for company cards #94678 is line item open to first room in the LHN #83 in the current StagingDeployCash checklist (Deploy Checklist: New Expensify 2026-07-29 #97375).
- The Expenses page dropdown (which the report confirms works correctly) is a different component,
SearchBulkActionsButton.tsx, which explicitly setsanchorAlignment.horizontal = LEFT. That difference is exactly why one overlaps the LHN and the other does not.
Verification
- Affected file (renders the broken dropdown):
src/components/Tables/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableControls.tsxL183-L192 —App/src/components/Tables/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableControls.tsx
Lines 183 to 192 in d7d2c6f
<ButtonWithDropdownMenu<WorkspaceCompanyCardBulkActionType> variant={CONST.BUTTON_VARIANT.SUCCESS} onPress={() => {}} customText={translate('workspace.common.selected', {count: selectedCards.length})} options={getBulkActionOptions()} isSplitButton={false} shouldAlwaysShowDropdownMenu sentryLabel={CONST.SENTRY_LABEL.WORKSPACE.COMPANY_CARDS.BULK_ACTIONS_DROPDOWN} wrapperStyle={[shouldUseNarrowTableLayout ? styles.w100 : styles.flexGrow0, styles.tableBulkActionsButton(shouldUseNarrowTableLayout)]} /> - Confirmed via
gh pr view 94678 --json filesthat this file was added by PR [Payment due @ChavdaSachin] Add bulk actions for company cards #94678 (+199/-0), alongsideWorkspaceCompanyCardsTableHeaderButtons.tsxandWorkspaceCompanyCardsTable/index.tsx. - The
ButtonWithDropdownMenucall in the controls file does not pass ananchorAlignmentprop.
Root Cause
ButtonWithDropdownMenudefaultsanchorAlignmenttohorizontal: RIGHT:src/components/ButtonWithDropdownMenu/index.tsxL29-L33 —App/src/components/ButtonWithDropdownMenu/index.tsx
Lines 29 to 33 in d7d2c6f
const defaultAnchorAlignment = { horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT, // we assume that popover menu opens below the button, anchor is at TOP vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP, };
With
horizontal: RIGHT, the popover is anchored to the button's right edge and expands leftward. On the Company cards page the "1 selected" button sits at the left of the content area, so the leftward-expanding popover spills over / overlaps the LHN.The working Expenses page dropdown avoids this by explicitly anchoring LEFT (expands rightward, staying inside the content area):
src/components/Search/SearchBulkActionsButton.tsxL251-L254 —App/src/components/Search/SearchBulkActionsButton.tsx
Lines 251 to 254 in d7d2c6f
anchorAlignment={{ horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT, vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP, }}
Suggested targeted fix: pass an explicit
anchorAlignmentto the company cardsButtonWithDropdownMenu(L183-L192 ofWorkspaceCompanyCardsTableControls.tsx), matching the Search pattern:anchorAlignment={{ horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT, vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP, }}
(Consider
BOTTOMfor the narrow layout, mirroringSearchBulkActionsButton's narrow branch.)- PR [Payment due @ChavdaSachin] Add bulk actions for company cards #94678 introduces the multi-select "1 selected" bulk-actions dropdown on the Company cards page. It created
NAB, it's not even a bug.
@Expensify/design, please let us know if this even needs a fix...
4 remaining items
Agree with Jon, but this feels like a tiny improvement rather than a bug. Definitely not a blocker IMO.
Reacted by KJ21-ENG- addedDailyKSv2KSv2and removedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deploymentHourlyKSv2KSv2
on Jul 30, 2026 ⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Agree with both of you!
Reacted by KJ21-ENG@JS00001, @ChavdaSachin Whoops! This issue is 2 days overdue. Let's get this updated quick!
@JS00001, @ChavdaSachin Still overdue 6 days?! Let's take care of this!
This fix was merged
- changed the title
[-]Company cards - Dropdown menu overlaps with LHN[/-][+][Due for payment 2026-08-19] Company cards - Dropdown menu overlaps with LHN[/+]on Aug 12, 2026 The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-19. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.4.46-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94678
Email or phone of affected tester (no customers): sdsjodijnsdojsosjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings
Action Performed:
Precondition:
→ Dropdown menu does not overlap with LHN.
Expected Result:
Dropdown menu will not overlap with LHN.
Actual Result:
Dropdown menu overlaps with LHN.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug7221272_1785359496470.1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @ChavdaSachin