Skip to content

[Due for payment 2026-08-19] Company cards - Dropdown menu overlaps with LHN #97394

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.46-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94678
Email or phone of affected tester (no customers): sdsjodijnsdojsosjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Have at least an expense.
  • Workspace has direct feed with cards.
  1. Go to staging.new.expensify.com
  2. Go to Spend > Expenses.
  3. Select an expense via checkbox.
  4. Click 1 selected dropdown.
    → Dropdown menu does not overlap with LHN.
  5. Go to workspace settings > Company cards.
  6. Click on any card > Select.
  7. Click 1 selected dropdown.

Expected Result:

Dropdown menu will not overlap with LHN.

Actual Result:

Dropdown menu overlaps with LHN.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7221272_1785359496470.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7221272

Issue OwnerCurrent Issue Owner: @ChavdaSachin

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 29, 2026
  2. applause-bot commented on Jul 29, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/86fe9490e583a998172ff47aa307ae84b9dfc1b615501795ece034fcfb2177b3

  3. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #94678

  4. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    @JS00001 @ChavdaSachin you have been assigned to this deploy blocker because you reviewed the offending PR: #94678

  5. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Jul 29, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Jul 29, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #94678 - "Add bulk actions for company cards" by @KJ21-ENG (High confidence)
    Related Issues: #93334, #96047 (features implemented by the causing PR)

    Recommendation: ROLL FORWARD

    The fix is a one-line prop addition, whereas reverting #94678 is problematic: it also ships shared Table.FilterBar / Display "Sort by" changes that affect many other tables (members, categories, tags, rooms), so a revert would remove/regress those unrelated surfaces. A targeted fix is far safer.

    Assigned: @KJ21-ENG (PR author), @ChavdaSachin (approving reviewer), @JS00001 (approving reviewer) from the causing PR #94678
    Labels: No changes. DeployBlockerCash is correctly kept (an App PR caused this, so the App deploy is blocked). DeployBlocker is not present and should not be added.

    📋 Detailed Analysis

    Evidence

    Verification

    • Affected file (renders the broken dropdown): src/components/Tables/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableControls.tsx L183-L192 —
      <ButtonWithDropdownMenu<WorkspaceCompanyCardBulkActionType>
      variant={CONST.BUTTON_VARIANT.SUCCESS}
      onPress={() => {}}
      customText={translate('workspace.common.selected', {count: selectedCards.length})}
      options={getBulkActionOptions()}
      isSplitButton={false}
      shouldAlwaysShowDropdownMenu
      sentryLabel={CONST.SENTRY_LABEL.WORKSPACE.COMPANY_CARDS.BULK_ACTIONS_DROPDOWN}
      wrapperStyle={[shouldUseNarrowTableLayout ? styles.w100 : styles.flexGrow0, styles.tableBulkActionsButton(shouldUseNarrowTableLayout)]}
      />
    • Confirmed via gh pr view 94678 --json files that this file was added by PR [Payment due @ChavdaSachin] Add bulk actions for company cards #94678 (+199/-0), alongside WorkspaceCompanyCardsTableHeaderButtons.tsx and WorkspaceCompanyCardsTable/index.tsx.
    • The ButtonWithDropdownMenu call in the controls file does not pass an anchorAlignment prop.

    Root Cause

    ButtonWithDropdownMenu defaults anchorAlignment to horizontal: RIGHT:

    • src/components/ButtonWithDropdownMenu/index.tsx L29-L33 —
      const defaultAnchorAlignment = {
      horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
      // we assume that popover menu opens below the button, anchor is at TOP
      vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
      };

    With horizontal: RIGHT, the popover is anchored to the button's right edge and expands leftward. On the Company cards page the "1 selected" button sits at the left of the content area, so the leftward-expanding popover spills over / overlaps the LHN.

    The working Expenses page dropdown avoids this by explicitly anchoring LEFT (expands rightward, staying inside the content area):

    Suggested targeted fix: pass an explicit anchorAlignment to the company cards ButtonWithDropdownMenu (L183-L192 of WorkspaceCompanyCardsTableControls.tsx), matching the Search pattern:

    anchorAlignment={{
        horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
        vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
    }}

    (Consider BOTTOM for the narrow layout, mirroring SearchBulkActionsButton's narrow branch.)

  8. ChavdaSachin commented on Jul 29, 2026

    @ChavdaSachin
    Contributor

    NAB, it's not even a bug.

  9. ChavdaSachin commented on Jul 29, 2026

    @ChavdaSachin
    Contributor

    @Expensify/design, please let us know if this even needs a fix...

  10. 4 remaining items

  11. dannymcclain commented on Jul 30, 2026

    @dannymcclain
    Contributor

    Agree with Jon, but this feels like a tiny improvement rather than a bug. Definitely not a blocker IMO.

  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 30, 2026
  13. melvin-bot commented on Jul 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. shawnborton commented on Jul 31, 2026

    @shawnborton
    Contributor

    Agree with both of you!

  15. melvin-bot commented on Aug 6, 2026

    @melvin-bot

    @JS00001, @ChavdaSachin Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. melvin-bot commented on Aug 10, 2026

    @melvin-bot

    @JS00001, @ChavdaSachin Still overdue 6 days?! Let's take care of this!

  17. JS00001 commented on Aug 11, 2026

    @JS00001
    Contributor

    This fix was merged

  18. changed the title [-]Company cards - Dropdown menu overlaps with LHN[/-] [+][Due for payment 2026-08-19] Company cards - Dropdown menu overlaps with LHN[/+] on Aug 12, 2026
  19. melvin-bot commented on Aug 12, 2026

    @melvin-bot

    @ChavdaSachin

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-19. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions