[CP Stg] Fix memoized icon crashes by roryabraham · Pull Request #96164 · Expensify/App

roryabraham · 2026-07-15T06:26:12Z

Explanation of Change

Fixes several crashes introduced by #96115. OXC React Compiler was memoizing pre-rendered <svg /> elements in useMemoizedLazyExpensifyIcons instead of component references, which broke ImageSVG. This PR ensures icon hooks always return function components and removes the final useMemo that triggered incorrect fusion.

Fixed Issues

$ #96158
$ #96159
$ #96161

Tests

Retest all three linked issues.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Retest all three linked issues.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

PR #96115 caused useMemoizedLazyExpensifyIcons to cache rendered <svg /> elements instead of component references, breaking ImageSVG. Co-authored-by: Cursor <cursoragent@cursor.com>

typeof === 'function' rejected React.memo icon components in tests. Reject only rendered React elements, not valid component types. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot · 2026-07-15T06:37:57Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-15T06:38:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useLazyAsset.ts	`68.18% <90.90%> (+1.93%)`	⬆️
... and 7 files with indirect coverage changes

robertjchen · 2026-07-15T06:39:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-07-15T06:47:35Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

…rash [CP Stg] Fix memoized icon crashes (cherry picked from commit 70cb35f) (cherry-picked to staging by roryabraham)

OSBotify · 2026-07-15T06:52:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-15T06:53:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96164.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-70cb35f9f72-88ae8e7-16b9cad944516964544c1eb92cdac97825bb0d01/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-70cb35f-88ae8e7-2213e8b7960b826802ca8dff5da1b66bbb55612e/index.html

Web 🕸️
https://96164.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-15T07:15:22Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.34-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-15T07:17:27Z

🤖 No help site changes required.

This PR is an internal bug fix for icon rendering. It only modifies src/hooks/useLazyAsset.ts to ensure the icon hooks return function components rather than pre-rendered <svg /> elements (which the React Compiler was incorrectly memoizing and which broke ImageSVG).

There is no user-facing behavior change — no new or modified feature, setting, tab, label, button, or workflow — so nothing in Expensify's help site articles (App/docs/articles) documents this behavior or needs updating. Accordingly, no draft docs PR was created.

@roryabraham, if you believe a specific article is affected that I missed, let me know the article and I'll create the docs PR.

OSBotify · 2026-07-15T11:38:14Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.34-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-07-15T19:21:11Z

Deploy Blocker #96207 was identified to be related to this PR.

OSBotify · 2026-07-16T05:17:29Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-07-16T06:08:22Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-07-16T06:51:33Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.35-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-16T06:53:40Z

No help site changes required

This PR is a purely internal engineering fix and has no impact on any user-facing behavior documented on the help site.

What it changes: It fixes crashes introduced by #96115 where the OXC React Compiler was memoizing pre-rendered <svg /> elements in useMemoizedLazyExpensifyIcons instead of component references, breaking ImageSVG. The fix adds a resolveIconComponent guard in src/hooks/useLazyAsset.ts to always return function components and removes the useMemo that triggered incorrect fusion.

Why no docs update: The change is confined to icon-loading internals. There is no new feature, no UI/label/setting change, and no change to product behavior that any article under App/docs/articles describes. I reviewed the diff (single file, useLazyAsset.ts) against the help site content model and found nothing to document, update, or correct.

No draft PR was created since none is warranted.

OSBotify · 2026-07-16T23:52:39Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.4.35-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix Account tab crash from OXC memoizing SVG elements

06007ef

PR #96115 caused useMemoizedLazyExpensifyIcons to cache rendered <svg /> elements instead of component references, breaking ImageSVG. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot Bot assigned roryabraham Jul 15, 2026

Use isValidElement to detect memoized SVG elements

ed9461d

typeof === 'function' rejected React.memo icon components in tests. Reject only rendered React elements, not valid component types. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham changed the title ~~Fix Account tab crash after onboarding~~ [CP Stg] Fix Account tab crash after onboarding Jul 15, 2026

roryabraham marked this pull request as ready for review July 15, 2026 06:37

roryabraham requested review from a team as code owners July 15, 2026 06:37

melvin-bot Bot requested review from flaviadefaria and sobitneupane and removed request for a team and flaviadefaria July 15, 2026 06:37

roryabraham requested review from robertjchen and removed request for sobitneupane July 15, 2026 06:38

roryabraham changed the title ~~[CP Stg] Fix Account tab crash after onboarding~~ [CP Stg] Fix memoized icon crashes Jul 15, 2026

robertjchen approved these changes Jul 15, 2026

View reviewed changes

roryabraham merged commit 70cb35f into main Jul 15, 2026
50 checks passed

roryabraham deleted the rory-96158-fix-account-tab-crash branch July 15, 2026 06:45

OSBotify pushed a commit that referenced this pull request Jul 15, 2026

Merge pull request #96164 from Expensify/rory-96158-fix-account-tab-c…

174c091

…rash [CP Stg] Fix memoized icon crashes (cherry picked from commit 70cb35f) (cherry-picked to staging by roryabraham)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 15, 2026

OSBotify mentioned this pull request Jul 15, 2026

Deploy Checklist: New Expensify 2026-07-14 #96044

Closed

MelvinBot mentioned this pull request Jul 15, 2026

[Due for payment 2026-07-23] Expense - Allow location access modal is missing image #96207

Closed

7 tasks

roryabraham mentioned this pull request Jul 15, 2026

fix: restore illustrations blanked by OXC element memoization #96223

Closed

40 tasks

Conversation

roryabraham commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 15, 2026

Uh oh!

codecov Bot commented Jul 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

robertjchen commented Jul 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

OSBotify commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

OSBotify commented Jul 15, 2026

Uh oh!

MelvinBot commented Jul 15, 2026

Uh oh!

OSBotify commented Jul 15, 2026

Uh oh!

jponikarchuk commented Jul 15, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

MelvinBot commented Jul 16, 2026

No help site changes required

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roryabraham commented Jul 15, 2026 •

edited

Loading

codecov Bot commented Jul 15, 2026 •

edited by github-actions Bot

Loading