Skip to content

Update table pages to scroll full page - #93877

Merged
JS00001 merged 115 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/92930-raising-flow
Aug 24, 2026
Merged

JS00001 merged 115 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/92930-raising-flow

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds headerComponent support to the shared Table so page-level controls (header content, buttons, search/filter bar) render inside the table's FlashList and scroll away with the rows, while the table column header is rendered as a sticky list item. Row render indexes and scrollToIndex callers remain aligned to the real table data, and sticky-header activation waits until the list has data to avoid the StickyHeaders load-time error.

All migrated table pages now use the table-owned header flow: Workspaces, Domains (list, admins, groups, members), Categories, Tags, Taxes, Members, Company Cards, Distance Rates, Per Diem, Rooms, Rules (personal rules and all workspace rules tabs), Agents, Expensify Cards, and report participants.

The table empty states (Table.EmptyState / Table.NoResultsState) render inside the scrolling list below the page header, so the page controls stay visible and usable when the table is empty or a search/filter matches nothing.

This PR also $ #95556: on native, focusing the table search bar now scrolls it above the keyboard (using the existing useScrollToFocusedInput pattern), so the input stays visible while typing in landscape.

Fixed Issues

$ #92930
PROPOSAL: #92930 (comment)
$ #95556

Tests

  1. Sign in with an account that has at least one workspace with enough rows to scroll (categories, tags, members, etc.).
  2. Open the Workspaces list. Verify the Workspaces/Domains tab row, the New workspace button, and the search bar scroll away with the rows, while the table column header sticks to the top of the list.
  3. Open Domains, Categories, Tags, Taxes, Members, Company Cards, the workspace Expensify Card list, Distance Rates, Per Diem, Rooms, the workspace Rules tabs, Settings > Rules, Settings > Agents, and a group chat's Members page with enough rows to scroll. Verify each page's controls scroll away with the rows while the column header sticks.
  4. On any table page, search for text that matches nothing. Verify the "no results" view appears below the still-visible search bar, and clearing the search restores the rows.
  5. Open a table page with no data (e.g. Categories on a new workspace). Verify the empty state renders below the page controls instead of replacing them.
  6. Verify search, filters, sorting, and row actions still target the correct rows. Duplicate a workspace and verify the list scrolls to the new workspace. Open a room, navigate back to the Rooms page, and verify the room row is highlighted.
  7. On Android native, rotate to landscape, open Workspaces, and tap the search bar. Verify the list scrolls the search input above the keyboard and it stays fully visible while typing.
  8. Refresh or directly deeplink to a workspace table page. Verify the app does not show the error boundary during the initial table load.
  9. Open Company Cards with no feed, a pending feed, and with cards. Verify the empty/pending states keep the fixed header buttons, and with cards shown the buttons scroll with the list.
  • Verify that no errors appear in the JS console

Offline tests

  1. Disconnect the network and repeat the table scrolling checks on a few pages.
  2. Verify the controls still scroll with the rows, the sticky column header remains usable, and the offline indicator does not overlap the table.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
611393262-bb275b7b-db8e-4386-b9f5-19de01001916.mp4
Android: mWeb Chrome
611381825-6fceb35a-5f11-4439-97cd-76fac7124bd9.mp4
iOS: Native
Screen.Recording.2026-06-23.at.12.49.39.AM.mov
iOS: mWeb Safari
VIDEO-2026-06-23-00-03-34.mp4
MacOS: Chrome / Safari
ezyZip.53.mp4

@KJ21-ENG
KJ21-ENG force-pushed the KJ21-ENG/92930-raising-flow branch from 265dd82 to e3d26d7 Compare June 17, 2026 20:20
@KJ21-ENG
KJ21-ENG marked this pull request as ready for review June 18, 2026 22:10
@KJ21-ENG
KJ21-ENG requested review from a team as code owners June 18, 2026 22:10
@melvin-bot
melvin-bot Bot requested a review from Krishna2323 June 18, 2026 22:10
@melvin-bot

melvin-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team June 18, 2026 22:10
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/PopoverMenu/index.tsx 92.26% <100.00%> (+0.77%) ⬆️
...verMenu/usePopoverMenuFocusManagement/index.ios.ts 100.00% <100.00%> (ø)
.../PopoverMenu/usePopoverMenuFocusManagement/noop.ts 100.00% <100.00%> (ø)
...sManagement/useNativePopoverMenuFocusManagement.ts 100.00% <100.00%> (ø)
...ponents/Table/TableEmptyStates/TableEmptyState.tsx 90.90% <100.00%> (-9.10%) ⬇️
...components/Table/TableFilterBar/TableSearchBar.tsx 100.00% <100.00%> (ø)
src/components/Table/TableRow.tsx 86.59% <100.00%> (+2.50%) ⬆️
src/components/Table/TableSemanticContainer.tsx 100.00% <100.00%> (ø)
src/components/Table/buildTableListData.ts 100.00% <100.00%> (ø)
src/components/Table/index.tsx 100.00% <ø> (ø)
... and 58 more
... and 16 files with indirect coverage changes

Comment thread src/components/Table/TableBody.tsx Outdated
Comment thread src/components/WorkspaceListLayout.tsx Outdated
Comment thread src/components/Table/types.ts Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Comment thread src/components/Table/TableBody.tsx Outdated
Comment thread src/components/Table/TableBody.tsx Outdated
Comment thread src/components/WorkspaceListLayout.tsx Outdated
@JS00001

JS00001 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor
image

The content scrolls behind the header, so we can see it

@shawnborton

Copy link
Copy Markdown
Contributor

Can we keep the border radius of the table header when we scroll? It looks like it turns into a squared edge:
CleanShot 2026-06-19 at 10 28 23@2x

@shawnborton

Copy link
Copy Markdown
Contributor

Otherwise feeling pretty good to me, very excited for this one!

trjExpensify
trjExpensify previously approved these changes Jun 19, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, good from product. 👍

@Krishna2323

Krishna2323 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@KJ21-ENG The list scrolling seems to get stuck after duplicating a workspace on iOS web, please check if it's also happening on main or not: Reproducible on staging also.

ios_mWeb.mp4

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! :shipit:

ios_hybrid.mp4
web_chrome.mp4

@melvin-bot
melvin-bot Bot requested review from JS00001 and luacmartins August 24, 2026 18:09
@JS00001

JS00001 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Lets ship it! @KJ21-ENG please keep an eye out for blockers, lets try to keep this on staging if we can

@JS00001
JS00001 merged commit c9a232f into Expensify:main Aug 24, 2026
37 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@luacmartins luacmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this through the finish line. Let's watch out for blockers!

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Sure, IMO we have already addressed good amount of potential blockers, Yaa but given the scale of this PR, there are high chances that some issues may still remain. WIll try to fix them ASAP if any found 🫡

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.60-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

I reviewed this PR against the help articles in App/docs/articles and no updates are needed.

This change is a presentation-layer refactor of the shared Table component — it adds headerComponent support so page-level controls (header content, buttons, search/filter bar) scroll away with the rows while the column header stays sticky, moves the empty/no-results states inside the scrolling list, and adds a native fix so focusing the table search bar scrolls it above the keyboard. It does not add, remove, or rename any feature, tab, setting, or button, and it does not change any user-facing workflow that the help site documents.

The help site describes what features do and how to accomplish tasks (managing categories, tags, members, company cards, rules, etc.), not the scroll/layout mechanics of the tables those pages render. None of that documented behavior changes here — a grep of App/docs/articles for scroll/sticky-header behavior returns nothing to update.

Because no docs update is warranted, I did not open a draft help site PR.


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker issue #99377 is repro on all PRs. Could you please double check if it's not introduced by #93877

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #99373 was identified to be related to this PR.

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

investigating these blockers.

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Deploy Blocker issue #99377 is repro on all PRs. Could you please double check if it's not introduced by #93877

Replied here #99377 (comment)

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.60-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants