Skip to content

Docs updates for E/A#89587 Update duplicate review flow to Keep selected - #91358

Merged
kadiealexander merged 1 commit into
mainfrom
docs/update-duplicate-review-flow-89587
May 29, 2026
Merged

kadiealexander merged 1 commit into
mainfrom
docs/update-duplicate-review-flow-89587

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Related PR

#89587

Test plan

  • Verify the article renders correctly on the help site
  • Verify button labels match the updated UI after the linked PR merges

The Review Duplicates screen now shows compact selectable rows with radio
buttons instead of large preview cards. Update help site article to reflect
the new "Keep selected" button (replacing "Keep this one") and the
selection step.

Co-authored-by: Nabi <nabi-ebrahimi@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 21, 2026
@stephanieelliott stephanieelliott self-assigned this May 22, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review May 27, 2026 04:50
@stephanieelliott
stephanieelliott self-requested a review as a code owner May 27, 2026 04:50
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a focused, well-scoped update to the duplicate expenses article, aligning documentation with a UI change from PR #89587. The changes rename Keep this one to Keep selected throughout the article, add a new step for selecting an expense via radio button, and update the keywords metadata. The changes are clean and correctly maintain the existing article structure.

Scores Summary

  • Readability: 9/10 - The new step (step 5) is clear and action-oriented. The renumbered steps maintain logical flow. The phrase "using the radio button next to it" is precise and helpful.
  • AI Readiness: 9/10 - Keywords are properly updated to reflect the new UI label. YAML metadata, headings, and internalScope remain intact and well-formed. The article retains its task-based heading structure.
  • Style Compliance: 9/10 - Button names Keep all, Keep selected, and Confirm are correctly bolded. The new UI terminology matches exact product labels. Step formatting follows the sequential, action-oriented standard.

Key Findings

  • The keyword update from keep this one to keep selected correctly ensures search and retrieval accuracy for the new UI label.
  • The added step (selecting an expense via radio button before choosing an action) improves procedural clarity and accurately reflects the updated UI flow.
  • All button references in the diff use proper bold formatting and match the new UI labels.
  • The "What happens after" section is correctly updated to reference Keep selected consistently.
  • No governance violations were found in the proposed changes.

Recommendations

  • No blocking issues. This PR is ready to merge from a documentation quality perspective.
  • Minor suggestion: Consider whether the keyword list should also drop keep this one entirely (it was replaced with keep selected), or retain it as a search fallback for users who may still search for the old label. This is a judgment call rather than a governance requirement.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md - Clean update. UI label rename, new procedural step added, keywords updated. No issues found.

3. Click **Review duplicates**.
4. Review the list of matched expenses flagged as duplicates.
5. Choose how to proceed:
5. Select the expense you want to keep using the radio button next to it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming / UI reference: Per HELPSITE_NAMING_CONVENTIONS.md, avoid generalizing UI elements — "radio button" is a generic control name, not an exact UI label. Consider describing the action without naming the control type, e.g.:

5. Select the expense you want to keep.

The user will see the selectable options in context; naming the control type adds implementation detail that could become stale if the UI changes.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a focused, well-scoped update to the duplicate expenses resolution article. It updates the UI button label from Keep this one to Keep selected, adds a new procedural step for selecting an expense via radio button, renumbers subsequent steps accordingly, and updates the keyword metadata. The changes are clean and align with governance standards.

Scores Summary

  • Readability: 9/10 - The new step 5 ("Select the expense you want to keep using the radio button next to it") is clear and action-oriented. Steps remain sequential and well-structured. Minor note: "using the radio button next to it" is slightly implementation-specific UI language, but acceptable for clarity.
  • AI Readiness: 9/10 - Keywords correctly updated from "keep this one" to "keep selected" to match the current UI. YAML metadata (title, description, internalScope) remains well-formed and aligned with search intent. No structural issues.
  • Style Compliance: 10/10 - Button labels (Keep all, Keep selected, Confirm, Review duplicates) are properly bolded and appear to match exact UI terminology. The terminology update from "Keep this one" to "Keep selected" is applied consistently across steps, outcome descriptions, and keywords.

Key Findings

  • The primary purpose of this PR -- updating UI button terminology -- is executed consistently across all occurrences in the file (keywords, steps, and outcome section).
  • The addition of step 5 fills a gap in the procedural flow by explicitly instructing the user to select an expense before choosing an action, which improves task completeness.
  • No governance violations detected in the proposed changes.

Recommendations

  • No blocking issues. This PR is ready to merge from a documentation quality perspective.
  • One minor suggestion: Verify that "Keep selected" is the exact label shown in the product UI across all platforms (web and mobile), per the Core UI Referencing Rules in the naming conventions.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md - UI terminology update and step addition. Clean and compliant.

@stephanieelliott
stephanieelliott requested a review from a team May 28, 2026 02:52
@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @kadiealexander

@melvin-bot
melvin-bot Bot requested review from kadiealexander and removed request for a team May 28, 2026 02:52
@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a focused, well-scoped update to the duplicate expenses article, renaming the Keep this one button to Keep selected and adding a new step (step 5) that instructs users to select an expense via a radio button. These changes appear to reflect a UI update in the product and correctly propagate the new terminology across all relevant locations in the article (keywords, steps, and outcome section).

Scores Summary

  • Readability: 9/10 - The new step 5 is clear and action-oriented. The renumbering is handled correctly. The step sequence reads naturally and maintains logical flow.
  • AI Readiness: 9/10 - Keywords are updated to match the new UI label ("keep selected" replaces "keep this one"), preserving search relevance. YAML metadata (title, description, keywords, internalScope) remains complete and well-formed. Heading hierarchy is unaffected.
  • Style Compliance: 9/10 - The button name Keep selected is properly bolded in all occurrences, consistent with governance rules. The new step uses clear, action-oriented language. One minor note: the phrase "using the radio button next to it" in step 5 references a UI element ("radio button") that is a generic control description rather than an exact UI label -- this is acceptable for clarity but worth noting.

Key Findings

  • The rename from "Keep this one" to "Keep selected" is applied consistently across all four locations: keywords, step 6 bullet, and both outcome bullets. No stale references remain.
  • The addition of step 5 ("Select the expense you want to keep using the radio button next to it") correctly reflects what appears to be a new or clarified UI interaction, and it logically precedes the "Choose how to proceed" step.
  • A typo in the old version ("duplicates are discards") has been correctly fixed to "duplicates are discarded" -- a good catch.
  • All button names remain properly bolded and in Sentence case per governance rules.

Recommendations

  • No blocking issues. This is a clean, well-executed terminology update.
  • Minor: Consider whether "radio button" is the most precise description of the UI control. If the product uses a different visual indicator (e.g., a selection circle or checkbox), the terminology should match the actual UI element per HELPSITE_NAMING_CONVENTIONS.md.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md -- Terminology update from "Keep this one" to "Keep selected", new selection step added, typo fix applied. All changes are compliant with governance standards.

This review assessed only the proposed changes in the PR diff, not unchanged content.

@kadiealexander
kadiealexander merged commit 53e43fb into main May 29, 2026
26 checks passed
@kadiealexander
kadiealexander deleted the docs/update-duplicate-review-flow-89587 branch May 29, 2026 05:15
@OSBotify

OSBotify commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.3.90-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@IuliiaHerets

Copy link
Copy Markdown

Any QA steps here?

cc @stephanieelliott @kadiealexander

@OSBotify

OSBotify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants