Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce28060cde
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@sobitneupane I’ve addressed the AI feedback. Thanks! Also, the ESLint failure isn’t related to this PR. |
trjExpensify
left a comment
There was a problem hiding this comment.
@nabi-ebrahimi can you make sure your tests and vids cover the dupe flow where they have to pick which expense details to keep in those one-by-one screens to make sure that's QA'd and is working correctly?
CC: @dannymcclain for a looksie on this PR too!
|
Looking good to me so far. |
|
@sobitneupane can you review this today, please? |
|
Yes, I will review it by EOD today. |
|
@sobitneupane, friendly bump. thanks. |
|
@nabi-ebrahimi It seems the UI doesn't match the expectations above. Could you please take a look and address it. Thanks. |
|
Agree with Shawn 👍 |
@sobitneupane, Addressed. I updated the right-side spacing so the radio now sits with ~12px from the amount/cash side and ~16px from the right edge. Could you please take another look? Thanks. cc @deetergp |
|
Looks better, thank you! |
deetergp
left a comment
There was a problem hiding this comment.
Code looks good and tests well 👍
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
Yes, help site changes are required. The PR replaces the Keep this one button with Keep selected and changes the duplicate review flow to use selectable expense rows with radio buttons. I've created a draft PR with the necessary updates to
Draft PR: #91358 |
|
Deploy Blocker #91367 was identified to be related to this PR. |
|
Deploy Blocker #91369 was identified to be related to this PR. |
|
@nabi-ebrahimi This PR is failing in step 5 because of a regression issue #91374
The issue is reproducible in: Web, Android Bug7160138_1779403791252.bandicam_2026-05-22_01-42-25-494.mp4
|
|
Deploy Blocker #91377 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|





Explanation of Change
This PR refreshes the first screen of the “Review duplicates” flow so it matches the newer compact expense review patterns used elsewhere in the app. Duplicate expenses are now shown as concise selectable rows instead of large preview cards, while still letting users open each expense for full details. The screen keeps the existing product behavior: users can either keep all duplicates or select one expense to continue through the current review flow.
Fixed Issues
$ #88342
PROPOSAL: #88342 (comment)
Tests
Create four expenses with the same amount, each using a different merchant category and unique tags.
Open the expense report containing those expenses.
Click “Review duplicates.”
Verify that the RHP panel displays compact duplicate expense cards for all four expenses created in Step 1.
Verify that each duplicate card displays the following details:
Verify that each duplicate card includes a selection control (radio button).
Verify that the bottom of the panel displays the following action buttons:
Select one of the duplicate expenses.
Click “Keep selected.”
Continue through the duplicate resolution flow by selecting which fields to keep (for example: category, tags, and other available attributes).
Verify that the selected expense is retained and the remaining duplicate expenses are resolved according to the chosen options.
Offline tests
Same as test.
QA Steps
Same as test.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Recording_20260512_191611.mp4
Android: mWeb Chrome
Recording_20260512_193837.mp4
iOS: Native
Screen.Recording.2026-05-12.at.6.39.27.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-05-12.at.6.43.37.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-12.at.6.20.35.PM.mov