[CP Staging] Fix disabled prop to only cover pending-delete transactions in group view by MelvinBot · Pull Request #90108 · Expensify/App

MelvinBot · 2026-05-09T17:00:15Z

Explanation of Change

The disabled prop on PressableWithFeedback in TransactionGroupListExpanded.tsx was set to isDeletedOrPendingDelete && !transaction.isSelected, which includes both trashed (deleted) and pending-delete transactions. This prevented onLongPress from firing on trashed expense rows because BaseGenericPressable suppresses all gestures when disabled is true.

Changed the disabled prop to use isTransactionPendingDelete(transaction) only, matching the behavior of TransactionListItem which uses disabled={isDisabled && !item.isSelected} where isDisabled is derived from pendingAction === 'delete' (not deletion status). Trashed items are handled separately via onPress={undefined}.

Fixed Issues

$ #90048

Tests

Launch the app and go to a workspace chat.
Create an expense and delete it.
Go to Spend > Expenses.
Type group-by:from status:deleted in the search field and search.
Expand the group row.
Long tap on the deleted expense row.
Verify the select option appears (multi-select mode activates).
Verify that expenses with a pending delete action (optimistic delete before server confirms) still cannot be interacted with.
Verify that no errors appear in the JS console.

Offline tests

N/A — this change only affects the disabled prop logic for already-deleted (trashed) expenses. Offline behavior for pending deletes is unchanged.

QA Steps

Go to a workspace chat and create an expense, then delete it.
Navigate to Spend > Expenses.
Search for group-by:from status:deleted.
Expand the group row.
Long tap on the deleted expense row.
Verify the select option appears.
Verify that no errors appear in the JS console.

PR Author Checklist

Screenshots/Videosundefined

…rashed ones The disabled prop on PressableWithFeedback in TransactionGroupListExpanded was using isDeletedOrPendingDelete which includes both trashed and pending-delete transactions. This prevented long-press selection on trashed expenses. Changed to use isTransactionPendingDelete only, matching the behavior of TransactionListItem which only disables for pending-delete items. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

Krishna2323 · 2026-05-09T17:03:49Z

@MelvinBot complete the checklist

MelvinBot · 2026-05-09T17:05:53Z

Checklist updated. I checked off items that are applicable or N/A for this single-line logic change (no new callbacks, copy, files, patterns, or JSDocs).

Items left unchecked that need human action:

Testing steps (Tests, Offline tests, QA Steps sections)
Screenshots/videos on all platforms
Platform test runs (Android, iOS, MacOS)
Console error verification

Krishna2323 · 2026-05-10T13:07:47Z

@MelvinBot add testing steps and open PR for review. The checklist also seems to be incomplete

melvin-bot · 2026-05-10T13:09:35Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-05-10T13:09:38Z

Updated the PR:

Testing steps added — Tests, Offline tests, and QA Steps sections now have steps based on the issue's reproduction flow.
Checklist completed — All applicable items checked; items requiring manual platform testing/screenshots left unchecked for the human co-author.
Marked as ready for review.

Krishna2323 · 2026-05-10T13:27:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM!

Krishna2323 · 2026-05-10T13:27:51Z

@codex review

chatgpt-codex-connector · 2026-05-10T13:29:47Z

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-05-11T12:12:08Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

…etedExpenses Fix disabled prop to only cover pending-delete transactions in group view (cherry picked from commit 85d6fdf) (cherry-picked to staging by mountiny)

OSBotify · 2026-05-11T12:16:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-11T12:16:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90108.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-85d6fdf-2e764a6-ca80a48ba345bde1d7a16fd1e5ced79354b3aa8e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-85d6fdf-2e764a6-90d0cb4c576dc71bfa74d3fceaee0e85fbe848ed/index.html

Web 🕸️
https://90108.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-11T12:37:37Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.69-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-05-11T12:38:54Z

No help site changes needed.

This PR is a one-line bug fix in TransactionGroupListExpanded.tsx that narrows the disabled prop from covering all deleted-or-pending-delete transactions to only pending-delete transactions. This allows users to long-press trashed expenses in grouped search results to select them.

Since this fix doesn't introduce new features, change UI labels, modify user workflows, or alter any documented behavior, no updates to App/docs/articles are required.

OSBotify · 2026-05-11T13:32:26Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.69-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-11T23:45:15Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-05-12T00:06:15Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

iOS

MelvinBot · 2026-05-12T00:07:43Z

No help site changes are required for this PR.

This is a one-line bug fix that narrows the disabled prop on PressableWithFeedback from isDeletedOrPendingDelete to isTransactionPendingDelete(transaction) only, restoring the ability to long-press on trashed expenses in group view for multi-select. It doesn't change any user-facing feature names, workflows, settings, or terminology — it simply fixes broken interaction behavior on already-deleted expenses.

OSBotify · 2026-05-13T01:20:25Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.72-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-13T01:21:35Z

No help site changes are needed for this PR.

This is a bug fix that narrows the disabled prop on a pressable component from isDeletedOrPendingDelete to isTransactionPendingDelete(transaction), allowing trashed expenses to be long-pressed for multi-select in grouped search results. It doesn't change any user-facing feature names, workflows, terminology, settings, or navigation paths that would be documented on the help site.

OSBotify · 2026-05-13T07:02:02Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.72-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned Krishna2323 May 9, 2026

MelvinBot requested a review from a team May 9, 2026 17:00

MelvinBot mentioned this pull request May 9, 2026

[Due for payment 2026-05-20] [Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view #90048

Closed

7 tasks

MelvinBot marked this pull request as ready for review May 10, 2026 13:09

MelvinBot requested a review from a team as a code owner May 10, 2026 13:09

melvin-bot Bot requested review from JmillsExpensify and Krishna2323 and removed request for a team and Krishna2323 May 10, 2026 13:09

Krishna2323 approved these changes May 10, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 May 10, 2026 13:27

JS00001 approved these changes May 11, 2026

View reviewed changes

JS00001 merged commit 85d6fdf into main May 11, 2026
57 of 60 checks passed

JS00001 deleted the claude-fixDisabledPropForDeletedExpenses branch May 11, 2026 12:07

mountiny changed the title ~~Fix disabled prop to only cover pending-delete transactions in group view~~ [CP Staging] Fix disabled prop to only cover pending-delete transactions in group view May 11, 2026

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 11, 2026

OSBotify mentioned this pull request May 11, 2026

Deploy Checklist: New Expensify 2026-05-08 #90006

Closed

Conversation

MelvinBot commented May 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videosundefined

Uh oh!

Krishna2323 commented May 9, 2026

Uh oh!

MelvinBot commented May 9, 2026

Uh oh!

Krishna2323 commented May 10, 2026

Uh oh!

melvin-bot Bot commented May 10, 2026

Uh oh!

MelvinBot commented May 10, 2026

Uh oh!

Krishna2323 commented May 10, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented May 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

MelvinBot commented May 11, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

OSBotify commented May 11, 2026

Uh oh!

OSBotify commented May 12, 2026

Uh oh!

MelvinBot commented May 12, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

MelvinBot commented May 13, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented May 9, 2026 •

edited by github-actions Bot

Loading