[Due for payment 2026-05-20] [Due for payment 2026-05-18] [$250] Android & iOS - Spend - Unable to long tap on deleted expense row on group-by view

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.69-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89364
Email or phone of affected tester (no customers): josdjnosdjionjsdonjisod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.4.2
App Component: Search

Action Performed:

1. Launch Expensify app.
2. Go to workspace chat.
3. Create an expense and delete it.
4. Go to Spend > Expenses.
5. Type group-by:from status:deleted on the search field and search.
6. Expand the row.
7. Long tap on the deleted expense.

Expected Result:

Select option will show up when long tapping on the deleted expense row.

Actual Result:

Select option does not show up when long tapping on the deleted expense row.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022053466999396668046
• Upwork Job ID: 2053466999396668046
• Last Price Increase: 2026-05-10

Issue Owner

Current Issue Owner: @Krishna2323

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #89364

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #89364 - "Fix nested row hover and click in grouped search results" by @MelvinBot (High confidence)
Related Issues: #88729

Recommendation: REVERT

PR #89364 introduced a regression where long-pressing a deleted expense row in the group-by view no longer triggers selection mode. The fix is straightforward and the PR can be cleanly reverted.

Assigned: @MelvinBot (PR author), @JS00001 (approving reviewer), @Krishna2323 (approving reviewer), @trjExpensify (approving reviewer) from highest-confidence causing PR only
Labels: DeployBlockerCash kept (frontend App PR is the cause). DeployBlocker is not present and was not added.

Detailed Analysis

Evidence

• The issue reports that long-tapping a deleted expense in the group-by (group-by:from status:deleted) view does not show the "Select" option on Android and iOS native apps.
• PR Fix nested row hover and click in grouped search results #89364 modified src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx to wrap all transaction rows (including deleted ones) in PressableWithFeedback on all screen sizes.
• As part of that change, the PR added disabled={isDeletedOrPendingDelete && !transaction.isSelected} to the PressableWithFeedback.
• The intent was to prevent navigation when tapping a deleted/pending-delete row, but the disabled prop also suppresses onLongPress.
• In BaseGenericPressable.tsx (line 92-95), onLongPressHandler returns early when isDisabled is true — meaning onLongPress never fires.
• Before PR Fix nested row hover and click in grouped search results #89364, deleted transaction rows on narrow (mobile) layouts were wrapped with PressableWithFeedback that did NOT have a disabled prop, so long press worked correctly.
• The issue is only reproducible on staging (not production), confirming it was introduced in this staging release.

Verification

• Affected file: src/components/Search/SearchList/ListItem/TransactionGroupListExpanded.tsx
• PR Fix nested row hover and click in grouped search results #89364 directly modifies this file (one of only two files changed in the PR).
• The disabled prop on PressableWithFeedback propagates to GenericPressable / BaseGenericPressable, where onLongPressHandler guards with if (isDisabled) { return; } at line 93.

Root Cause

PR #89364 added disabled={isDeletedOrPendingDelete && !transaction.isSelected} to the PressableWithFeedback wrapping each transaction row in the expanded group view. For a deleted transaction that has not yet been selected (transaction.isSelected === false), this evaluates to true, making the entire pressable disabled. React Native's Pressable (and the GenericPressable wrapper) block all gestures — including onLongPress — when disabled is true. This prevents the user from initiating selection mode via long press on deleted expense rows. The fix should avoid using the disabled prop to block navigation; instead, the onPress handler already handles this case by checking isDeletedOrPendingDelete && !canSelectMultiple and setting onPress={undefined} when appropriate, which is the correct pattern for allowing long press while blocking tap navigation.

[MelvinBot]

Proposal

What is the root cause of that problem?

In TransactionGroupListExpanded.tsx:277, the disabled prop on the PressableWithFeedback is set to isDeletedOrPendingDelete && !transaction.isSelected. For any deleted expense that hasn't been selected yet, this evaluates to true.

When disabled is true, BaseGenericPressable.tsx:182 suppresses onLongPress entirely (onLongPress={!isDisabled && onLongPress ? onLongPressHandler : undefined}), so the user can never long-press to select deleted rows.

The non-grouped TransactionListItem.tsx:206 does not have this problem because it uses disabled={isDisabled && !item.isSelected} — it relies on the parent isDisabled prop rather than deriving disabled state from the deletion status.

What changes do you think we should make in order to solve the problem?

Change the disabled prop in TransactionGroupListExpanded.tsx from:

disabled={isDeletedOrPendingDelete && !transaction.isSelected}

to:

disabled={false}

The onPress handler on line 276 already correctly blocks navigation for deleted rows by being set to undefined when isDeletedOrPendingDelete && !canSelectMultiple. The visual cursor style is separately handled by wrapperStyle on line 284. So the disabled prop is redundant for blocking taps and harmful for blocking long-press.

What alternative solutions did you explore? (Optional)

We could match TransactionListItem's exact pattern (disabled={isDisabled && !transaction.isSelected}) but since the parent isDisabled is not currently used in this context, both approaches are equivalent. The key insight is that disabled must not be derived from isDeletedOrPendingDelete because it blocks onLongPress.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[Krishna2323]

@MelvinBot The fix should change the disabled prop to only cover pending-delete items, not trashed ones. TransactionListItem uses disabled={isDisabled && !item.isSelected} where isDisabled is pendingAction === 'delete' (from SearchList/index.tsx). It never includes trashed items (isDeletedTransaction) in the disabled check — those are handled separately via onPress={undefined}.

So the fix should be:

- disabled={isDeletedOrPendingDelete && !transaction.isSelected}
+ disabled={isTransactionPendingDelete(transaction) && !transaction.isSelected}

isTransactionPendingDelete is already imported and used in the file. The other isDeletedOrPendingDelete usages (onPress, wrapperStyle, onArrowRightPress) are correct and should stay as-is. Please verify this matches TransactionListItem behavior and implement this.

[MelvinBot]

🤖 Draft PR created: #90108

Changed the disabled prop from isDeletedOrPendingDelete && !transaction.isSelected to isTransactionPendingDelete(transaction) && !transaction.isSelected, matching TransactionListItem behavior where only pending-delete items are disabled (trashed items are handled via onPress={undefined}).

Please mark it as "Ready for review" when it is ready for review.