Perf: create derived TODOS by LukasMod · Pull Request #81188 · Expensify/App

LukasMod · 2026-02-02T15:47:47Z

Explanation of Change

Move reusable categorization logic (categorizing reports into submit/approve/pay/export buckets) from the useTodos hook into an Onyx derived value at ONYXKEYS.DERIVED.TODOS. This derived value computes only the categorized report arrays and transaction mappings at the Onyx level. Components can then use selectors to extract just the report counts from the derived value, avoiding the heavy search results data construction entirely. The useTodos hook subscribes to this derived value and builds the full search results data structure only when required by SearchContext, ensuring the expensive computation runs fewer times.

Fixed Issues

$ #81353

Tests

Create workspace
Create expense
Verify if there is change in counters (Submit: 1, Approve: 0, Pay: 0) and in Home tab (For you section)
Press Submit on expense
Verify if there is change in counters (Submit: 0, Approve: 1, Pay: 0) and in Home tab (For you section)
Press Approve on expense
Verify if there is change in counters (Submit: 0, Approve: 0, Pay: 1) and in Home tab (For you section)
Press Pay on expense
Verify if there is change in counters (Submit: 0, Approve: 0, Pay: 0) and in Home tab (For you section - empty)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios-native.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.chrome.mov

…to perf/span-open-report-todos

codecov · 2026-02-03T09:08:31Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`87.50% <100.00%> (+0.10%)`	⬆️
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/components/Search/SearchContext.tsx	`36.73% <100.00%> (ø)`
src/hooks/useSearchTypeMenuSections.ts	`100.00% <100.00%> (ø)`
src/hooks/useTodos.ts	`88.13% <100.00%> (-2.59%)`	⬇️
...rc/libs/actions/OnyxDerived/ONYX_DERIVED_VALUES.ts	`100.00% <ø> (ø)`
src/libs/actions/OnyxDerived/configs/todos.ts	`100.00% <100.00%> (ø)`
src/pages/home/ForYouSection/index.tsx	`88.88% <100.00%> (+1.38%)`	⬆️
src/selectors/Todos.ts	`100.00% <100.00%> (ø)`
... and 12 files with indirect coverage changes

mountiny · 2026-02-03T22:35:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da76cf224d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Krishna2323 · 2026-02-03T23:14:05Z

I can start reviewing this immediately.

LukasMod · 2026-02-04T09:11:05Z

@codex review

melvin-bot · 2026-02-04T09:12:05Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-02-04T15:05:51Z

I haven’t found any blocking issues so far and am working on the checklist.

luacmartins · 2026-02-04T15:14:58Z

+        [CONST.SEARCH.SEARCH_KEYS.SUBMIT]: buildData(todosReports?.reportsToSubmit),
+        [CONST.SEARCH.SEARCH_KEYS.APPROVE]: buildData(todosReports?.reportsToApprove),
+        [CONST.SEARCH.SEARCH_KEYS.PAY]: buildData(todosReports?.reportsToPay),
+        [CONST.SEARCH.SEARCH_KEYS.EXPORT]: buildData(todosReports?.reportsToExport),


With this approach, we're still building the data in the hook. Would it be better to store the built data in the derived value?

The comment above is NAB since this already introduces significant gains in performance. That said, let me know what you think of it.

I already tried to put this also inside DERIVED.TODOS but it creates a huge object (like 5x bigger) which cause onyx internal kills all gains from it. There was like additional 300ms spend on recomputing that derived value. Right know this hook is used in single place (context)

Ah I see. Thanks for the context

I shared some more context in issue, as it was my first idea #77173 (comment)

chatgpt-codex-connector · 2026-02-04T15:16:57Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Krishna2323 · 2026-02-04T15:51:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome_offline.mp4

web_chrome.mp4

Krishna2323 · 2026-02-04T15:52:29Z

There are some Onyx console errors. I’m checking whether they also exist on main.

errors_onyx.mp4

Krishna2323 · 2026-02-04T16:00:18Z

Can reproduce these errors ^ on main also, asked in open source channel.

Krishna2323

Code looks good to me and works well in both online and offline modes. 🚀

luacmartins · 2026-02-04T16:13:35Z

@codex review

chatgpt-codex-connector · 2026-02-04T16:32:02Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

luacmartins

LGTM

luacmartins · 2026-02-04T17:57:32Z

@LukasMod we have conflicts

joekaufmanexpensify · 2026-02-04T18:22:10Z

No product review needed

mountiny · 2026-02-05T05:21:55Z

@codex review

chatgpt-codex-connector · 2026-02-05T05:38:29Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…to perf/span-open-report-todos

OSBotify · 2026-02-05T20:48:48Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.13-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T21:49:14Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

vincdargento · 2026-02-05T23:31:01Z

@LukasMod This PR is failing because of a regression issue #81613
The issue is reproducible in: Web

bug.mp4

LukasMod · 2026-02-06T12:55:18Z

@vincdargento Looks like its proper behavior based on #81355

OSBotify · 2026-02-10T07:05:09Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

LukasMod added 2 commits February 2, 2026 15:08

add TODOS derived value

32b3882

restore ??= for createTodosReportsAndTransactions

28ca773

melvin-bot Bot assigned LukasMod Feb 2, 2026

LukasMod added 4 commits February 2, 2026 18:37

update selector filename

5db17a1

add OnyxDerived unit tests

af59680

add selector tests

06ca5cf

update useTodos tests

25f907c

JKobrynski reviewed Feb 2, 2026

View reviewed changes

Comment thread src/libs/actions/OnyxDerived/configs/todos.ts Outdated

JKobrynski reviewed Feb 2, 2026

View reviewed changes

Comment thread src/libs/actions/OnyxDerived/configs/todos.ts Outdated

clean up after CR

b0e2c63

LukasMod mentioned this pull request Feb 3, 2026

[Metrics] Improve Open Report Performance #77173

Open

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

da76cf2

…to perf/span-open-report-todos

luacmartins self-requested a review February 3, 2026 18:52

chatgpt-codex-connector Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread src/libs/actions/OnyxDerived/configs/todos.ts Outdated

mountiny requested a review from Krishna2323 February 3, 2026 23:40

Krishna2323 reviewed Feb 4, 2026

View reviewed changes

Comment thread src/selectors/Todos.ts Outdated

Comment thread src/hooks/useTodos.ts

LukasMod added 2 commits February 4, 2026 08:42

remove todosReportCountsSelector fallbacks

6641609

fix primary/secondary login issue in createOnyxDerivedValueConfig

38a2f47

fix prettier

21f1f77

LukasMod marked this pull request as ready for review February 4, 2026 09:11

LukasMod requested review from a team as code owners February 4, 2026 09:11

melvin-bot Bot requested review from Krishna2323 and joekaufmanexpensify and removed request for a team February 4, 2026 09:12

luacmartins reviewed Feb 4, 2026

View reviewed changes

Krishna2323 approved these changes Feb 4, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins February 4, 2026 16:01

luacmartins previously approved these changes Feb 4, 2026

View reviewed changes

joekaufmanexpensify removed their request for review February 4, 2026 18:22

Merge branch 'main' of github.com:callstack-internal/Expensify-App in…

7648848

…to perf/span-open-report-todos

LukasMod dismissed luacmartins’s stale review via 7648848 February 5, 2026 08:09

luacmartins approved these changes Feb 5, 2026

View reviewed changes

luacmartins merged commit faed91f into Expensify:main Feb 5, 2026
32 checks passed

github-actions Bot mentioned this pull request Feb 5, 2026

Investigate workflow job failing on main: chooseDeployActions #81559

Closed

OSBotify mentioned this pull request Feb 5, 2026

Deploy Checklist: New Expensify 2026-02-05 #81590

Closed

vincdargento mentioned this pull request Feb 5, 2026

[$250] Reports - Counters doesn't show 0 when there are no pending expenses #81613

Closed

2 of 7 tasks

Krishna2323 mentioned this pull request Feb 12, 2026

[Due for payment 2025-02-17][PERF] Eliminate redundant Todos computations by using Onyx derived values #81353

Closed

quinthar added the #quality label Aug 11, 2026

Conversation

LukasMod commented Feb 2, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Feb 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

LukasMod commented Feb 4, 2026

Uh oh!

melvin-bot Bot commented Feb 4, 2026

Uh oh!

Krishna2323 commented Feb 4, 2026

Uh oh!

luacmartins Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

LukasMod Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Feb 4, 2026

Uh oh!

Krishna2323 commented Feb 4, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Feb 4, 2026

Uh oh!

Krishna2323 commented Feb 4, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Feb 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Feb 4, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Feb 4, 2026

Uh oh!

joekaufmanexpensify commented Feb 4, 2026

Uh oh!

mountiny commented Feb 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Feb 5, 2026

Uh oh!

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

LukasMod commented Feb 2, 2026 •

edited by mountiny

Loading

codecov Bot commented Feb 3, 2026 •

edited by github-actions Bot

Loading