-
Notifications
You must be signed in to change notification settings - Fork 4k
[Sprint] Release 3.1 - Creating a new Personal Card Feed #80648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
94c6a8d
lots of placeholder code worth saving
Gonals b145fc0
Add draft
Gonals 90a7ac5
new pages
Gonals 1d68335
bunch of date handling
Gonals 7857b51
Let's add release 1 code for testing
Gonals ae937c7
better IDs
Gonals 17c936f
Add file
Gonals 4757bab
better cardIDs
Gonals 9528a6c
better translations
Gonals 6d0f85e
prettier
Gonals 9571ccf
properly format button
Gonals e7ca91c
conflicts
Gonals 30d13fc
comment
Gonals e9cae47
remove uneeded file
Gonals b54f090
fix errors
Gonals f7cb785
fix a bunch of errors
Gonals e45637c
cell format
Gonals 551b336
typescript fix
Gonals 337eaf8
one more
Gonals 87c8139
Merge branch 'main' into alberto-release3
Gonals 3129d58
a few more
Gonals 6880b25
translations
Gonals 097225f
better styling
Gonals 9d33861
and more
Gonals 73730da
conflicts
Gonals 058f86f
prettier
Gonals e308138
linter
Gonals b88269d
lint
Gonals a87a9c4
lint
Gonals e0470e2
another try
Gonals e94679e
another
Gonals 87a5f5e
navigate back
Gonals 12de07b
hide behind beta
Gonals 4199f66
prettier
Gonals 93c4643
fix cursors
Gonals 81cbcba
Card name required
Gonals 186c96d
use numbers
Gonals 47faaaf
better transition
Gonals 5ec797d
conflicts
Gonals 1943b27
remove deprecated and displaynames
Gonals b705e49
Merge branch 'main' into alberto-release3
Gonals ce6558a
prettier
Gonals 38618b0
actual hook
Gonals feed797
conflicts
Gonals 97e96b1
lint
Gonals b7a6508
key bug
Gonals cc115e9
transition
Gonals cbcb187
unrelated changes
Gonals File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule Mobile-Expensify
updated
from 00ea0c to 6d9ea2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -430,14 +430,7 @@ function BasePopoverMenu({ | |
| if (!headerText || enteredSubMenuIndexes.length !== 0) { | ||
| return; | ||
| } | ||
| return ( | ||
| <Text | ||
| key="header-text" | ||
| style={[styles.createMenuHeaderText, styles.ph5, styles.pv3, headerStyles]} | ||
| > | ||
| {headerText} | ||
| </Text> | ||
| ); | ||
| return <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pv3, headerStyles]}>{headerText}</Text>; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Gonals is there any reason you removed the key prop from here? It's causing this issue.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was a weird merge conflict. Fixing it in the other PR |
||
| }; | ||
|
|
||
| useKeyboardShortcut( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this safe change?
ImportSpreadSheetis common component and we should make sure that this doesn't cause regressions on other pages like categories, tags, per diem etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing around and it seems fine. It is mainly for dates