[Sprint] Release 3.1 - Creating a new Personal Card Feed - #80648
Conversation
|
@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #80990. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97e96b10ce
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Bug - Draft data is not cleared after exiting the import flowMonosnap.screencast.2026-01-30.21-19-33.mp4Bug - Console error:
|
|
|
@Gonals the toggle btn values does not persists, is that also expected? Monosnap.screencast.2026-01-31.00-08-15.mp4 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
| {headerText} | ||
| </Text> | ||
| ); | ||
| return <Text style={[styles.createMenuHeaderText, styles.ph5, styles.pv3, headerStyles]}>{headerText}</Text>; |
There was a problem hiding this comment.
@Gonals is there any reason you removed the key prop from here? It's causing this issue.
There was a problem hiding this comment.
It was a weird merge conflict. Fixing it in the other PR
|
🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.3.11-16 🚀
|
|
@Gonals @MarioExpensify Just wanted to confirm whether I’m eligible for payment here or not. I did the entire code review and found few bugs, but I went offline. Later, @aimane-chnaif handled the remaining review and checklist to speed up the merge. |
I'd say you are eligible, yes |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
| const errors: FormInputErrors<typeof ONYXKEYS.FORMS.IMPORT_TRANSACTIONS_FORM> = {}; | ||
| const name = values.cardDisplayName.trim(); | ||
|
|
||
| if ([...name].length > CONST.TITLE_CHARACTER_LIMIT) { |
There was a problem hiding this comment.
We should use the same validation method on the card name edit page here:
App/src/pages/workspace/expensifyCard/WorkspaceEditCardNamePage.tsx
Lines 58 to 61 in a93a316
More details: #82487 (comment)
| <ImportSpreadsheetColumns | ||
| spreadsheetColumns={spreadsheetColumns} | ||
| columnNames={columnNames} | ||
| importFunction={importTransactions} | ||
| errors={isValidationEnabled ? validate() : undefined} | ||
| columnRoles={columnRoles} | ||
| isButtonLoading={isImporting} | ||
| /> |
There was a problem hiding this comment.
From #92665
The "Learn more" link is unresponsive because TransactionsImportedPage.tsx renders without the learnMoreLink prop. The component renders the link as <TextLink href={learnMoreLink ?? ''}>, so when the prop is missing the href falls back to '' and clicking does nothing.
7 participants
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/593048
PROPOSAL:
Tests
Provide a card name and follow the flow
Import some transactions:
fake_transactions-2026-01-16 10_56_55.629.csv
Assign the attributes to columns. Confirm you need to have the required ones assigned and can't move forward with the same one assigned twice.
Complete the flow. Confirm the card displays:
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari