Accessibility/fix: Add accessibilityLabel to currency, flip and locale pickers by ashu75575 · Pull Request #80241 · Expensify/App

ashu75575 · 2026-01-22T15:05:04Z

Explanation of Change

This PR adds accessibilityLabel to the language picker on the sign-in page, as well as to the currency picker and flip amount button.

Specifically:

The language picker now exposes an explicit accessible label for screen readers.
Currency selection and amount flip buttons in NumberWithSymbolForm now include accessible names instead of relying on visual context.

These changes improve screen reader clarity without affecting visual behavior or user interactions.

Fixed Issues

$ #79239
PROPOSAL: #79239 (comment)

Tests

For #77373
Prerequisites:
the user is signed in

Open the Expensify app
Tap the Create '+' button > Create Expense
Verify currency and flip button are announced correctly with screen reader

For #77248
Prerequisites:
the user is not signed in

Open the Expensify app
Observe language selector is displayed in the footer area.
Verify language selector are announced correctly with screen reader
Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Note: This is a screen reader accessibility change with no visual differences. Testing requires screen reader software (VoiceOver on iOS/macOS or TalkBack on Android).

melvin-bot · 2026-01-22T15:05:11Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2026-01-23T11:02:45Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5baab7e291

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-23T11:15:35Z

                                style={styles.minWidth18}
                                isContentCentered
                                text={currency}
+                                accessibilityLabel={translate('common.selectCurrency')}


Include selected currency in accessibility label

Setting accessibilityLabel on this button overrides the visible text for screen readers (VoiceOver/TalkBack/ARIA), so users will now hear only “Select currency” and lose the currently selected currency (e.g., USD). This is a regression for screen reader users because the control no longer conveys the current value. Consider including the currency in the label (e.g., “Select currency, currently USD”) or omitting the explicit label so the button text remains the accessible name.

Useful? React with 👍 / 👎.

Pujan92 · 2026-01-29T12:58:04Z

                                style={styles.minWidth18}
                                isContentCentered
                                text={currency}
+                                accessibilityLabel={translate('common.selectCurrency')}


Suggested change

accessibilityLabel={translate('common.selectCurrency')}

accessibilityLabel={`${translate('common.selectCurrency')}, ${currency}`}

Agree with the above comment, we need to set text that tells the user also about the selected currency.

Pujan92 · 2026-01-29T12:58:32Z

                        style={styles.minWidth18}
                        isContentCentered
                        text={currency}
+                        accessibilityLabel={translate('common.selectCurrency')}


Need similar change here

Pujan92 · 2026-01-29T13:30:29Z

    return (
        <Picker
            label={size === 'normal' ? translate('languagePage.language') : null}
+            accessibilityLabel={translate('languagePage.language')}


Suggested change

accessibilityLabel={translate('languagePage.language')}

accessibilityLabel={`${translate('common.select')} ${translate('languagePage.language')}`}

Pujan92 · 2026-02-01T10:39:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Pujan92 · 2026-02-01T11:15:36Z

#77373 - Fixed

#77248 - Fixed

#76927 - No change needed

Pujan92

LGTM!

JmillsExpensify

Good accessibility improvements that don't change core product behaviors.

OSBotify · 2026-02-03T21:28:30Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.3.11-42 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:19:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Add accessibilityLabel to currency, flip and locale pickers

5baab7e

melvin-bot Bot assigned ashu75575 Jan 22, 2026

ashu75575 marked this pull request as ready for review January 23, 2026 11:02

ashu75575 requested review from a team as code owners January 23, 2026 11:02

melvin-bot Bot requested review from JmillsExpensify and Pujan92 and removed request for a team January 23, 2026 11:02

melvin-bot Bot removed the request for review from a team January 23, 2026 11:02

chatgpt-codex-connector Bot reviewed Jan 23, 2026

View reviewed changes

Pujan92 reviewed Jan 29, 2026

View reviewed changes

ashu75575 and others added 2 commits January 29, 2026 20:48

fix accessibilityLabel

14b8536

Merge branch 'Expensify:main' into issue/79239

d6e0b60

Pujan92 approved these changes Feb 1, 2026

View reviewed changes

melvin-bot Bot requested a review from Beamanator February 1, 2026 11:16

JmillsExpensify approved these changes Feb 2, 2026

View reviewed changes

Beamanator approved these changes Feb 3, 2026

View reviewed changes

Beamanator merged commit a6dcc79 into Expensify:main Feb 3, 2026
31 checks passed

OSBotify mentioned this pull request Feb 3, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

Uzaifm127 mentioned this pull request Feb 10, 2026

fix: [Accessibility][Tracking] Add/Update accessibilityLabel #80496

Merged

53 tasks

ashu75575 deleted the issue/79239 branch July 28, 2026 00:19

	accessibilityLabel={translate('common.selectCurrency')}
	accessibilityLabel={`${translate('common.selectCurrency')}, ${currency}`}

	accessibilityLabel={translate('languagePage.language')}
	accessibilityLabel={`${translate('common.select')} ${translate('languagePage.language')}`}

Uh oh!

Conversation

ashu75575 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 22, 2026

Uh oh!

melvin-bot Bot commented Jan 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 commented Feb 1, 2026

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Feb 3, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ashu75575 commented Jan 22, 2026 •

edited

Loading

Pujan92 commented Feb 1, 2026 •

edited

Loading