Conversation
…lected in Account
…de sender name, time sent and message text
…in Amount (currency) for Android/iOS
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
…oup button in group chat while selecting participants
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| const amountOfUnions = stepNames.length - 1; | ||
|
|
||
| const isWeb = getPlatform() === CONST.PLATFORM.WEB; |
There was a problem hiding this comment.
❌ CONSISTENCY-1 (docs)
Platform-specific logic (getPlatform) is hardcoded within the component. This increases maintenance overhead and complexity.
Suggested fix: Use platform-specific file extensions to handle this logic separately:
- Create
InteractiveStepSubHeader.web.tsxandInteractiveStepSubHeader.native.tsx - Or move the platform check to a parent component and pass the behavior as a prop
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
| clearNegative={clearNegative} | ||
| onFocus={props.onFocus} | ||
| accessibilityLabel={`${translate('iou.amount')} (${currency})`} | ||
| accessibilityLabel={Platform.OS === 'web' ? `${translate('iou.amount')} (${currency})` : undefined} |
There was a problem hiding this comment.
❌ CONSISTENCY-1 (docs)
Platform-specific logic (Platform.OS) is hardcoded within the component. This increases maintenance overhead and complexity.
Suggested fix: Use platform-specific file extensions to handle this logic separately:
- Create
MoneyRequestAmountInput.web.tsxandMoneyRequestAmountInput.native.tsx - Or handle the accessibility label difference through a utility function in a platform-specific module
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93cf24d1f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ]} | ||
| disabled={isLockedStep || !onStepSelected} | ||
| onPress={moveToStep} | ||
| accessible | ||
| accessibilityLabel={`${index + 1}`} | ||
| aria-current={currentStep === index ? 'step' : undefined} | ||
| accessible={false} | ||
| aria-hidden={!isWeb} |
There was a problem hiding this comment.
Setting accessible={false} on the step PressableWithFeedback removes each step button from the accessibility tree, so screen reader users can no longer focus or activate individual steps (the parent View is focusable but has no press action). This regresses step navigation for VoiceOver/TalkBack users in flows where they need to jump between steps; the previous accessibilityLabel/aria-current on each button provided that access.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I see only for MissingPersonalDetailsContent we have the step navigation enabled. In future, if we have more components then we can decide the accessibility on parent or child dynamically.
|
No product considerations, removing my review |
|
@Uzaifm127 Also check and fix the lint failure. |
|
@Pujan92 Will look into the failing test tomorrow. |
|
Ok, sentryLabel needs to be added for Pressable in the touched files. |
|
@Pujan92 Fixed the eslint failure check. |
|
🚧 @inimaga has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.3.19-0 🚀
|
|
@Uzaifm127 It looks like the “Add to group” button is only inaccessible on iOS. Could you check if there’s anything we should do on our end? Test1.mp4 |
|
@nlemma Will try to respond on this before EOD. Thanks for waiting. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.19-5 🚀
|
|
@nlemma Add to group button is inaccessible in iOS because it is the by default behaviour of iOS. it isn't caused by this PR or a missing case of this. Here is the video I recorded with the old version of the app (Before this latest release on staging and production): ios-native.movThe reason it is in-accessible in iOS only is, when a container or a box is accessible in iOS then all the items or children inside it are in-accessible by default. This is the default behaviour which existed before too. Here the Add to group is there inside the list item or participant. We could make the parent in-accessible but that might leads to other regressions. Should we open a new issue for this? |
|
@Uzaifm127 Your assessment is fair. I agree that its out of scope for this PR and should be handled in a separate issue. We'll probably open up an issue for it after v1 changes are completed and its flagged as an issue. |
6 participants
Explanation of Change
accessbilityLabelfor chat messages to includesender name,time sentandmessage text.accessbilityLabelfor status button in profile to includeStatus, Emoji not selectedwhen no status is there.accessbilityLabelfor switch buttons in Distance rates.accessbilityLabelfor step buttons.accessbilityLabelto Language picker in Sign in screen.accessbilityLabelto social icons in sign in screen.accessbilityLabelof amount input to include the amount on Android/iOS. - (Didn't include tests for this)accessbilityLabelfor Checkbox and Add to group button in the participant page.Fixed Issues
$ #77454
$ #77412
$ #77365
$ #76906
$ #76905
$ #74855
$ #74853
$ #79233
PROPOSAL: #79233 (comment)
Tests
Test 1: Checkbox and Add to group button announcement on group chat - #77454
Add to groupbutton.Add to groupbutton is announced asAdd [username] to group.Add to groupbutton.[username] selected.Test 2: All chat messages are announced as 'chat message' - #77412
sender's name,time sentandmessage text.Test 3: Status button in profile page announcement - #77365
Precondition: You must not have any status selected in the profile page.
Test 4: Switch button in Distance rates - #76906
Default Rate, [currency][amount] / mile, on, switch.Test 5: Social links announcement on landing page - #74853
Test 6: The combobox of Language has no programmatic name - #74855
Test 7: Step buttons isn't being announced correctly - #76905
Precondition: You must not have any Expensify card issued before.
Offline tests
Same as Test
QA Steps
Same as Test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
#77454
checkbox-and-add-to-group-issue-while-adding-participants.mp4
#77412
chat-message-announcement-issue.mp4
#77365
Status-button-profile-page-issue.mp4
#76905
step-button-issue.mp4
Android: mWeb Chrome
N/A - Accessibility changes
iOS: Native
N/A - Accessibility changes
iOS: mWeb Safari
N/A - Accessibility changes
MacOS: Chrome / Safari
#76906
Distance-rates-switch-issue.mp4
#74853 - Ubuntu
Language-dropdown-issue-ubuntu.mp4
#74853 - Mac
Social-links-landing-page-issue.mov
#74855
Language-dropdown-issue.mov
#76905
Steps-section-announcement-issue.mp4