[No QA] HelpDot: add New Expensify domain admins doc (Release 1) - #79989
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@stephanieelliott One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
HelpDot Documentation ReviewOverall AssessmentThis PR successfully creates a new Domains hub for New Expensify and migrates relevant articles from the Workspaces hub. The documentation includes four new articles (Domain Admins, Domain Groups, Domain Members, and Domain Migration) plus two reorganized articles (Claim and Verify a Domain, Set Up SAML SSO). The overall structure is logical, the writing is clear, and the organization improves discoverability of domain-related features. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
RecommendationsPriority Actions:
Suggestions for Enhancement:
Nice-to-haves:
Files Reviewed
Overall Verdict: This is a high-quality documentation update that significantly improves the organization and discoverability of domain-related features. The new articles are well-written and provide clear, actionable guidance. With minor corrections (especially the closing tag), this will be ready to merge. Note: I have also provided detailed inline comments on specific lines for granular feedback. |
This comment was marked as outdated.
This comment was marked as outdated.
|
HOLD this on deploying the functionality. |
|
Hey @twisterdotcom heads up some of this conflicts with this PR: #79747 The New/Domains hub was already created with that PR and the existing articles moved over. So all we need to do here is just move the new articles in I think! |
stephanieelliott
left a comment
There was a problem hiding this comment.
Left some suggestions for formatting and add'l FAQ
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Co-authored-by: Stephanie Elliott <31225194+stephanieelliott@users.noreply.github.com>
Added section on who can be a Domain Admin.
|
Finally did this @stephanieelliott |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.11-16 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/577567
Adds New Expensify help docs for Domain Admins, plus minor updates to Claim and Verify a Domain and a redirect to preserve the legacy Workspaces URL.
Tests
Web QA
N/A
Mobile QA
No mobile QA