Fix/75881 - Redirected to Workflow page instead of Frequency page after date selection refresh by dmkt9 · Pull Request #77653 · Expensify/App

dmkt9 · 2025-12-15T10:37:20Z

Explanation of Change

When the user opens the app or refreshes the app while on the modal for selecting the date of the month in the submission frequency, after the refresh, any date the user selects will navigate to the workflow page instead of the Frequency page.

This PR ensures that the user will be navigated correctly after selecting a date.

Fixed Issues

$ #75881
PROPOSAL: #75881 (comment) #75881 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to https://staging.new.expensify.com/home
Create a workspace
Tap workflow - submission frequency - Frequency
Select Monthly
Tap date of month
Refresh the page
Select any date
Verify that the user directed to Frequency page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

mac.safari.mp4

…e selection refresh

melvin-bot · 2025-12-15T10:37:27Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-15T10:46:08Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/AccessOrNotFoundWrapper.tsx	`74.54% <100.00%> (ø)`
... and 137 files with indirect coverage changes

huult · 2025-12-15T14:59:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-06.at.16.08.01.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-06.at.16.08.55.mp4

iOS: HybridApp

Screen.Recording.2026-01-06.at.16.11.00.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-06.at.16.11.40.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-06.at.16.06.17.mp4

huult · 2025-12-15T15:10:53Z

    const onSelectDayOfMonth = (item: WorkspaceAutoReportingMonthlyOffsetPageItem) => {
        setWorkspaceAutoReportingMonthlyOffset(policy?.id, item.isNumber ? parseInt(item.keyForList, 10) : (item.keyForList as AutoReportingOffsetKeys));
-        Navigation.goBack(ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_FREQUENCY.getRoute(policy?.id));
+        Navigation.setNavigationActionToMicrotaskQueue(() => {


Suggested change

Navigation.setNavigationActionToMicrotaskQueue(() => {

navigateBackAfterPolicyUpdate(() => {

@dmkt9 I tested the native app, and the flicker issue does not occur on the native platform. Therefore, we won't add this to the native app, because if we do, we might see the scroll-up issue, like in this video.

Screen.Recording.2025-12-15.at.22.06.27.mov

Therefore, we should update setNavigationActionToMicrotaskQueue to be added only for the web platform. For example, in navigateBackAfterPolicyUpdate within helpers, create two files: index.ts and index.native.ts, and wrap navigateBackAfterPolicyUpdate with goBack.

@huult Thanks for the review. Should we confirm with the design team if this behavior is acceptable? Because I see that it only creates a slight scrolling effect and separating it for two platforms increases code complexity.

I also noticed similar delays after selection in other areas:

2025-12-15.22-35-05.mp4

ok, Let's wait for @heyjennahay to review.

Hi @heyjennahay When we select a date of the month, the selected item scrolls up a bit and then goes back. Is that okay?

and the currency behavior is:

Screen.Recording.2025-12-15.at.22.51.45.mov

After we made the change:

Screen.Recording.2025-12-15.at.22.52.41.mov

@heyjennahay Could you check my comment when you have time?

@heyjennahay Could you check my comment?

@huult @MonilBhavsar ~~On the web, the RHP will be automatically closed after reloading the app. It’s unclear whether this is a new bug or the expected behavior:~~

It seems that the bug I previously observed has reappeared.

Okay, what do we do about it then

I’ve just verified the bug, and it’s resolved. We can proceed with the check.

@dmkt9 mind elaborating please? I'm still able to see the redirect bug I mentioned in this branch. Would you want to merge main if you think its fixed there

Sure, I’ve just merged the main branch. Thanks.

huult · 2025-12-17T00:44:21Z

@dmkt9 Please resolve the conflict

dmkt9 · 2025-12-17T13:27:57Z

The conflict has been resolved.

huult · 2026-01-06T02:17:26Z

@heyjennahay Could you review my comment and the behavior in this PR? Thanks.

huult · 2026-01-06T08:20:53Z

@dmkt9 Please merge the latest main.

heyjennahay

Happy with the change to the product UI

dmkt9 · 2026-01-06T08:58:11Z

@huult It's ready for review again.

huult

LGTM

…e selection refresh

MonilBhavsar · 2026-01-12T07:18:52Z

Waiting for @dmkt9's thoughts in #77653 (comment)

…e selection refresh

MonilBhavsar · 2026-01-29T20:43:51Z

Looking...

MonilBhavsar · 2026-01-31T02:30:42Z

Works now, thanks!!

Screen.Recording.2026-01-30.at.6.30.01.PM.mov

OSBotify · 2026-01-31T02:41:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-03T02:13:53Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.3.11-19 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-02-05T20:16:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Fix - Redirected to Workflow page instead of Frequency page after dat…

37c20eb

…e selection refresh

dmkt9 requested review from a team as code owners December 15, 2025 10:37

melvin-bot Bot assigned dmkt9 Dec 15, 2025

melvin-bot Bot requested review from heyjennahay and huult and removed request for a team December 15, 2025 10:37

melvin-bot Bot removed the request for review from a team December 15, 2025 10:37

fix lint

d4859fa

huult reviewed Dec 15, 2025

View reviewed changes

Merge branch 'main' into fix/75881

0261d77

Merge branch 'main' into fix/75881

5e0f373

heyjennahay previously approved these changes Jan 6, 2026

View reviewed changes

huult approved these changes Jan 6, 2026

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar January 6, 2026 08:59

dmkt9 added 2 commits January 9, 2026 10:12

Merge branch 'main' into fix/75881

bcf559d

Fix - Redirected to Workflow page instead of Frequency page after dat…

a3b10d0

…e selection refresh

dmkt9 dismissed heyjennahay’s stale review via a3b10d0 January 9, 2026 03:40

dmkt9 added 3 commits January 20, 2026 16:16

Merge branch 'main' into fix/75881

7326e5b

Fix - Redirected to Workflow page instead of Frequency page after dat…

7e68046

…e selection refresh

Merge branch 'Expensify:main' into fix/75881

e61a1f5

Merge branch 'main' into fix/75881

ab9d20a

MonilBhavsar approved these changes Jan 31, 2026

View reviewed changes

MonilBhavsar merged commit f745547 into Expensify:main Jan 31, 2026
30 checks passed

OSBotify mentioned this pull request Feb 3, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

huult mentioned this pull request Feb 14, 2026

[$250] Workflow-Redirected to Workflow page instead of Frequency page after date selection refresh #75881

Closed

8 tasks

	Navigation.setNavigationActionToMicrotaskQueue(() => {
	navigateBackAfterPolicyUpdate(() => {

Uh oh!

Conversation

dmkt9 commented Dec 15, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 15, 2025

Uh oh!

codecov Bot commented Dec 15, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult commented Dec 17, 2025

Uh oh!

dmkt9 commented Dec 17, 2025

Uh oh!

huult commented Jan 6, 2026

Uh oh!

huult commented Jan 6, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

dmkt9 commented Jan 6, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented Jan 12, 2026

Uh oh!

MonilBhavsar commented Jan 29, 2026

Uh oh!

MonilBhavsar commented Jan 31, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 31, 2026

Uh oh!

OSBotify commented Feb 3, 2026

Uh oh!

OSBotify commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Dec 15, 2025 •

edited by github-actions Bot

Loading

huult commented Dec 15, 2025 •

edited

Loading