[$250] Workflow-Redirected to Workflow page instead of Frequency page after date selection refresh

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.62-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10S Android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Create a workspace
3. Tap workflow - submission frequency - Frequency -
4. Select Monthly
5. Tap date of month
6. Enter a search which triggers no results found
7. Refresh the page
8. select any date

Expected Result:

User directed to Frequency page

Actual Result:

User directed to workflow page instead of Frequency page when selecting date after refreshing the page in submission frequency section

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7011925_1763974528692.Screenrecorder-2025-11-24-14-16-51-229.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021995897769720471817
• Upwork Job ID: 1995897769720471817
• Last Price Increase: 2025-12-02
• Automatic offers:
• huult | Reviewer | 109793214

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workflow-Redirected to Workflow page instead of Frequency page after date selection refresh

What is the root cause of that problem?

We are trying to perform data setup in Onyx and navigation at the same time, which leads to unexpected results, such as the data page in Onyx being undefined.

As a result, we currently have a policy value of undefined, which causes this useEffect to be executed:

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 195 to 205 in 75971bc

	useEffect(() => {
	if (!isFocused || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled)) {
	return;
	}
	// When a workspace feature linked to the current page is disabled we will navigate to the More Features page.
	Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));
	// We don't need to run the effect on policyID change as we only use it to get the route to navigate to.
	// eslint-disable-next-line react-compiler/react-compiler
	// eslint-disable-next-line react-hooks/exhaustive-deps
	}, [pendingField, isOffline, isFeatureEnabled]);

What changes do you think we should make in order to solve the problem?

We need to wrap navigation in setNavigationActionToMicrotaskQueue:

Navigation.setNavigationActionToMicrotaskQueue(() => {
Navigation.goBack(ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_FREQUENCY.getRoute(policy?.id ?? ‘’));
        });

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User directed to workflow page instead of Frequency page when selecting date after refreshing the page in submission frequency section

What is the root cause of that problem?

After refreshing, the auto-reporting frequency page is unmounted. After selecting the date, this page is mounted, and at this time, policy data is pending merging with the date data, then the policy is undefined

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 153 in 75971bc

const [policy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {

Which causes the navigation logic here to be triggered, and the auto-reporting frequency page is closed

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 195 to 203 in 75971bc

	useEffect(() => {
	if (!isFocused || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled)) {
	return;
	}
	// When a workspace feature linked to the current page is disabled we will navigate to the More Features page.
	Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));
	// We don't need to run the effect on policyID change as we only use it to get the route to navigate to.
	// eslint-disable-next-line react-compiler/react-compiler

What changes do you think we should make in order to solve the problem?

When the policy data is loading, we shouldn't trigger the navigation logic in the useEffect here

const [policy, policyResults] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {
        canBeMissing: true,
    });
if (!isFocused || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled) || isLoadingOnyxValue(policyResults)) {
            return;
        }

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 195 to 203 in 75971bc

	useEffect(() => {
	if (!isFocused || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled)) {
	return;
	}
	// When a workspace feature linked to the current page is disabled we will navigate to the More Features page.
	Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));
	// We don't need to run the effect on policyID change as we only use it to get the route to navigate to.
	// eslint-disable-next-line react-compiler/react-compiler

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User directed to workflow page instead of Frequency page when selecting date after refreshing the page in submission frequency section

What is the root cause of that problem?

1. After selecting the date, the policy onyx data will be merged and the app will go back here.
   

   App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

   Lines 70 to 73 in 04315c9

   	const onSelectDayOfMonth = (item: WorkspaceAutoReportingMonthlyOffsetPageItem) => {
   	Policy.setWorkspaceAutoReportingMonthlyOffset(policy?.id ?? '-1', item.isNumber ? parseInt(item.keyForList, 10) : (item.keyForList as AutoReportingOffsetKeys));
   	Navigation.goBack(ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_FREQUENCY.getRoute(policy?.id ?? ''));
   	};

2. Because when refreshing, the WorkspaceAutoReportingFrequencyPage will be mounted again when going back, and at the same time the policy is merged, so the policy will temporarily have the value undefined, which causes the goBack function to be called afterwards.
   

   App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

   Lines 196 to 201 in 04315c9

   	if (!isFocused || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled)) {
   	return;
   	}
   	// When a workspace feature linked to the current page is disabled we will navigate to the More Features page.
   	Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));

What changes do you think we should make in order to solve the problem?

We can use isLoadingOnyxValue to track the policy, but before that we also have a useEffect that checks if the policy is an empty object, and if so, it will fetch the policy. This means using isLoadingOnyxValue alone will not be sufficient if in some cases the policy is an empty object and will wait for fetch here:

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 165 to 173 in 04315c9

	useEffect(() => {
	if (!isPolicyIDInRoute || !isEmptyObject(policy)) {
	// If the workspace is not required or is already loaded, we don't need to call the API
	return;
	}
	openWorkspace(policyID, []);
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [isPolicyIDInRoute, policyID]);

Therefore, we need to add the condition isEmptyObject(policy):

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 196 to 198 in 04315c9

	if (!isFocused || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled)) {
	return;
	}

if (!isFocused || isEmptyObject(policy) || isFeatureEnabled || (pendingField && !isOffline && !isFeatureEnabled)) {
    return;
}

What alternative solutions did you explore? (Optional)

N/A

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user is configuring workspace submission frequency settings and selects a monthly date after refreshing the page, they are incorrectly redirected to the Workflow page instead of the Frequency page.

---

What is the root cause of that problem?

The issue is a race condition between the Onyx data update and the navigation action in WorkspaceAutoReportingMonthlyOffsetPage.tsx (line 72).

When a user selects a date, the code does this:

1. Updates Onyx data via setWorkspaceAutoReportingMonthlyOffset() (asynchronous)
2. Immediately calls Navigation.goBack() (synchronous)

After a page refresh, the navigation stack is cleared. When navigation executes before the Onyx update completes:

• The navigation stack is incomplete/inconsistent
• Navigation.goBack() can't find the Frequency page in the stack
• It falls back to a REPLACE action that navigates to the wrong page (Workflow instead of Frequency)

This timing issue doesn't occur in the normal flow because the navigation stack is intact, but after a refresh, the race condition becomes apparent.

---

What changes do you think we should make in order to solve the problem?

Wrap the Navigation.goBack() call with Navigation.setNavigationActionToMicrotaskQueue() to ensure the Onyx update completes before navigation executes.

File: App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

Current code (line 70-73):

const onSelectDayOfMonth = (item: WorkspaceAutoReportingMonthlyOffsetPageItem) => {
    Policy.setWorkspaceAutoReportingMonthlyOffset(policy?.id ?? '-1', item.isNumber ? parseInt(item.keyForList, 10) : (item.keyForList as AutoReportingOffsetKeys));
    Navigation.goBack(ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_FREQUENCY.getRoute(policy?.id ?? ''));
};

Proposed change:

const onSelectDayOfMonth = (item: WorkspaceAutoReportingMonthlyOffsetPageItem) => {
    Policy.setWorkspaceAutoReportingMonthlyOffset(policy?.id ?? '-1', item.isNumber ? parseInt(item.keyForList, 10) : (item.keyForList as AutoReportingOffsetKeys));
    Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.goBack(ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_FREQUENCY.getRoute(policy?.id ?? '')));
};

Why this works:

• setNavigationActionToMicrotaskQueue() delays navigation until the next JavaScript microtask
• This ensures the Onyx state update completes first
• When navigation executes, the app state is fully updated and consistent
• The navigation stack is properly reconstructed, allowing goBack() to find the correct route

This is a standard pattern used throughout the codebase for similar scenarios:

• WorkspaceOverviewCurrencyPage.tsx (line 60)
• EditCategoryPage.tsx (line 58-65)
• CategoryDefaultTaxRatePage.tsx (line 63)
• RulesMaxExpenseAgePage.tsx (line 67)
• And many other workspace settings pages

---

What alternative solutions did you explore?

N/A

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021995897769720471817