Attribute automated actions to Concierge in NewDot by justinpersaud · Pull Request #76302 · Expensify/App

justinpersaud · 2025-11-28T19:33:34Z

Explanation of Change

Attributing changes to Concierge, similar to what we do in OldDot. Might've been an oversight when this was implemented in NewDot.

Fixed Issues

Relates to https://github.com/Expensify/Expensify/issues/566447

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

For the steps below, you can use any historical report if you have one. You don't need to create a new one, but you can if can't find one.

Find a report that was auto approved via workspace rules. It should show that Concierge is the actor of the approved via workspace rules message.
Find a report that was submitted automatically via delay submission. This happens automatically through harvesting, so if you have end of week auto submission on it will happen. It should show that Concierge submitted via delay submissions in the report history.
Find a report that was paid via workspace rules. It should show Concierge as the actor for the paid via workspace rules action.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2025-11-28T19:42:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`72.95% <100.00%> (+0.09%)`	⬆️
src/pages/home/report/ReportActionItemSingle.tsx	`70.37% <100.00%> (+0.75%)`	⬆️
... and 4 files with indirect coverage changes

melvin-bot · 2025-12-02T20:58:29Z

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chuckdries · 2025-12-03T00:01:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

chuckdries

Looks good to me!

justinpersaud · 2025-12-04T15:10:27Z

@JmillsExpensify you able to sign off on this one?

JmillsExpensify

Attributing changes to Concierge, similar to what we do in OldDot. Might've been an oversight when this was implemented in NewDot.

This wasn't an oversight, it was a specific product design/initiative. The strategy has changed a different direction now, so fine with the changes based on new product scope.

justinpersaud · 2025-12-05T14:32:09Z

ok finally have all the tests passing, one more @chuckdries

chuckdries

Third time's the charm!

OSBotify · 2025-12-05T18:43:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-09T15:29:42Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.74-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

jponikarchuk · 2025-12-09T17:54:03Z

This PR failing because of a regression issue: #77163
This issue is reproducible in: Web and Android app

1.mp4

lanitochka17 · 2025-12-09T21:58:48Z

This PR is failing because of issue ##77185

The issue is reproducible in: Web IOS

Uploading 524541728-b454baf3-f93b-4126-9658-6448003c9e7a.mp4…

lanitochka17 · 2025-12-09T22:29:59Z

This PR is failing because of issue #hhttps://github.com//issues/77188

The issue is reproducible in: Web IOS Android

OSBotify · 2025-12-10T21:38:51Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T21:55:06Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T22:59:30Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dominictb · 2026-01-12T15:00:45Z

+            // - Automatic approvals/forwards via workspace rules
+            // - Automatic payments via workspace rules
+            if (wasSubmittedViaHarvesting || (wasAutomatic && actionName !== CONST.REPORT.ACTIONS.TYPE.IOU) || (wasAutomatic && isPayment)) {
+                return CONST.ACCOUNT_ID.CONCIERGE;


We missed the case when messages are grouped. We need to use this function to determine message grouping too. See #77163

tgolen · 2026-02-04T16:11:30Z

 let unavailableTranslation = '';

-Onyx.connect({
+Onyx.connectWithoutView({


@justinpersaud @chuckdries These changes are wrong for the onyx connections. We've been working for months to try and fix this, and the changes here basically ignore all the work that has been done.

The name of the method should be the biggest hint that this is wrong. All of these onyx subscriptions ARE connected to methods used by views. There are open issues to refactor these properly, so the ideal approach would be to refactor them (rather than just changing the method name), but at the least, it would have even been better to leave them alone and ignore the ESLint warnings. That way, they will still stand out to the person that will refactor them later.

An ideal refactoring means:

Finding all the methods referring to the Onyx value

Update them to have the Onyx value passed as a parameter to the function

Remove the Onyx.connect() reference completely

I would like to ask that you revert the changes here to use connectWithoutView(), please.

Attribute harvesting scheduled submit to Concierge

362ce35

justinpersaud self-assigned this Nov 28, 2025

justinpersaud added 11 commits November 28, 2025 16:55

Return concierge for automatic approvals

9cad3db

attribute automatic payments from rules to concierge

c5f831c

simplify

e358b25

cleanup redundant code

3b34027

Simplify further

ab732f5

update test

691b779

fix typescript checks

7e5cd32

Merge branch 'main' of github.com:Expensify/App into jpersaud_concierge

13be18f

Don't show vacation delegate for automatic action

bfc2182

another typescript check fix

4f1567f

Merge branch 'main' of github.com:Expensify/App into jpersaud_concierge

a099b11

justinpersaud marked this pull request as ready for review December 2, 2025 20:57

justinpersaud requested review from a team as code owners December 2, 2025 20:57

melvin-bot Bot requested review from JmillsExpensify and chuckdries and removed request for a team December 2, 2025 20:57

justinpersaud changed the title ~~Attribute harvesting scheduled submit to Concierge~~ Attribute automated actions to Concierge in NewDot Dec 2, 2025

chuckdries previously approved these changes Dec 3, 2025

View reviewed changes

justinpersaud added 2 commits December 4, 2025 10:11

Merge branch 'main' of github.com:Expensify/App into jpersaud_concierge

1270d4d

handle deprecation for Onyx.connect

7838729

justinpersaud dismissed chuckdries’s stale review via 7838729 December 4, 2025 18:37

fix more onyx.connects

651e9c6

eslint

e9cc5d7

JmillsExpensify reviewed Dec 4, 2025

View reviewed changes

chuckdries previously approved these changes Dec 5, 2025

View reviewed changes

justinpersaud added 3 commits December 5, 2025 08:44

fix test

27736e7

more eslint

004818b

Merge branch 'main' of github.com:Expensify/App into jpersaud_concierge

5c3297c

justinpersaud dismissed chuckdries’s stale review via 5c3297c December 5, 2025 14:04

justinpersaud requested a review from chuckdries December 5, 2025 14:32

chuckdries approved these changes Dec 5, 2025

View reviewed changes

chuckdries merged commit 436ec49 into main Dec 5, 2025
35 checks passed

chuckdries deleted the jpersaud_concierge branch December 5, 2025 18:17

OSBotify mentioned this pull request Dec 9, 2025

Deploy Checklist: New Expensify 2025-12-09 #77123

Closed

jponikarchuk mentioned this pull request Dec 9, 2025

[Due for payment 2026-01-12] [$250] Expense - "paid via workspace rules" message does not show Concierge as actor #77163

Closed

8 tasks

lanitochka17 mentioned this pull request Dec 9, 2025

[$250] Rules - Report is auto-approved even if the total exceeds the limit set in Rules #77185

Closed

16 tasks

lanitochka17 mentioned this pull request Dec 9, 2025

[$250] Auto-pay -"Changed the approver to [User]" system message appears before auto-pay #77188

Closed

16 tasks

This was referenced Dec 15, 2025

[CLEAN] Synthetic Benchmark PR #76302 - Attribute automated actions to Concierge in NewDot qodo-benchmark/App#45

Open

[CORRUPTED] Synthetic Benchmark PR #76302 - Attribute automated actions to Concierge in NewDot qodo-benchmark/App#46

Open

This was referenced Dec 31, 2025

[CLEAN] Synthetic Benchmark PR #76302 - Attribute automated actions to Concierge in NewDot qodo-benchmark/App#95

Open

[CORRUPTED] Synthetic Benchmark PR #76302 - Attribute automated actions to Concierge in NewDot qodo-benchmark/App#96

Open

dominictb reviewed Jan 12, 2026

View reviewed changes

tgolen reviewed Feb 4, 2026

View reviewed changes

Conversation

justinpersaud commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Nov 28, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Dec 2, 2025

Uh oh!

chuckdries commented Dec 3, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

justinpersaud commented Dec 4, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

justinpersaud commented Dec 5, 2025

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 5, 2025

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

jponikarchuk commented Dec 9, 2025

Uh oh!

lanitochka17 commented Dec 9, 2025

Uh oh!

lanitochka17 commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

dominictb Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

tgolen Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

justinpersaud commented Nov 28, 2025 •

edited

Loading

codecov Bot commented Nov 28, 2025 •

edited by github-actions Bot

Loading