Show confirmation modal for distance rate error and block expense split by huult · Pull Request #75984 · Expensify/App

huult · 2025-11-25T08:38:56Z

Details

Fixed Issues

$ #74315
PROPOSAL: #74315 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Expensify app.
Create a manual distance expense in your self DM.
Open the expense.
Tap Report → Upgrade → Confirm → Got it → Create report.
Tap More → Split expense → Save.
Verify that a confirmation modal is shown informing the user “Fix the distance rate error and try again.”, and that the expense cannot be split.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-22.at.13.50.26.mp4

Android: mWeb Chrome

Screen.Recording.2026-01-22.at.13.52.27.mp4

iOS: Native

Screen.Recording.2026-01-22.at.13.59.22.mp4

iOS: mWeb Safari

Screen.Recording.2026-01-22.at.14.01.16.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-01-22.at.13.46.17.mp4

melvin-bot · 2025-11-25T08:39:02Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2025-11-25T08:39:05Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2025-11-25T08:40:16Z

@Ollyws What do you think about this hint text when creating a report?

huult · 2025-11-25T08:44:15Z

On the backend side, this expense should be handled automatically,

@srikarparsi Could you help update this from the backend side?

Screen.Recording.2025-11-25.at.15.41.25.mov

1 When we call ChangeTransactionsReport, the transaction rate will be automatically updated to the valid workspace rate.
2 Update transactionViolations_ if after updating item 1, customUnitOutOfPolicy still exists.

cc @Ollyws

codecov · 2025-11-25T08:47:40Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

huult · 2025-12-02T00:20:48Z

@srikarparsi #75984 (comment) Could you check it when you have time?

srikarparsi · 2025-12-03T09:02:17Z

Hey @huult, didn't get a chance to do this today, will see if I get time for it tomorrow

huult · 2025-12-08T15:36:51Z

@srikarparsi friendly bump

srikarparsi · 2025-12-09T16:59:11Z

Hey @huult, just to clarify, is this what is needed from the backend?

1 When we call ChangeTransactionsReport, the transaction rate will be automatically updated to the valid workspace rate.
2 Update transactionViolations_ if after updating item 1, customUnitOutOfPolicy still exists.

huult · 2025-12-10T02:17:36Z

@srikarparsi Yes, that’s correct.

huult · 2025-12-16T03:17:50Z

@srikarparsi Don’t forget this. Many thanks 😄

srikarparsi · 2025-12-17T17:56:41Z

Hey @huult, this is taking time because it's a little complicated and I'm working on some higher priority bank account work. I'll see if I can get to this by the end of the week otherwise I'll see if anyone else can take over.

huult · 2025-12-24T05:05:57Z

@srikarparsi Do you have any updates or an estimate for this?

srikarparsi · 2025-12-29T05:40:28Z

@srikarparsi Do you have any updates or an estimate for this?

Hey @huult, I've been OOO last week and will be this week as well for the holidays. I'll try to give you an update towards the end of this week.

srikarparsi · 2026-01-06T06:34:31Z

Hey @huult, re-visiting this after OOO, I think the root problem here is that we are not handling the Rate out of policy violation correctly (as you've mentioned).

When we move a split request from a self dm to a workspace, we might get this violation:

And if this violation exists, then the frontend doesn't call Transaction_Split and silently fails. I think that's the core problem that needs to be solved. Let me know what you think.

huult · 2026-01-06T07:50:12Z

@srikarparsi I know we could call the default rate on the frontend as a solution. However, I’d like to understand what the backend solution would look like. If we update the rate automatically in changeTransactionsReport on the backend, then the frontend wouldn’t need to handle this more complex logic. If the backend solution is significantly more complex, then we can decide to handle it on the frontend instead. Please share your thoughts on whether we should solve this on the frontend or backend in this case.

srikarparsi · 2026-01-06T08:06:53Z

Let's say that through another flow, the distance request gets a rate out of policy violation. Then the same problem would remain right? So that's why I'm thinking that this is the root problem that needs to be fixed:

Splitting a distance request with a rate out of policy violation silently fails.

I think we can still do what you're suggesting (updating the rate automatically when the distance request moves policies) but I believe the above is the core problem that needs to be fixed. What do you think?

huult · 2026-01-06T14:25:15Z

@srikarparsi When we automatically update the rate in changeTransactionsReport successfully, the Transaction_Split flow will succeed because the rate is already valid. As I suggested, we will also add a note saying: “The expense rate will be automatically updated to the workspace rate” when we call changeTransactionsReport.

Flows:

Go to https://staging.new.expensify.com/home
Login new gmail account
Create manual track distance in self DM
Open the expense
Tap report - upgrade - confirm - got it - create report // We call changeTransactionsReport here and automatically update the rate to the workspace rate. “The expense rate will be automatically updated to the workspace rate” will display on UI.
Tap more - split expense // We call Transaction_Split here with a valid rate, so Transaction_Split will succeed without any issues.

srikarparsi · 2026-01-08T06:23:05Z

I understand that automatically converting the the distance rate when the policy is switched would also fix the issue (and maybe we should do that too), but the root problem in my eyes is that we are not properly handling splitting distance requests that have a rate out of policy violation and I think that is the bug we need to fix.

In the future, there might be other flows that lead to a distance rate being invalid (out of policy), and fixing this root problem would handle these cases as well.

huult · 2026-01-08T08:52:04Z

In the future, there might be other flows that lead to a distance rate being invalid (out of policy), and fixing this root problem would handle these cases as well.

@srikarparsi Yeah, I understand your point. In that case, defining a new flow would mean that when we are splitting distance requests that have an out-of-policy rate, we should show a screen prompting the user to update the rate to a valid one before allowing the split.

If we decide to go in this direction, I can research it further, propose a new flow, and loop in Product and Design to get their feedback.

srikarparsi · 2026-01-21T18:12:21Z

Cool! Sounds good, @huult, I think we should go this direction then?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea88d279e8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

huult · 2026-01-22T07:17:54Z

@Ollyws @srikarparsi This PR is ready for review

…lit-distance-manual-expense

Ollyws · 2026-01-27T13:24:53Z

+    const customUnitOutOfPolicyViolation = CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY;
+    const hasDistanceRateError =
+        currentTransactionViolations.some((violation) => violation.name === customUnitOutOfPolicyViolation) ||
+        originalTransactionViolations.some((violation) => violation.name === customUnitOutOfPolicyViolation);


Just for clarity, when exactly would this be populated?

@Ollyws could you double-check this?

Ollyws · 2026-01-27T13:47:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

…lit-distance-manual-expense

Ollyws

LGTM.

OSBotify · 2026-01-29T19:30:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-30T22:15:36Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.3.11-16 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-05T20:16:41Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

huult requested review from a team as code owners November 25, 2025 08:38

melvin-bot Bot assigned huult Nov 25, 2025

melvin-bot Bot requested review from Ollyws and heyjennahay and removed request for a team November 25, 2025 08:39

melvin-bot Bot removed the request for review from a team November 25, 2025 08:39

huult marked this pull request as draft November 25, 2025 08:39

srikarparsi self-requested a review December 4, 2025 07:43

srikarparsi mentioned this pull request Jan 6, 2026

[$250] Expense - Unable to split distance manual expense moved from self DM #74315

Closed

8 tasks

huult closed this Jan 22, 2026

huult force-pushed the 74315-fix-unable-split-distance-manual-expense branch from c0fa584 to 3779ccf Compare January 22, 2026 06:03

Show confirmation modal for distance rate error

ea88d27

huult reopened this Jan 22, 2026

huult marked this pull request as ready for review January 22, 2026 06:28

github-actions Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread src/pages/iou/SplitExpensePage.tsx Outdated

chatgpt-codex-connector Bot reviewed Jan 22, 2026

View reviewed changes

Comment thread src/languages/en.ts Outdated

huult added 2 commits January 22, 2026 13:41

update translation

21921f4

update translation

5fb1dd2

huult added 5 commits January 23, 2026 08:38

Merge remote-tracking branch 'upstream/main' into 74315-fix-unable-sp…

9df53a8

…lit-distance-manual-expense

Merge remote-tracking branch 'upstream/main' into 74315-fix-unable-sp…

55e92ba

…lit-distance-manual-expense

updatet translation

ca36d10

Merge remote-tracking branch 'upstream/main' into 74315-fix-unable-sp…

a8e91d5

…lit-distance-manual-expense

Merge remote-tracking branch 'upstream/main' into 74315-fix-unable-sp…

816728b

…lit-distance-manual-expense

Ollyws reviewed Jan 27, 2026

View reviewed changes

huult added 2 commits January 29, 2026 10:26

Merge remote-tracking branch 'upstream/main' into 74315-fix-unable-sp…

64c30a9

…lit-distance-manual-expense

Update condition for distance rate error

c0eabce

huult changed the title ~~Add hint text when creating a report~~ Show confirmation modal for distance rate error and block expense split Jan 29, 2026

Ollyws approved these changes Jan 29, 2026

View reviewed changes

srikarparsi approved these changes Jan 29, 2026

View reviewed changes

srikarparsi merged commit b4feaff into Expensify:main Jan 29, 2026
33 checks passed

OSBotify mentioned this pull request Jan 30, 2026

Deploy Checklist: New Expensify 2026-01-28 #80808

Closed

lanitochka17 mentioned this pull request Jan 31, 2026

[$250] Per diem -"Please fix the distance rate error" when spliting per diem expense with invalid rate #81076

Closed

7 tasks

OSBotify mentioned this pull request Feb 3, 2026

iOS - Track distance - Details on Confirm details page are hidden behind the empty space #81285

Closed

7 tasks

Uh oh!

Conversation

huult commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 25, 2025

Uh oh!

melvin-bot Bot commented Nov 25, 2025

Uh oh!

huult commented Nov 25, 2025

Uh oh!

huult commented Nov 25, 2025

Uh oh!

codecov Bot commented Nov 25, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Dec 2, 2025

Uh oh!

srikarparsi commented Dec 3, 2025

Uh oh!

huult commented Dec 8, 2025

Uh oh!

srikarparsi commented Dec 9, 2025

Uh oh!

huult commented Dec 10, 2025

Uh oh!

huult commented Dec 16, 2025

Uh oh!

srikarparsi commented Dec 17, 2025

Uh oh!

huult commented Dec 24, 2025

Uh oh!

srikarparsi commented Dec 29, 2025

Uh oh!

srikarparsi commented Jan 6, 2026

Uh oh!

huult commented Jan 6, 2026

Uh oh!

srikarparsi commented Jan 6, 2026

Uh oh!

huult commented Jan 6, 2026

Uh oh!

srikarparsi commented Jan 8, 2026

Uh oh!

huult commented Jan 8, 2026

Uh oh!

srikarparsi commented Jan 21, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

huult commented Jan 22, 2026

Uh oh!

Ollyws Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

huult Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Ollyws commented Jan 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 29, 2026

Uh oh!

huult commented Nov 25, 2025 •

edited

Loading

codecov Bot commented Nov 25, 2025 •

edited by github-actions Bot

Loading