Add report columns (reapply with fixes) by mohammadjafarinejad · Pull Request #75113 · Expensify/App

mohammadjafarinejad · 2025-11-14T04:04:32Z

Explanation of Change

This PR adds specific columns to type:expense-report search results.

Context

Original PR: Add report columns #73900 (merged)
Reverted in: [CP Staging] Revert "Add report columns" #75073 due to deploy blockers
This PR: Re-applies the feature with bug fixes addressing the issues that caused the revert

Fixed Issues

$ #73702
PROPOSAL: #73702 (comment)

Tests

Go to the reports (expense-report) page
Verify list items match the mocks in the [Due for payment 2025-12-03] [$250] Add report columns #73702.
Also verify that buttons and icons in the list item work correctly (like - view, submit, etc.).

Verify that no errors appear in the JS console

Offline tests

Requires an internet connection to load the reports page data.

QA Steps

Go to the reports (expense-report) page
Verify list items match the mocks in the [Due for payment 2025-12-03] [$250] Add report columns #73702.
Also verify that buttons and icons in the list item work correctly (like - view, submit, etc.).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

This restores the functionality from PR Expensify#73900 that was reverted in PR Expensify#75073. Bug fixes included to address deploy blockers.

melvin-bot · 2025-11-14T04:04:37Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-11-14T04:15:30Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.71% <ø> (ø)`
src/components/ReportActionAvatars/index.tsx	`100.00% <100.00%> (ø)`
...ents/ReportActionAvatars/useReportActionAvatars.ts	`88.46% <100.00%> (+0.08%)`	⬆️
src/libs/ReportUtils.ts	`74.22% <100.00%> (-0.06%)`	⬇️
src/styles/variables.ts	`100.00% <ø> (ø)`
...thSections/Search/TransactionGroupListExpanded.tsx	`57.47% <0.00%> (ø)`
.../SelectionListWithSections/SortableTableHeader.tsx	`10.00% <0.00%> (ø)`
src/libs/actions/Search.ts	`10.88% <0.00%> (ø)`
...nts/SelectionListWithSections/Search/TitleCell.tsx	`0.00% <0.00%> (ø)`
...ts/SelectionListWithSections/SearchTableHeader.tsx	`14.70% <16.66%> (+1.37%)`	⬆️
... and 8 more
... and 4 files with indirect coverage changes

trjExpensify · 2025-11-17T17:33:58Z

@mohammadjafarinejad when do you think this can be back open for review?

We should add @hoangzinh as a reviewer as well right, as they reviewed the first attempt?

mohammadjafarinejad · 2025-11-17T17:36:39Z

@trjExpensify I think it should be ready for review by tomorrow. I’ve fixed all the issues; only two remain.

mohammadjafarinejad · 2025-11-17T17:38:56Z

We should add @hoangzinh as a reviewer as well right, as they reviewed the first attempt?

Yes, we should add them. I can push the changes for the other fixes while I work on the remaining two issues.

… be selected

mohammadjafarinejad · 2025-11-17T17:46:40Z

Remaining issues:

Reports - Avatar changes to fallback avatar when changing sorting order #75068
Reports - Selected report is no longer selected after creating another expense #75071

…ense

trjExpensify · 2025-11-18T01:25:49Z

Dope, added @hoangzinh!

luacmartins · 2025-11-18T16:38:49Z

I don't think we should do 2. We shouldn't add any more Search specific logic to useOnyx since we have an ongoing project to deprecate the wrapper we have for it in App. So let's go with 1.

hoangzinh · 2025-11-20T13:37:48Z

I found a weird bug, but it might not be a blocker (as I can reproduce for "expense" as well)

Bug: App shows "Nothing to show" when sort by other fields

Sign up with a new fresh account
Submit an expense
Go to Reports -> Reports
Click sort by either "Date" or "Report name" serveral times

Screen.Recording.2025-11-20.at.20.33.35.mov

hoangzinh · 2025-11-20T13:54:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-21.at.15.21.20.android.mov

Android: mWeb Chrome

Screen.Recording.2025-11-21.at.13.56.29.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-11-21.at.15.22.54.mov

iOS: mWeb Safari

Screen.Recording.2025-11-21.at.15.16.02.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-20.at.20.53.00.web.mov

MacOS: Desktop

Screen.Recording.2025-11-21.at.13.57.33.desktop.mov

trjExpensify · 2025-11-20T14:00:31Z

but it might not be a blocker (as I can reproduce for "expense" as well)

Yeah, if it's reproducible on Reports > Expenses with existing columns, I agree it's probably not a blocker. It does look bad though, any idea where that regression has come from? I can't seem to repro on staging. 🤔

hoangzinh · 2025-11-20T14:08:33Z

Bug: Submit/Approve buttons are not animated after click

Screen.Recording.2025-11-20.at.21.06.17.mov

hoangzinh · 2025-11-20T14:13:26Z

but it might not be a blocker (as I can reproduce for "expense" as well)

Yeah, if it's reproducible on Reports > Expenses with existing columns, I agree it's probably not a blocker. It does look bad though, any idea where that regression has come from? I can't seem to repro on staging. 🤔

I can reproduce it in Staging @trjExpensify

Screen.Recording.2025-11-20.at.21.12.20.mov

mohammadjafarinejad · 2025-11-20T14:36:11Z

Bug: Submit/Approve buttons are not animated after click

@hoangzinh Fixed.

hoangzinh · 2025-11-20T14:49:35Z

Bug: Sort by "From" is broken somewhere @mohammadjafarinejad

Screen.Recording.2025-11-20.at.21.47.43.mov

mohammadjafarinejad · 2025-11-20T17:59:27Z

Bug: Sort by "From" is broken somewhere @mohammadjafarinejad

@hoangzinh This should be fixed now.

luacmartins · 2025-11-20T21:42:09Z

@mohammadjafarinejad we have conflicts again

hoangzinh · 2025-11-21T06:37:37Z

Thanks @mohammadjafarinejad. We have conflicts again. Please try to resolve it. I will try to complete review checlist in meanwhile

hoangzinh · 2025-11-21T06:48:42Z

@mohammadjafarinejad, when you have a moment, can you take a look at this issue #75113 (comment)? Just ensure it's not come from our PR.

mohammadjafarinejad · 2025-11-21T07:09:15Z

but it might not be a blocker (as I can reproduce for "expense" as well)

Yeah, if it's reproducible on Reports > Expenses with existing columns, I agree it's probably not a blocker. It does look bad though, any idea where that regression has come from? I can't seem to repro on staging. 🤔

I can reproduce it in Staging @trjExpensify

I cannot reproduce it in staging or in our PR.

SORT_BUG.mp4

hoangzinh

LGTM

luacmartins

LGTM

OSBotify · 2025-11-21T16:23:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-24T20:23:39Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.63-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-26T01:22:05Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.63-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

huult · 2025-12-15T02:08:40Z

                const shouldShowBlankTo = !reportItem || isOpenExpenseReport(reportItem);
                const allActions = getActions(data, allViolations, key, currentSearch, currentAccountID, currentUserEmail, actions);
+
+                const fromDetails = data.personalDetailsList?.[reportItem.ownerAccountID ?? CONST.DEFAULT_NUMBER_ID] ?? emptyPersonalDetails;


Coming from #75943, there is no fallback data. In cases where data.personalDetailsList is not present in the snapshot, fromDetail ends up being empty.

eh2077 · 2025-12-16T03:30:16Z

+    const showUserInfo = (item.type === CONST.REPORT.TYPE.IOU && thereIsFromAndTo) || (item.type === CONST.REPORT.TYPE.EXPENSE && !!item?.from);
+
+    // Calculate the correct border color for avatars based on hover and focus states
+    const finalAvatarBorderColor = isHovered && !isFocused ? theme.border : avatarBorderColor;


This line caused

[Due for payment 2025-12-10] [$250] Reports - Workspace avatar border is not highlighted when the report is selected #76006

the border should be highlighted when selected

Reapply report columns feature with bug fixes

4b15af9

This restores the functionality from PR Expensify#73900 that was reverted in PR Expensify#75073. Bug fixes included to address deploy blockers.

melvin-bot Bot assigned mohammadjafarinejad Nov 14, 2025

mohammadjafarinejad mentioned this pull request Nov 14, 2025

[Due for payment 2025-12-03] [$250] Add report columns #73702

Closed

mohammadjafarinejad added 7 commits November 17, 2025 17:43

Merge branch 'Expensify:main' into fix/73702-v2

32812a9

fix: App crashes after creating report and going to Reports

27e43d7

fix: Date field is blank when expense is created offline

9a1e64c

fix eslint error

318e3db

fix: disable default right-hand side checkmark

a762c50

fix: Empty report checkbox shows hand cursor when empty report cannot…

7a2c838

… be selected

fix: remove isDisabled prop from ExpenseReportListItem

8dd94c2

mohammadjafarinejad added 6 commits November 17, 2025 23:59

fix: Selected report is no longer selected after creating another exp…

b891107

…ense

Merge branch 'main' into fix/73702-v2

8445ddf

chore: prettier

37037f3

fix test error

053b869

fix ts error

d4d3c9f

fix: replace Expensicons with lazy-loaded icons

6f72df1

trjExpensify requested a review from hoangzinh November 18, 2025 01:25

This comment was marked as resolved.

Sign in to view

luacmartins self-requested a review November 18, 2025 16:36

fix: Avatar changes to fallback avatar when changing sorting order

a5f1bce

mohammadjafarinejad marked this pull request as ready for review November 18, 2025 18:45

mohammadjafarinejad requested a review from a team as a code owner November 18, 2025 18:45

fix: add isActionLoading state to ExpenseReportListItem

489c3b1

fix: remove unnecessary condition in formattedFrom assignment

c2a4704

luacmartins requested a review from hoangzinh November 20, 2025 21:42

Merge branch 'main' into fix/73702-v2

6f89e0a

Merge branch 'main' into fix/73702-v2

3e78890

hoangzinh approved these changes Nov 21, 2025

View reviewed changes

luacmartins approved these changes Nov 21, 2025

View reviewed changes

luacmartins merged commit 9547506 into Expensify:main Nov 21, 2025
32 checks passed

nkdengineer mentioned this pull request Nov 24, 2025

[$250] Reports - Expense is accessible and report is selectable when deleted offline on Reports #75835

Closed

8 tasks

OSBotify mentioned this pull request Nov 24, 2025

Deploy Checklist: New Expensify 2025-11-24 #75927

Closed

98 tasks

vincdargento mentioned this pull request Nov 24, 2025

[Ready for payment on Dec 10th][$250] Reports - Sender name in From field for empty report disappears after deleting expense from other report #75943

Closed

8 tasks

mitarachim mentioned this pull request Nov 25, 2025

[Due for payment 2025-12-10] [$250] Reports - Workspace avatar border is not highlighted when the report is selected #76006

Closed

8 tasks

mitarachim mentioned this pull request Nov 26, 2025

[WAITING ON CHECKLIST - MANAN] [$250] Reports- Dropdown button shows different amount when selecting report on wide and small screen #76144

Closed

8 tasks

huult reviewed Dec 15, 2025

View reviewed changes

eh2077 reviewed Dec 16, 2025

View reviewed changes

Uh oh!

Conversation

mohammadjafarinejad commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Context

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 14, 2025

Uh oh!

codecov Bot commented Nov 14, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Nov 17, 2025

Uh oh!

mohammadjafarinejad commented Nov 17, 2025

Uh oh!

mohammadjafarinejad commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohammadjafarinejad commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Nov 18, 2025

Uh oh!

This comment was marked as resolved.

luacmartins commented Nov 18, 2025

Uh oh!

hoangzinh commented Nov 20, 2025

Uh oh!

hoangzinh commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

trjExpensify commented Nov 20, 2025

Uh oh!

hoangzinh commented Nov 20, 2025

Uh oh!

hoangzinh commented Nov 20, 2025

Uh oh!

mohammadjafarinejad commented Nov 20, 2025

Uh oh!

hoangzinh commented Nov 20, 2025

Uh oh!

mohammadjafarinejad commented Nov 20, 2025

Uh oh!

luacmartins commented Nov 20, 2025

Uh oh!

hoangzinh commented Nov 21, 2025

Uh oh!

hoangzinh commented Nov 21, 2025

Uh oh!

mohammadjafarinejad commented Nov 21, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

OSBotify commented Nov 24, 2025

Uh oh!

OSBotify commented Nov 26, 2025

Uh oh!

huult Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

mohammadjafarinejad commented Nov 14, 2025 •

edited

Loading

codecov Bot commented Nov 14, 2025 •

edited by github-actions Bot

Loading

mohammadjafarinejad commented Nov 17, 2025 •

edited

Loading

mohammadjafarinejad commented Nov 17, 2025 •

edited

Loading

hoangzinh commented Nov 20, 2025 •

edited

Loading