feat: Better detect third party card connection issues by daledah · Pull Request #73035 · Expensify/App

daledah · 2025-10-20T20:30:26Z

Explanation of Change

Fixed Issues

$ #72363
PROPOSAL: #72363 (comment)

Tests

Go to Workspace -> Company Cards
Click Add cards -> Select United States -> Direct Feed -> Other
When entering Plaid flow, press X button -> Yes, exit
Verify that: The "Something not working?" Modal opens
Finish the Plaid flow to add Company card
Click assign card
Click back button
Verify that: The prompt text shows "Choose a card for . Can't find the card you're looking for? Let us know." which matches the design.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Workspace -> Company Cards
Click Add cards -> Select United States -> Direct Feed -> Other
When entering Plaid flow, press X button -> Yes, exit
Verify that: The "Something not working?" Modal opens
Finish the Plaid flow to add Company card
Click assign card
Click back button
Verify that: The prompt text shows "Choose a card for . Can't find the card you're looking for? Let us know." which matches the design.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-21.at.15.22.00.mov

Android: mWeb Chrome

Screen.Recording.2025-10-21.at.15.23.34.mov

iOS: Native

Screen.Recording.2025-10-21.at.15.25.06.mp4

iOS: mWeb Safari

Screen.Recording.2025-10-21.at.15.26.21.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-21.at.15.27.07.mp4

MacOS: Desktop

Screen.Recording.2025-10-21.at.15.28.21.mp4

codecov · 2025-10-20T20:42:26Z

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...s/workspace/companyCards/addNew/AddNewCardPage.tsx	0.00%	10 Missing ⚠️

Files with missing lines	Coverage Δ
...kspace/companyCards/addNew/PlaidConnectionStep.tsx	`3.33% <ø> (-17.18%)`	⬇️
...pace/companyCards/assignCard/CardSelectionStep.tsx	`1.96% <ø> (+0.14%)`	⬆️
...s/workspace/companyCards/addNew/AddNewCardPage.tsx	`0.00% <0.00%> (-2.71%)`	⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-21T08:33:53Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2025-10-21T08:41:16Z

Hmm not sure why the bot didn't request reviews from @brunovjk.

github-actions · 2025-10-21T12:24:11Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

brunovjk · 2025-10-21T13:02:26Z

Great! Reviewing ASAP

joekaufmanexpensify · 2025-10-21T18:23:59Z

BUG: Report issue button closes modal but doesn't bring you to concierge DM

2025-10-21_14-23-21.mp4

joekaufmanexpensify · 2025-10-21T18:26:10Z

Everything else works well 👍

carlosmiceli · 2025-10-21T19:10:12Z

Asking internally about code coverage, will report back, but feel free to start reviewing @brunovjk once the bug above is fixed.

mountiny

Any way you can think of adding UI test for this other than the unit test I have proposed?

daledah · 2025-10-22T08:20:38Z

BUG: Report issue button closes modal but doesn't bring you to concierge DM

Fixed!

github-actions · 2025-10-22T12:21:00Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

mountiny · 2025-10-22T12:30:20Z

@brunovjk Let me know when done

github-actions · 2025-10-22T12:44:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #73035.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/73035/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/73035/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/73035/NewExpensify.dmg	https://73035.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2025-10-22T16:33:28Z

Fixed!

Retested and works well!

joekaufmanexpensify

Good from a product perspective 👍

carlosmiceli · 2025-10-22T16:44:19Z

@daledah as an effort to start improving our code coverage, could you also add tests so that this report is not an ❌ ? Expensify as a whole will be trying to encourage proper code coverage more and more, as mentioned here: https://expensify.slack.com/archives/C01GTK53T8Q/p1758826690204459 cc @brunovjk

brunovjk · 2025-10-22T16:57:56Z

I'm a bit busy today, reviewing ASAP

brunovjk · 2025-10-23T12:38:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

73035_android_native.mov

Android: mWeb Chrome

73035_android_web.mov

iOS: HybridApp

73035_ios_native.mov

iOS: mWeb Safari

73035_ios_web.mov

MacOS: Chrome / Safari

73035_web_chrome.mov

MacOS: Desktop

73035_web_desktop.mov

brunovjk · 2025-10-23T14:26:29Z

Do we need confirmation from the @Expensify/design?

@daledah, did we confirm the translations?

Thanks.

daledah · 2025-10-23T14:29:31Z

@brunovjk The translation is not confirmed yet. Link: https://expensify.slack.com/archives/C01GTK53T8Q/p1761035883296039

dubielzyk-expensify · 2025-10-23T23:40:19Z

Do we need confirmation from the @Expensify/design?

Confirmation on what. Nothing stood out in the video and if @joekaufmanexpensify has given thumbs up, then that's all good for me 👍

daledah · 2025-10-27T03:00:27Z

@carlosmiceli All the file changes are either language files or component files. And IMO these components have a very specific use, so I believe we don't really need to write test cases for them. What do you think?

carlosmiceli · 2025-10-27T03:16:30Z

Ok, that's fair, let's wait for @brunovjk to review.

brunovjk

Great, thanks everyone. LGTM.

OSBotify · 2025-10-27T15:36:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-27T20:37:05Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.39-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-28T21:33:07Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.39-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jayeshmangwani · 2025-12-01T14:01:06Z

-                                })}
-                            </Text>
+                            <View style={[styles.ph5, styles.mv3, styles.textSupporting]}>
+                                <RenderHTML


Coming from this issue #74296, here using RenderHTML broke the word-break behavior. We need to explicitly pass the style when using RenderHTML. We fixed it here: #74296 (comment)

feat: Better detect third party card connection issues

0b5a95a

melvin-bot Bot assigned daledah Oct 20, 2025

daledah added 3 commits October 21, 2025 03:54

fix: lint

9190d4b

Merge branch 'main' into fix/72363

3491f8d

fix: lint

d6a9199

daledah marked this pull request as ready for review October 21, 2025 08:33

daledah requested a review from a team as a code owner October 21, 2025 08:33

melvin-bot Bot requested review from carlosmiceli and removed request for a team October 21, 2025 08:33

joekaufmanexpensify requested review from brunovjk and mountiny and removed request for carlosmiceli October 21, 2025 12:22

This comment has been minimized.

Sign in to view

joekaufmanexpensify self-requested a review October 21, 2025 18:26

mountiny reviewed Oct 21, 2025

View reviewed changes

Comment thread src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx Outdated

daledah added 3 commits October 22, 2025 15:05

Merge branch 'main' into fix/72363

e444944

fix: reuse existing logic for Concierge navigation

661a6fa

fix: add functionality to modal

9d97ba4

joekaufmanexpensify approved these changes Oct 22, 2025

View reviewed changes

brunovjk approved these changes Oct 27, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny October 27, 2025 13:44

carlosmiceli approved these changes Oct 27, 2025

View reviewed changes

carlosmiceli merged commit fc12620 into Expensify:main Oct 27, 2025
27 of 29 checks passed

OSBotify mentioned this pull request Oct 27, 2025

Deploy Checklist: New Expensify 2025-10-27 #73587

Closed

68 tasks

melvin-bot Bot mentioned this pull request Oct 28, 2025

[Due for payment 2025-11-04] [$250] Better detect third party card connection issues #72363

Closed

M00rish mentioned this pull request Nov 6, 2025

[$250] [BACK BUTTON] Cards - In let's double check everything page, tapping device back button directs to cards page #60018

Closed

8 tasks

jayeshmangwani reviewed Dec 1, 2025

View reviewed changes

jayeshmangwani mentioned this pull request Dec 1, 2025

[Due for payment 2025-11-26] [$250] Cards - Choose a card sentence is partially hidden #74296

Closed

8 tasks

This was referenced Dec 4, 2025

[CLEAN] Synthetic Benchmark PR #73035 - feat: Better detect third party card connection issues qodo-benchmark/App#29

Open

[CORRUPTED] Synthetic Benchmark PR #73035 - feat: Better detect third party card connection issues qodo-benchmark/App#30

Open

Conversation

daledah commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 21, 2025

Uh oh!

daledah commented Oct 21, 2025

Uh oh!

github-actions Bot commented Oct 21, 2025

Uh oh!

This comment has been minimized.

brunovjk commented Oct 21, 2025

Uh oh!

joekaufmanexpensify commented Oct 21, 2025

BUG: Report issue button closes modal but doesn't bring you to concierge DM

Uh oh!

joekaufmanexpensify commented Oct 21, 2025

Uh oh!

carlosmiceli commented Oct 21, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daledah commented Oct 22, 2025

Uh oh!

github-actions Bot commented Oct 22, 2025

Uh oh!

mountiny commented Oct 22, 2025

Uh oh!

github-actions Bot commented Oct 22, 2025

Uh oh!

joekaufmanexpensify commented Oct 22, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Oct 22, 2025

Uh oh!

brunovjk commented Oct 22, 2025

Uh oh!

brunovjk commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk commented Oct 23, 2025

Uh oh!

daledah commented Oct 23, 2025

Uh oh!

dubielzyk-expensify commented Oct 23, 2025

Uh oh!

daledah commented Oct 27, 2025

Uh oh!

carlosmiceli commented Oct 27, 2025

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 27, 2025

Uh oh!

OSBotify commented Oct 27, 2025

Uh oh!

OSBotify commented Oct 28, 2025

Uh oh!

jayeshmangwani Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

daledah commented Oct 20, 2025 •

edited

Loading

codecov Bot commented Oct 20, 2025 •

edited

Loading

brunovjk commented Oct 23, 2025 •

edited

Loading