Skip to content

fix: hide split option for the submitter if the report is forwarded #71335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikkiWines merged 3 commits into from
Sep 30, 2025
Merged

fix: hide split option for the submitter if the report is forwarded #71335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d81fde
fix: hide split option for the submitter if the report is forwarded
nkdengineer Sep 25, 2025
ba53f5c
fix prettier
nkdengineer Sep 25, 2025
f77ab48
Merge branch 'main' into fix/70806
nkdengineer Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libs/ReportSecondaryActionUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
hasReportBeenReopened as hasReportBeenReopenedUtils,
hasReportBeenRetracted as hasReportBeenRetractedUtils,
isArchivedReport,
isAwaitingFirstLevelApproval,
isClosedReport as isClosedReportUtils,
isCurrentUserSubmitter,
isExpenseReport as isExpenseReportUtils,
Expand Down Expand Up @@ -121,7 +122,8 @@ function isSplitAction(report: Report, reportTransactions: Transaction[], policy
return isSubmitter || isAdmin;
}

return isSubmitter || isAdmin || isManager;
// Hide split option for the submitter if the report is forwarded
return (isSubmitter && isAwaitingFirstLevelApproval(report)) || isAdmin || isManager;
}

function isSubmitAction(
Expand Down
Loading