feat: add track distance option to add expense menu by dominictb · Pull Request #71005 · Expensify/App

dominictb · 2025-09-22T17:16:19Z

Explanation of Change

Fixed Issues

$ #70827
PROPOSAL:

Tests

Go to a workspace chat
Create an empty report
Press Add expense > Track distance
Create a distance expense (of any kind)
Verify that the expense is added to the report created in step 2

Press the empty report > More > Add expense > Track distance
Repeat steps 4 - 5

Create another empty report
Press the empty report
Press Add expense on empty report illustration > Track distance
Repeat steps 4 - 5

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-09-30.at.17.28.53-compressed.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-09-30.at.17.25.23-compressed.mov

MacOS: Desktop

…eat/70827

melvin-bot · 2025-09-30T10:36:15Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-09-30T10:43:50Z

Codecov Report

❌ Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/MoneyReportHeader.tsx	0.00%	8 Missing ⚠️
...ReportPreview/MoneyRequestReportPreviewContent.tsx	12.50%	7 Missing ⚠️
...tReportView/SearchMoneyRequestReportEmptyState.tsx	0.00%	5 Missing ⚠️

📢 Thoughts on this report? Let us know!

allroundexperts · 2025-10-01T21:01:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-10-02.at.2.17.11.AM.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-10-02.at.2.14.08.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-02.at.2.10.30.AM.mov

MacOS: Desktop

Screen.Recording.2025-10-02.at.2.13.07.AM.mov

allroundexperts · 2025-10-01T21:10:04Z

BUG

Manual distance does not work and redirects to the manual amount flow.

Screen.Recording.2025-10-02.at.2.07.45.AM.mov

…eat/70827

dominictb · 2025-10-02T16:03:20Z

I just fixed the issue.

neil-marcellini

Thanks for this, it looks good. I have some non-blocking comments that can be addressed in a follow-up.

neil-marcellini · 2025-10-06T17:35:24Z

+                icon: Expensicons.Location,
+                onSelected: () => {
+                    if (!moneyRequestReport?.reportID) {
+                        return;


NAB: We should log a warning here, because this should never happen and it would leave the user in a weird position where they take an action and nothing happens.

neil-marcellini · 2025-10-06T17:37:56Z

                    startMoneyRequest(CONST.IOU.TYPE.SUBMIT, iouReport?.reportID, undefined, false, chatReportID);
                },
            },
+            {


NAB: We define the addExpenseDropdownOptions 3 separate times, so it's breaking our DRY rule. Once 3 repetitions are reached, we should refactor it into a function that can be easily reused.

NAB because we can do this in a follow up.

OSBotify · 2025-10-06T17:50:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-06T20:11:34Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.24-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-07T15:18:56Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.26-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-08T04:50:27Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.26-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: add track distance option to add expense menu

0a8efa6

melvin-bot Bot assigned dominictb Sep 22, 2025

dominictb changed the title ~~feat: add track distance option to add expense menu~~ [HELD E/App 64730] feat: add track distance option to add expense menu Sep 22, 2025

dominictb changed the title ~~[HELD E/App 64730] feat: add track distance option to add expense menu~~ [HELD App 64730] feat: add track distance option to add expense menu Sep 22, 2025

dominictb changed the title ~~[HELD App 64730] feat: add track distance option to add expense menu~~ [HOLD App 64730] feat: add track distance option to add expense menu Sep 22, 2025

dominictb mentioned this pull request Sep 22, 2025

[Due for payment 2025-10-15] [Manual mileage] [$250] Add a "Track Distance" option in the "Add Expense" menu #70827

Closed

dominictb added 3 commits September 30, 2025 17:17

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

134afbf

…eat/70827

remove manual distance beta

758b5f7

add track distance option to report empty state view

338ae7a

dominictb changed the title ~~[HOLD App 64730] feat: add track distance option to add expense menu~~ feat: add track distance option to add expense menu Sep 30, 2025

fix lint

5fbfa69

dominictb marked this pull request as ready for review September 30, 2025 10:36

dominictb requested a review from a team as a code owner September 30, 2025 10:36

melvin-bot Bot requested review from allroundexperts and removed request for a team September 30, 2025 10:36

dominictb added 2 commits October 2, 2025 21:08

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

8954d23

…eat/70827

fix wrong iou type

32892eb

allroundexperts approved these changes Oct 6, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini October 6, 2025 06:29

neil-marcellini approved these changes Oct 6, 2025

View reviewed changes

neil-marcellini merged commit 98e1b02 into Expensify:main Oct 6, 2025
23 checks passed

OSBotify mentioned this pull request Oct 6, 2025

Deploy Checklist: New Expensify 2025-10-06 #71926

Closed

73 tasks done

vincdargento mentioned this pull request Oct 6, 2025

[Due for payment 2025-10-27] [Due for payment 2025-10-15] [Due for payment 2025-10-15] Expense - App opens the expense report after creating distance from empty report #71929

Closed

5 of 8 tasks

neil-marcellini mentioned this pull request Oct 6, 2025

[CP staging] Stay on chat report when tracking distance from report preview #71937

Merged

54 tasks done

Navigation Menu

feat: add track distance option to add expense menu - #71005

feat: add track distance option to add expense menu#71005
neil-marcellini merged 7 commits into
Expensify:mainfrom
dominictb:feat/70827

dominictb commented Sep 22, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Sep 30, 2025

Uh oh!

codecov Bot commented Sep 30, 2025

Uh oh!

allroundexperts commented Oct 1, 2025 •

edited

Loading

Uh oh!

allroundexperts commented Oct 1, 2025

Uh oh!

dominictb commented Oct 2, 2025

Uh oh!

neil-marcellini left a comment

Uh oh!

neil-marcellini Oct 6, 2025

Uh oh!

neil-marcellini Oct 6, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 6, 2025

Uh oh!

OSBotify commented Oct 6, 2025

Uh oh!

OSBotify commented Oct 7, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dominictb commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 30, 2025

Uh oh!

codecov Bot commented Sep 30, 2025

Codecov Report

Uh oh!

allroundexperts commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Oct 1, 2025

Uh oh!

dominictb commented Oct 2, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 6, 2025

Uh oh!

OSBotify commented Oct 6, 2025

Uh oh!

OSBotify commented Oct 7, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dominictb commented Sep 22, 2025 •

edited

Loading

allroundexperts commented Oct 1, 2025 •

edited

Loading