Refactor `MoneyRequestView` component to eliminate redundant checks by VickyStash · Pull Request #70994 · Expensify/App

VickyStash · 2025-09-22T15:14:59Z

Explanation of Change

Refactor MoneyRequestView component to eliminate redundant checks

Fixed Issues

$ #68829
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Create a workspace.
Open the workspace chat.
Create an expense there.
Open it, make sure it's not empty and there is no endless loading.
Create one more expense and open it. Make sure it's not empty and there is no endless loading.
Create two duplicate expenses and go through the duplicates resolution flow. Make sure the confirmation page doesn't look empty and there is no endless loading.
Create two more expenses. Select one of the expenses and process with the Merge flow. Make sure the confirmation page doesn't look empty and there is no endless loading.

Additional steps for WEB platform:

Open SelfDM chat.
Create an expense.
Open the expense and copy the URL.
Go to the Settings -> Troubleshoot. Tap Clear cache & restart.
After that, navigate to the copied URL from step 3. Make sure the expense is shown after some loading indication.

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2025-09-22T16:00:13Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

linhvovan29546 · 2025-09-23T11:01:04Z

    const actualParentReport = isFromMergeTransaction ? getReportOrDraftReport(getReportIDForExpense(updatedTransaction)) : parentReport;
    const shouldShowReport = !!parentReportID || !!actualParentReport;

+    if (!report || !transaction) {


I’m unable to reproduce the issue where the report or transaction is empty, even after following the steps in the description.

I also have a question: the old condition checked whether the reportID or transactionID was empty, but the new changes check if the entire report or transaction object. I think these are not equivalent. as I remember reportID or transactionID can sometimes be '' or 0.

I’m unable to reproduce the issue where the report or transaction is empty, even after following the steps in the description.

@linhvovan29546 and it's expected. The test steps also say it shouldn't be empty!

Let me update the condition!

When empty, a separator line appears on the screen

I’m unable to reproduce the issue where the report or transaction is empty, even after following the steps in the description.

Okay, I can reproduce the empty when opening the page for the first time. If we clear the cache and then access the page via its URL.

@linhvovan29546 It works as expected on my end:

Monosnap.screencast.2025-09-24.10-45-58.mp4

Could you please provide more detailed steps (maybe I did something wrong)?
Also, can you please try to do the same with the same page on main and let me know what are the results

Ah, sorry—the image above is hardcoded, so it is incorrect. You can try following the steps in the video to reproduce the issue.
I was able to reproduce in the personal space, I'm not sure if this is expected. On the main branch, we still display the MoneyRequestView even when the value is empty.

Screen.Recording.2025-09-24.at.16.04.32.mov

Yep, I was able to reproduce it!
I've updated the logic to show the loading instead, cause on main it shows the expense with no details for a second, which isn't great as well. @linhvovan29546 Let me know what you think!

…lean-up

linhvovan29546 · 2025-09-25T10:45:16Z

In this PR, we’ve implemented skeleton loading for the MoneyRequestView when opening an expense. @Expensify/design, could you please help confirm if this change looks good?

This will show a loading indicator while waiting for the data

Screen.Recording.2025-09-25.at.17.44.06.mov

shawnborton · 2025-09-25T14:02:53Z

What did it look like before?

linhvovan29546 · 2025-09-25T14:08:44Z

Previously, the page was displayed with empty values.

shawnborton · 2025-09-25T15:44:43Z

Can you show a recording of what it was before?

I don't have strong feelings with this new skeleton view though, I guess it is consistent with other chat views in the app. Any additional thoughts @mountiny? Asking you since you've worked on these things before I think.

mountiny · 2025-09-25T17:27:26Z

Yeah same I think this is ok to show it this way with the skeleton

linhvovan29546 · 2025-09-26T03:25:28Z

Can you show a recording of what it was before?

You can see it at 0:11

Screen.Recording.2025-09-25.at.21.09.21.mov

linhvovan29546 · 2025-09-26T11:09:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-09-26.at.19.19.11.mov

Android: mWeb Chrome

Screen.Recording.2025-09-26.at.19.26.56.mov

iOS: HybridApp

Screen.Recording.2025-09-26.at.18.57.47.mov

iOS: mWeb Safari

Screen.Recording.2025-09-26.at.19.07.09.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-26.at.18.39.31.mov

MacOS: Desktop

Screen.Recording.2025-09-26.at.19.50.20.mov

linhvovan29546 · 2025-09-26T11:19:19Z

@VickyStash Could you please merge the main branch again? I encountered a crash when following these steps, but it doesn’t happen on the main branch.

Screen.Recording.2025-09-26.at.18.14.40.mov

…lean-up

codecov · 2025-09-26T11:45:20Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/components/ReportActionItem/MoneyRequestView.tsx	0.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

linhvovan29546 · 2025-09-26T13:18:54Z

@VickyStash This worked for me. Could you please help add test section for personal space(selfDM) as well?

VickyStash · 2025-09-26T13:23:25Z

@VickyStash This worked for me. Could you please help add test section for personal space(selfDM) as well?

Sure, just updated the section, let me know if anything else is needed!

linhvovan29546

The PR worked for me. I’m not sure if we should add UI test for this change as well.

roryabraham · 2025-09-26T17:44:43Z

UI tests would be great, but it's NAB.

roryabraham · 2025-09-26T17:44:58Z

spellcheck is unrelated, ignoring for now

melvin-bot · 2025-09-26T17:45:14Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2025-09-26T17:56:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-26T23:07:21Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.19-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-29T20:16:33Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.19-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jjcoffee · 2026-02-19T12:54:25Z

    const actualParentReport = isFromMergeTransaction ? getReportOrDraftReport(getReportIDForExpense(updatedTransaction)) : parentReport;
    const shouldShowReport = !!parentReportID || !!actualParentReport;

+    if (!report?.reportID || !transaction?.transactionID) {


Coming from #79072. transaction can be undefined for a self-DM expense opened whilst offline. So this condition would lead to displaying an infinite loader rather than displaying the cached data.

Refactor MoneyRequestView component to eliminate redundant checks

400bdbe

melvin-bot Bot assigned VickyStash Sep 22, 2025

VickyStash marked this pull request as ready for review September 22, 2025 16:00

VickyStash requested a review from a team as a code owner September 22, 2025 16:00

melvin-bot Bot requested review from linhvovan29546 and removed request for a team September 22, 2025 16:00

VickyStash mentioned this pull request Sep 22, 2025

[$250] [Pay on 10/6] Refactor MoneyRequestView component to eliminate redundant checks #68829

Closed

linhvovan29546 reviewed Sep 23, 2025

View reviewed changes

VickyStash added 3 commits September 23, 2025 15:46

Improve the check

522d842

Merge branch 'main' into VickyStash/refactor/68829-MoneyRequestView-c…

f95596c

…lean-up

Show loading indication instead of the empty view

c3b3946

VickyStash requested a review from linhvovan29546 September 26, 2025 09:11

Merge branch 'main' into VickyStash/refactor/68829-MoneyRequestView-c…

38d4e93

…lean-up

linhvovan29546 approved these changes Sep 26, 2025

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 26, 2025 13:30

roryabraham approved these changes Sep 26, 2025

View reviewed changes

roryabraham merged commit 8e8e5c3 into Expensify:main Sep 26, 2025
20 of 21 checks passed

melvin-bot Bot added the Emergency label Sep 26, 2025

OSBotify mentioned this pull request Sep 26, 2025

Deploy Checklist: New Expensify 2025-09-26 #71399

Closed

62 tasks done

mitarachim mentioned this pull request Sep 26, 2025

Expense - "moved this expense" turns blank briefly when reopening transaction thread #71406

Closed

3 of 8 tasks

roryabraham removed the Emergency label Sep 29, 2025

jjcoffee reviewed Feb 19, 2026

View reviewed changes

Conversation

VickyStash commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 22, 2025

Uh oh!

linhvovan29546 Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VickyStash Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Sep 25, 2025

Uh oh!

shawnborton commented Sep 25, 2025

Uh oh!

linhvovan29546 commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Sep 25, 2025

Uh oh!

mountiny commented Sep 25, 2025

Uh oh!

linhvovan29546 commented Sep 26, 2025

Uh oh!

linhvovan29546 commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 commented Sep 26, 2025

Uh oh!

codecov Bot commented Sep 26, 2025

Codecov Report

Uh oh!

linhvovan29546 commented Sep 26, 2025

Uh oh!

VickyStash commented Sep 26, 2025

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Sep 26, 2025

Uh oh!

roryabraham commented Sep 26, 2025

Uh oh!

Uh oh!

melvin-bot Bot commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 29, 2025

Uh oh!

jjcoffee Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

VickyStash commented Sep 22, 2025 •

edited

Loading

VickyStash Sep 24, 2025 •

edited

Loading

linhvovan29546 Sep 24, 2025 •

edited

Loading

linhvovan29546 commented Sep 25, 2025 •

edited

Loading

linhvovan29546 commented Sep 26, 2025 •

edited

Loading