[Due for payment 2026-02-17] [$250] Expense - Opening 1:1 expense in offline loads infinitely submitted from self dm

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.95-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77203
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

Pre-condition
1.Turn off internet
2.Account has Self DM
3.Open Reports/Expenses
4.User have 1:1 DM

1.Launch app
2.Create a track expense and submit it to Self DM
3.Tap on "Submit to someone" below expense preview.
4.Submit the expense to any 1:1 conversation.
5.Open 1:1 chat, note page is loading infinitely
6.Open Reports > Expense
7. Note the page is loading infinitely

Expected Result:

Opening 1:1 expense in offline must not load infinitely submitted from self dm.

Actual Result:

Opening 1:1 expense in offline loads infinitely submitted from self dm.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022011106692976624469
• Upwork Job ID: 2011106692976624469
• Last Price Increase: 2026-01-13

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twinkle-react]

Proposal

---

Please re-state the problem that we are trying to solve in this issue.

Opening a 1:1 expense report while offline results in an infinite loading state, instead of gracefully handling the offline scenario.

---

What is the root cause of that problem?

The openReport function in src/libs/actions/Report.ts does not check for offline status before making API calls. When the app is offline:

• isLoadingInitialReportActions: true is set in the optimistic data

• The API call is queued but never executes due to offline status in SequentialQueue

• The success response that would set:

  • isLoadingInitialReportActions: false
  • hasOnceLoadedReportActions: true
    is never applied

As a result, the UI remains stuck in an infinite loading state.

---

What changes do you think we should make in order to solve the problem?

Add an offline check at the beginning of the openReport function to prevent API calls when the app is offline, following the same pattern used in the searchInServer function.

function openReport(
    reportID: string | undefined,
    reportActionID?: string,
    participantLoginList: string[] = [],
    newReportObject?: OptimisticChatReport,
    parentReportActionID?: string,
    isFromDeepLink = false,
    participantAccountIDList: number[] = [],
    avatar?: File | CustomRNImageManipulatorResult,
    isNewThread = false,
    transaction?: Transaction,
    transactionViolations?: TransactionViolations,
    parentReportID?: string,
    shouldAddPendingFields = true,
    optimisticSelfDMReport?: Report,
) {
    if (!reportID) {
        return;
    }

    // When offline, we cannot load report actions from the server, so return early
    const isOffline = NetworkStore.isOffline();
    if (isOffline) {
        return;
    }

    // existing logic…
}

What alternative solutions did you explore? (Optional)
NONE

[yatin-italy]

Proposal

---

Please re-state the problem that we are trying to solve in this issue.

Opening a 1:1 expense report when offline causes an infinite loading state instead of gracefully handling the offline scenario.

---

What is the root cause of that problem?

The openReport function in src/libs/actions/Report.ts does not check for offline status before making API calls. When offline:

• It sets isLoadingInitialReportActions: true in optimistic data.
• The API call gets queued but never executes due to offline status in the SequentialQueue.
• The success data that would set isLoadingInitialReportActions: false and hasOnceLoadedReportActions: true never gets applied.

This leaves the UI in an infinite loading state.

---

What changes do you think we should make in order to solve the problem?

Modify the SequentialQueue to immediately process offline requests with failure data instead of just queuing them. This triggers the failure data and clears the loading state.

function push(newRequest: OnyxRequest) {
    const {checkAndFixConflictingRequest} = newRequest;

    // If we are offline, immediately fail the request to clear loading states
    if (isOffline()) {
        Log.info('[SequentialQueue] Failing request due to offline status');

        // Process the request with failure data immediately
        processWithMiddleware({
            ...newRequest,
            data: {
                ...newRequest.data,
                jsonCode: 0, // Offline error code
                message: 'Offline'
            }
        });
        return;
    }

    if (checkAndFixConflictingRequest) {
        const requests = getAllPersistedRequests();
        const {conflictAction} = checkAndFixConflictingRequest(requests);
        Log.info(`[SequentialQueue] Conflict action for command ${newRequest.command} - ${conflictAction.type}:`);
        // don't try to serialize a function.
        // eslint-disable-next-line no-param-reassign
        delete newRequest.checkAndFixConflictingRequest;
        handleConflictActions(conflictAction, newRequest);
    } else {
        Log.info('[SequentialQueue] No conflict action. Adding request to Persisted Requests', false, {command: newRequest.command});
        // Add request to Persisted Requests so that it can be retried if it fails
        savePersistedRequest(newRequest);
    }

    // If the queue is running this request will run once it has finished processing the current batch
    if (isSequentialQueueRunning) {
        Log.info('[SequentialQueue] Queue is running. Will flush when the current request is finished.');
        isReadyPromise.then(() => flush(true));
        return;
    }

    Log.info('[SequentialQueue] Queue is not running. Flushing the queue.');
    flush(true);
}

---

What alternative solutions did you explore?

None

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening 1:1 expense in offline loads infinitely submitted from self dm.

What is the root cause of that problem?

1. Since transaction here is undefined, it will render ReportActionsSkeletonView:
   

   App/src/components/ReportActionItem/MoneyRequestView.tsx

   Lines 738 to 740 in 99867a7

   	if ((!readonly && !transactionThreadReport?.reportID) || !transaction?.transactionID) {
   	return <ReportActionsSkeletonView />;
   	}

2. The transaction is retrieved here, and it receives the value undefined because the parentReportID and parentReportActionID of transactionThreadReport are set incorrectly:
   

   App/src/components/ReportActionItem/MoneyRequestView.tsx

   Lines 193 to 197 in 99867a7

   	const linkedTransactionID = parentReportAction && isMoneyRequestAction(parentReportAction) ? getOriginalMessage(parentReportAction)?.IOUTransactionID : undefined;
   	let [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${getNonEmptyStringOnyxID(linkedTransactionID)}`, {canBeMissing: true});
   	if (updatedTransaction) {
   	transaction = updatedTransaction;
   	}

3. parentReportID and parentReportActionID are not updated in the optimistic data when calling the API:
   

   App/src/libs/actions/IOU/index.ts

   Line 5318 in 99867a7

   function convertTrackedExpenseToRequest(convertTrackedExpenseParams: ConvertTrackedExpenseToRequestParams) {

   
   So it keeps the old values in selfDM and causes infinite loading.

What changes do you think we should make in order to solve the problem?

• We need to set parentReportID and parentReportActionID according to the new iouAction:
  

  App/src/libs/actions/IOU/index.ts

  Line 5349 in 99867a7

  optimisticData?.push(...convertTransactionOptimisticData);

optimisticData?.push(...convertTransactionOptimisticData, {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`,
    value: {
        parentReportActionID: iouParams.reportActionID,
        parentReportID: iouParams.reportID,
    },
});

• transactionThreadReportID also needs to ensure it falls back to the existing value.
  

  App/src/libs/actions/IOU/index.ts

  Line 3222 in 99867a7

  transactionThreadReportID: optimisticTransactionThread?.reportID,

    transactionThreadReportID: optimisticTransactionThread?.reportID ?? linkedTrackedExpenseReportAction?.childReportID,

What alternative solutions did you explore? (Optional)

N/A

2026-01-08.22-43-51.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022011106692976624469

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)