Report virtual card fraud verify magic code to use navigation by jmusial · Pull Request #70813 · Expensify/App

jmusial · 2025-09-18T14:56:44Z

Explanation of Change

This PR rewrites Expensify card fraud reporting verification to use navigation instead of modals.

Fixed Issues

$ #69171

PROPOSAL:
N/A

Tests

Pre requisite: have an account with at least one Expensify card created and assigned.

Log in
Go to "Account" => "Wallet"
Click on card in "Assigned cards"
Click "Report virtual card fraud", and "Deactivate card" on the next screen
Verify that "Lets make sure its you" page shows on separate url (when possible)
Fill in the code
Card is deactivated

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

0047.Android.native.mov

Android: mWeb Chrome

0047.Andorid.chrome.mov

iOS: Native

0047.ios.native.mp4

iOS: mWeb Safari

0047.ios.safari.mp4

MacOS: Chrome / Safari

0047.desktop.chrome.mov

0047.desktop.chrome.fail.mov

MacOS: Desktop

0047.desktop.native.mov

…avigation

melvin-bot · 2025-09-22T09:56:00Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jmusial · 2025-09-22T09:58:45Z

I think I found a bug in the flow, but would like to confirm before changing it. If a wrong magic code is entered there is a mismatch between keys coming from the backend and expected on the FE. Please see the video.

The key form BE: reportVirtualCard
In ONYXKEYS: REPORT_VIRTUAL_CARD_FRAUD: 'reportVirtualCardFraudForm',

Currently if you enterd wrong magic code you get pretty much undismissable error :(

0047.invalid.onyx.key.mov

ishpaul777 · 2025-09-23T18:54:16Z

@jmusial what we currently have on FE is more descriptive, but I think its fine to update it to match the BE to unblock the PR.

cc @mountiny

mountiny · 2025-09-24T18:37:13Z

@jmusial What is the name of the API call used?

…avigation

jmusial · 2025-09-25T12:36:41Z

@mountiny

https://dev.new.expensify.com:8082/staging/api/ReportVirtualExpensifyCardFraud?

response

{
    "code": 666,
    "jsonCode": 401,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "e878187d-af80-4f71-91de-28669f9eaa0f",
    "message": "Incorrect or invalid magic code. Please try again.",
    "title": "",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "validateActionCode",
                "value": {
                    "errorFields": {
                        "reportVirtualCard": {
                            "1758803518402679": "Incorrect or invalid magic code. Please try again."
                        }
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "validateActionCode",
            "value": {
                "errorFields": {
                    "reportVirtualCard": {
                        "1758803518402679": "Incorrect or invalid magic code. Please try again."
                    }
                }
            }
        }
    ],
    "requestID": "984a8aa47aa0613b-SJC"
}

in the code: src/libs/actions/Card.ts#102

codecov · 2025-09-25T12:39:02Z

Codecov Report

❌ Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...Wallet/ReportVirtualCardFraudVerifyAccountPage.tsx	0.00%	37 Missing ⚠️
src/ROUTES.ts	0.00%	2 Missing ⚠️
src/pages/settings/Wallet/ExpensifyCardPage.tsx	0.00%	2 Missing ⚠️
...gation/AppNavigator/ModalStackNavigators/index.tsx	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

ishpaul777 · 2025-09-26T14:57:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-09-26.at.8.24.42.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-09-26.at.8.26.32.PM.mov

iOS: HybridApp

Screen.Recording.2025-09-26.at.12.26.32.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-09-26.at.4.14.35.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-26.at.3.51.20.AM.mov

MacOS: Desktop

Screen.Recording.2025-09-26.at.8.42.23.PM.mov

mountiny · 2025-09-26T16:52:44Z

+            title={translate('cardPage.validateCardTitle')}
+            descriptionPrimary={translate('cardPage.enterMagicCode', {contactMethod: primaryLogin})}
+            sendValidateCode={() => requestValidateCodeAction()}
+            validateCodeActionErrorField="revealExpensifyCardDetails"


I have a PR here but if I pass wrong magic code, the page goes successfully, does this need to be reportVirtualCardFraudForm to work?

This is returned but error is not shown

@jmusial @ishpaul777

good catch, yes we need to update that to reportVirtualCardFraudForm

ah ... ok that's one on me ;(

But it needs to be reportVirtualCard I think. At least that's what it was before

unless what you ment is that you have PR to change that on BE @mountiny ? Cos after my change seems ok

Screen.Recording.2025-09-29.at.15.29.58.mov

@jmusial I wonder if we should change it to reportVirtualCardFraudForm as it's aligned with the other keys that have the Form at the end?

I can do that, but would need to sync it with backend change, otherwise it won't work

Ah ok so that was not an issue in main so it works there haha I see

…avigation

mountiny

Thanks!

OSBotify · 2025-09-30T16:44:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-30T23:33:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.21-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-02T04:24:39Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-02T04:48:24Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

move report virtual card fraud magic code to use navigation

dbabad7

melvin-bot Bot assigned jmusial Sep 18, 2025

jmusial added 4 commits September 19, 2025 10:50

Merge branch 'main' into feat/move-report-virtual-card-fraud-to-use-n…

90a98a5

…avigation

add as const

e78f466

fix errors showing

5732680

Merge branch 'main' into feat/move-report-virtual-card-fraud-to-use-n…

85be33f

…avigation

jmusial marked this pull request as ready for review September 22, 2025 09:55

jmusial requested a review from a team as a code owner September 22, 2025 09:55

melvin-bot Bot requested review from ishpaul777 and removed request for a team September 22, 2025 09:55

mhawryluk mentioned this pull request Sep 22, 2025

[Due for payment now] [Tracking] [$1000] Update the ValidateCodeActionModal to be its own screen in the stack #69171

Closed

Merge branch 'main' into feat/move-report-virtual-card-fraud-to-use-n…

993d7d7

…avigation

mountiny requested changes Sep 26, 2025

View reviewed changes

jmusial added 2 commits September 29, 2025 15:14

Merge branch 'main' into feat/move-report-virtual-card-fraud-to-use-n…

a332725

…avigation

update error string

46bccde

jmusial requested a review from mountiny September 29, 2025 13:33

mountiny approved these changes Sep 30, 2025

View reviewed changes

mountiny merged commit 2662549 into Expensify:main Sep 30, 2025
26 of 27 checks passed

OSBotify mentioned this pull request Sep 30, 2025

Deploy Checklist: New Expensify 2025-09-30 #71621

Closed

72 tasks done

Conversation

jmusial commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 22, 2025

Uh oh!

jmusial commented Sep 22, 2025

Uh oh!

ishpaul777 commented Sep 23, 2025

Uh oh!

mountiny commented Sep 24, 2025

Uh oh!

jmusial commented Sep 25, 2025

Uh oh!

codecov Bot commented Sep 25, 2025

Codecov Report

Uh oh!

ishpaul777 commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 30, 2025

Uh oh!

OSBotify commented Sep 30, 2025

Uh oh!

OSBotify commented Oct 2, 2025

Uh oh!

OSBotify commented Oct 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmusial commented Sep 18, 2025 •

edited

Loading

ishpaul777 commented Sep 26, 2025 •

edited

Loading