fix: broken card connection violation message by dukenv0307 · Pull Request #64050 · Expensify/App

dukenv0307 · 2025-06-12T09:14:21Z

Explanation of Change

Fixed Issues

$ #64059
PROPOSAL:

Tests

Create a card transaction with RTER broken card connection violation
Verify the violation message is Can't auto-match receipt due to broken bank connection which you need to fix for brokenCardConnection and Can't auto-match receipt due to broken bank connection for brokenCardConnection530

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-06-12T17:37:58Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-06-12T19:41:53Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mountiny · 2025-06-12T19:42:15Z

Can you add the same change here?

App/src/components/TransactionItemRow/TransactionItemRowRBR.tsx

Lines 36 to 46 in 1b25509

const RBRMessages = [

...(missingFieldError ? [`${missingFieldError}.`] : []),

// Some violations end with a period already so lets make sure the connected messages have only single period between them

// and end with a single dot.

...(transactionViolations

? transactionViolations.map((violation) => {

const message = ViolationsUtils.getViolationTranslation(violation, translate);

return message.endsWith('.') ? message : `${message}.`;

})

: []),

].join(' ');

Also since we use this in two places, might be good to abstract it and add unit tests @dukenv0307

@mountiny We used this logic in 2 places: TransactionItemRowRBRWithOnyx and TransactionItemRowRBR

TransactionItemRowRBRWithOnyx.tsx was created in

9826c96#diff-8683f652e500f3c7e6c5f06dc327b73a94243bc8a089e3878bf453aab4567b27

to replace TransactionItemRowRBR.tsx

and TransactionItemRowRBR is used only when isInReportTableView is false

9826c96#diff-6b90fc17b4cc83311999c11c904effc6a5cb559a83dbfdcf53f846f8091f2f67R48-R427

Now isInReportTableView is removed so TransactionItemRowRBR is not used anywhere. I think we can remove it

mountiny · 2025-06-12T19:42:33Z

Did you get this confirmed?

github-actions · 2025-06-12T19:45:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64050.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://64050.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

mountiny · 2025-06-12T22:42:40Z

Asked Doza for a test

mountiny · 2025-06-12T23:03:37Z

Doza confirmed this is fixed, @eh2077 can you please proceed with a review?

eh2077 · 2025-06-12T23:47:16Z

I'll start reviewing shortly in an hour

eh2077 · 2025-06-13T01:05:14Z

@dukenv0307 Are the test steps still valid? I tried to follow the test steps but I didn't see violation message for brokenCardConnection530 RTER type violation. I also didn't find it from your screenshots.

I saw a comment from @mountiny

your code is right except move the CONST.RTER_VIOLATION_TYPES.BROKEN_CARD_CONNECTION_530 above to its own if statement and return Can’t auto-match receipt due to a broken bank connection.

so for Doza he should see Can't auto-match receipt due to broken bank connection which you need to fix

So, the exported onyx state should show only violation messages of brokenCardConnection RTER type violation, right?

dukenv0307 · 2025-06-17T03:49:40Z

@eh2077 Yes it's brokenCardConnection. However, in the PR, we also modify the message of brokenCardConnection530, so I think we should add verification for this violation as well.

eh2077 · 2025-06-18T16:25:39Z

@dukenv0307 I think we can add unit tests to cover the change. Do you agree?

mountiny · 2025-06-18T22:24:08Z

Yep lets add unit tests please @dukenv0307

eh2077 · 2025-06-20T07:33:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

eh2077

Looks good, just a minor comment

mountiny · 2025-06-24T01:55:56Z

@eh2077 how is this looking?

eh2077 · 2025-06-24T02:00:52Z

Yeah, code looks good to me. I think we're just waiting for the copy to be confirmed https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1750663573630849

github-actions · 2025-06-26T08:14:49Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

kavimuru · 2025-06-27T23:17:55Z

@dukenv0307 @mountiny we couldn't make a card transaction. Could this be verified internally?

github-actions · 2025-06-27T23:43:44Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-27T23:55:39Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

puneetlath · 2025-06-30T21:46:31Z

This is what I see:

mountiny · 2025-06-30T22:02:11Z

We verified this on the adhoc build too so confident this should be good to check off 👍

github-actions · 2025-06-30T22:19:35Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

dukenv0307 force-pushed the fix/rbr-message branch from c264927 to 23d2c16 Compare June 12, 2025 16:05

dukenv0307 changed the title ~~fix: rbr message~~ fix: broken card connection violation message Jun 12, 2025

dukenv0307 marked this pull request as ready for review June 12, 2025 17:37

dukenv0307 requested a review from a team as a code owner June 12, 2025 17:37

melvin-bot Bot requested review from eh2077 and removed request for a team June 12, 2025 17:37

mountiny assigned dukenv0307 Jun 12, 2025

mountiny reviewed Jun 12, 2025

View reviewed changes

eh2077 reviewed Jun 20, 2025

View reviewed changes

Comment thread src/libs/Violations/ViolationsUtils.ts Outdated

dukenv0307 force-pushed the fix/rbr-message branch 2 times, most recently from 65135c1 to bb2c680 Compare June 26, 2025 08:14

dukenv0307 requested a review from a team as a code owner June 26, 2025 08:14

fix: broken card connection violation message

88cc090

dukenv0307 force-pushed the fix/rbr-message branch from 9894e7c to 88cc090 Compare June 26, 2025 08:17

update translation

8a94ff4

mountiny requested a review from eh2077 June 26, 2025 18:10

mountiny approved these changes Jun 26, 2025

View reviewed changes

mountiny merged commit d82bea9 into Expensify:main Jun 26, 2025

This was referenced Jun 26, 2025

Investigate workflow job failing on main: test / test (job 3) #65036

Closed

Deploy Checklist: New Expensify 2025-06-27 #65114

Closed

QichenZhu mentioned this pull request Jul 1, 2025

[$250] RBR dots shown with no violations due to broken card connection — no messages rendered #64826

Closed

16 tasks

	const RBRMessages = [
	...(missingFieldError ? [`${missingFieldError}.`] : []),
	// Some violations end with a period already so lets make sure the connected messages have only single period between them
	// and end with a single dot.
	...(transactionViolations
	? transactionViolations.map((violation) => {
	const message = ViolationsUtils.getViolationTranslation(violation, translate);
	return message.endsWith('.') ? message : `${message}.`;
	})
	: []),
	].join(' ');

Conversation

dukenv0307 commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

mountiny Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

mountiny commented Jun 12, 2025

Uh oh!

mountiny commented Jun 12, 2025

Uh oh!

eh2077 commented Jun 12, 2025

Uh oh!

eh2077 commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Jun 17, 2025

Uh oh!

eh2077 commented Jun 18, 2025

Uh oh!

mountiny commented Jun 18, 2025

Uh oh!

eh2077 commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny commented Jun 24, 2025

Uh oh!

eh2077 commented Jun 24, 2025

Uh oh!

github-actions Bot commented Jun 26, 2025

Uh oh!

kavimuru commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

puneetlath commented Jun 30, 2025

Uh oh!

mountiny commented Jun 30, 2025

Uh oh!

github-actions Bot commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented Jun 12, 2025 •

edited

Loading

eh2077 commented Jun 13, 2025 •

edited

Loading

eh2077 commented Jun 20, 2025 •

edited

Loading