Fix - Remove SCREENS.SETTINGS.EXIT_SURVEY.BOOK_CALL page from Switch to Expensify Classic - #61337
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Let's fix these navigation go back bugs as well: Screen.Recording.2025-05-05.at.12.02.36.movScreen.Recording.2025-05-05.at.12.03.52.mov |
|
Fixed |
|
Oops, we have a lots of lintings here 👀 |
Fixed |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-05.at.13.20.55.movAndroid: mWeb ChromeScreen.Recording.2025-05-05.at.13.22.08.moviOS: HybridAppScreen.Recording.2025-05-05.at.13.17.01.movScreen.Recording.2025-05-05.at.13.17.25.moviOS: mWeb SafariScreen.Recording.2025-05-05.at.13.18.27.movMacOS: Chrome / SafariScreen.Recording.2025-05-05.at.12.01.27.movScreen.Recording.2025-05-05.at.12.01.48.movMacOS: DesktopScreen.Recording.2025-05-05.at.13.13.34.movDesktop.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/10)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/10)Meaningless Changes To Duration (9/9)Show entries
Show details
|
Performance Comparison Report 📊 (2/10)Meaningless Changes To Duration (1/9)Show entries
Show details
|
Performance Comparison Report 📊 (3/10)Meaningless Changes To Duration (2/9)Show entries
Show details
|
Performance Comparison Report 📊 (4/10)Meaningless Changes To Duration (3/9)Show entries
Show details
|
Performance Comparison Report 📊 (5/10)Meaningless Changes To Duration (4/9)Show entries
Show details
|
Performance Comparison Report 📊 (6/10)Meaningless Changes To Duration (5/9)Show entries
Show details
|
Performance Comparison Report 📊 (7/10)Meaningless Changes To Duration (6/9)Show entries
Show details
|
Performance Comparison Report 📊 (8/10)Meaningless Changes To Duration (7/9)Show entries
Show details
|
Performance Comparison Report 📊 (9/10)Meaningless Changes To Duration (8/9)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.1.41-0 🚀
|
|
Hello @FitseTLT @hungvu193 , Is there a pre-condition to see the exit survey in hybrid app (android and iOS)?because in hybrid app we couldn't see exit survey as in PR video az_recorder_20250507_142149.mp4 |
|
@mitarachim Yeah, it can only open ExistSurveyReasonPage if you have Let's login your account into OD, open Insector and paste these value into the consle then press Enter: NVP.set('tryNewDot', {classicRedirect: {dismissed: false}});Let me know if it helps! Screen.Recording.2025-05-07.at.15.23.44.mov |
|
@hungvu193 I try with below steps :
But i only could see Screen.Recording.2025-05-07.at.3.33.46.PM.mp42025-05-07.3.38.41.PM.mp4still couldn't see ScreenRecording_05-07-2025.15-34-11_1.MP42025-05-07.3.39.57.PM.mp4 |
|
@mitarachim Yep. If you're running Hybrid app, it will always redirect you to OD App. That's intentional |
|
Okay noted , thank you very much @hungvu193 |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.41-1 🚀
|
Details
Fixed Issues
$ #61251
PROPOSAL: #61251 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-05-02.18-18-18.mp4
Android: mWeb Chrome
2025-05-02.18-19-30.mp4
iOS: Native
2025-05-02.15-44-06.mp4
iOS: mWeb Safari
2025-05-02.15-45-06.mp4
MacOS: Chrome / Safari
2025-05-02.15-43-29.mp4
MacOS: Desktop
2025-05-02.15-43-43.mp4