[Due for payment 2025-05-14] [$125] Remove SCREENS.SETTINGS.EXIT_SURVEY.BOOK_CALL page from Switch to Expensify Classic

[laurenreidexpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

We could like to remove the page where you can book a call with a product manager from the Switch to Expensify Classic flow:

This was introduced in #51703 cc @hungvu193 if you would like to work on a proposal to remove it.

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917965908681062303
• Upwork Job ID: 1917965908681062303
• Last Price Increase: 2025-05-01
• Automatic offers:
• FitseTLT | Contributor | 107141620

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917965908681062303

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[laurenreidexpensify]

ha @hungvu193 the system chose you as C+ - lmk if you want to work on it as a contributor instead.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-01 15:48:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove SCREENS.SETTINGS.EXIT_SURVEY.BOOK_CALL page from Switch to Expensify Classic

What is the root cause of that problem?

New Feature

What changes do you think we should make in order to solve the problem?

We need to replace this code

App/src/pages/settings/InitialSettingsPage.tsx

Lines 264 to 269 in 3191948

	if (shouldOpenBookACall) {
	Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVERY_BOOK_CALL.route);
	return;
	}
	Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVEY_CONFIRM.route);
	});

with

                                      Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVEY_REASON.route);

so that we directly navigate to SETTINGS_EXIT_SURVEY_REASON page
Then we can remove ExitSurveyBookCallPage and other relevant code like routes screens shouldOpenBookACall var etc.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We will remove this test as it is irrelevant now

App/tests/ui/SwitchToExpensifyClassicTest.tsx

Lines 69 to 87 in 3191948

	describe('Switch to Expensify Classic flow', () => {
	beforeEach(() => {
	jest.clearAllMocks();
	Onyx.clear();
	// Unsubscribe to pusher channels
	PusherHelper.teardown();
	});
	test('Should navigate to BookACall when dismissed is false', () => {
	signInAppAndEnterTestFlow(false).then(() => {
	expect(screen.getAllByText(Localize.translateLocal('exitSurvey.bookACallTitle')).at(0)).toBeOnTheScreen();
	});
	});
	test('Should navigate to ConfirmPage when dismissed is true', () => {
	signInAppAndEnterTestFlow(true).then(() => {
	expect(screen.getAllByText(Localize.translateLocal('exitSurvey.goToExpensifyClassic')).at(0)).toBeOnTheScreen();
	});

and replace it with a correct test to assert we are navigated to exit survey reason page

test('Should navigate to exit survey reason page', () => {
        signInAppAndEnterTestFlow(false).then(() => {
            expect(screen.getAllByText(Localize.translateLocal('exitSurvey.reasonPage.subtitle')).at(0)).toBeOnTheScreen();
        });
    });

What alternative solutions did you explore? (Optional)

[cretadn22]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-01 15:48:58 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

We need to remove ExitSurveyBookCall Component and all related things

And replace these lines

App/src/pages/settings/InitialSettingsPage.tsx

Lines 264 to 268 in 0f2089e

	if (shouldOpenBookACall) {
	Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVERY_BOOK_CALL.route);
	return;
	}
	Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVEY_CONFIRM.route);

\

to

Navigation.navigate(ROUTES.SETTINGS_EXIT_SURVEY_REASON.route);

And remove the test

App/tests/ui/SwitchToExpensifyClassicTest.tsx

Lines 78 to 82 in 0f2089e

	test('Should navigate to BookACall when dismissed is false', () => {
	signInAppAndEnterTestFlow(false).then(() => {
	expect(screen.getAllByText(Localize.translateLocal('exitSurvey.bookACallTitle')).at(0)).toBeOnTheScreen();
	});
	});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.