Skip to content

[No QA] fix: remote builds config #60175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 3 commits into from
Apr 14, 2025
Merged

[No QA] fix: remote builds config #60175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5802e5
fix: avoid failing fast on the matrix
adhorodyski Apr 14, 2025
35d700a
fix: parametrize node setup for hybrid/nd
adhorodyski Apr 14, 2025
6ec4f07
fix: only fetch with submodules for hybrid builds
adhorodyski Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/remote-build-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,27 @@ jobs:
build:
runs-on: ubuntu-latest-xl
strategy:
fail-fast: false
matrix:
include:
- project_root: ./
variant: 'developmentDebug'

- project_root: Mobile-Expensify/
is_hybrid_build: true
variant: 'Debug'
steps:
- name: Checkout
# v4
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
with:
submodules: true
submodules: ${{ matrix.is_hybrid_build || false }}
token: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: Setup Node
uses: ./.github/actions/composite/setupNode
with:
IS_HYBRID_BUILD: ${{ matrix.is_hybrid_build && 'true' || 'false' }}

- name: RNEF Remote Build - Android
uses: callstackincubator/android@a49920aadab9f41951944ea52bb7983fa6b20b03
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/remote-build-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,29 @@ jobs:
build:
runs-on: macos-15-xlarge
strategy:
fail-fast: false
matrix:
include:
- project_root: ./
scheme: 'New Expensify Dev'
configuration: 'DebugDevelopment'

- project_root: Mobile-Expensify/
is_hybrid_build: true
scheme: 'Expensify Dev'
configuration: 'Debug'
steps:
- name: Checkout
# v4
uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
with:
submodules: true
submodules: ${{ matrix.is_hybrid_build || false }}
token: ${{ secrets.OS_BOTIFY_TOKEN }}

- name: Setup Node
uses: ./.github/actions/composite/setupNode
with:
IS_HYBRID_BUILD: ${{ matrix.is_hybrid_build && 'true' || 'false' }}

- name: RNEF Remote Build - iOS
uses: callstackincubator/ios@4c2dcc0d6b9c35407cf294e17386b65258a3b6af
Expand Down