[No QA] fix: remote builds config - #60175
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Testing Newdot builds with a temporary commit under here: https://github.com/Expensify/App/actions/runs/14442673424 EDIT: Newdot iOS succeeded, testing a cache hit now + Android. Summary: with the PR in the current state, this should unlock Newdot remote builds. |
bfdb014 to
b5802e5
Compare
|
Following up on this Slack thread I'll still have to apply an update to fix Newdot builds even when they succeeded on this PR before. |
|
Finished, here's the latest state for this PR:
With the above updates:
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.28-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.28-15 🚀
|
Explanation of Change
As we recently introduced remote builds being triggered on the CI, this came with a bug of failing fast if any of the builds in the matrix turn out to fail. See https://github.com/Expensify/App/actions/runs/14438337157/job/40483190702 as an example.
This PR solves that by allowing individual jobs in the matrix to continue.
It also adds the
IS_HYBRID_BUILDenv variable to theSetup Nodestep required for hybrid builds.Fixed Issues
$ #58743
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop