Fix: Expensify Card page in empty state has two scoll bars by twilight2294 · Pull Request #57588 · Expensify/App

twilight2294 · 2025-02-28T05:44:38Z

Explanation of Change

Fixed Issues

$ #56690
PROPOSAL: #56690 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Precondition:

Expensify Card feature is set up but no card is assigned.

Test:

Go to workspace settings > Expensify Card.
Verify that There will be one scroll bar in Expensify Card page in empty state.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_recording_20250309_133638.mp4

Android: mWeb Chrome

Screen_recording_20250309_133758.mp4

iOS: Native

Simulator.Screen.Recording.-.Expensify.testing.-.2025-03-09.at.13.33.15.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.Expensify.testing.-.2025-03-09.at.13.29.24.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-09.at.11.33.27.AM.mov

MacOS: Desktop

Screen.Recording.2025-03-09.at.1.31.45.PM.mov

melvin-bot · 2025-03-09T06:00:52Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-03-10T08:58:32Z

Is this ready for a @Expensify/design review?

twilight2294 · 2025-03-10T15:41:40Z

Yes @shawnborton !

shawnborton · 2025-03-10T17:36:33Z

Okay cool - I don't have any ECards on my accounts but I will at least generate a test build for easier testing. cc @hoangzinh to start the final review since the screenshots look pretty good.

github-actions · 2025-03-10T17:37:02Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-10T18:01:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57588/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android Hybrid build failed	The QR code can't be generated, because the iOS Hybrid build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/57588/NewExpensify.dmg	https://57588.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hoangzinh · 2025-03-11T13:19:39Z

    headerStyles,
    headerContentStyles,
    lottieWebViewStyles,
-    showsVerticalScrollIndicator,


We should also remove type here

App/src/components/EmptyStateComponent/types.ts

Line 27 in 75ab857

showsVerticalScrollIndicator?: boolean;

hoangzinh · 2025-03-11T14:36:47Z

-            >
-                {content.children}
-            </EmptyStateComponent>
+            <ScrollView>


Suggested change

<ScrollView>

<ScrollView showsVerticalScrollIndicator={false}>

we should pass showsVerticalScrollIndicator={false} here. Can you double check other places?

The default value of is true, so we only need to update it at this place, all other places pass it as true by default:

https://reactnative.dev/docs/scrollview#showsverticalscrollindicator

twilight2294 · 2025-03-17T08:01:42Z

I was OoO most of last week, working on it today!

twilight2294 · 2025-03-24T03:14:15Z

resolving conflicts

twilight2294 · 2025-03-24T05:26:29Z

-            addBottomSafeAreaPadding={addBottomSafeAreaPadding}
-            addOfflineIndicatorBottomSafeAreaPadding={addOfflineIndicatorBottomSafeAreaPadding}


@hoangzinh we don't need to add these values to individual scrollViews as the default value for these are false in scrollview:

App/src/components/ScrollView.tsx

Lines 16 to 22 in 4750e38

function ScrollView(

{

children,

scrollIndicatorInsets,

contentContainerStyle: contentContainerStyleProp,

addBottomSafeAreaPadding = false,

addOfflineIndicatorBottomSafeAreaPadding = addBottomSafeAreaPadding,

Also don't pass them as true in any usage of EmptyStateComponent, so we are good with this change

hoangzinh · 2025-03-24T15:00:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-24.at.22.45.06.mov

Android: mWeb Chrome

Screen.Recording.2025-03-24.at.22.03.45.android.chrome.mov

iOS: Native

Screen.Recording.2025-03-24.at.22.19.20.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-03-24.at.22.06.28.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-24.at.21.59.18.web.mov

MacOS: Desktop

Screen.Recording.2025-03-24.at.22.01.32.desktop.mov

hoangzinh · 2025-03-24T15:08:26Z

@twilight2294 can you put "Verify that There will be one scroll bar in Expensify Card page in empty state." as 2nd step?

twilight2294 · 2025-03-24T16:01:28Z

Done !

hoangzinh

LGTM

robertjchen · 2025-03-25T08:06:12Z

thanks!

OSBotify · 2025-03-25T08:24:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-26T06:13:12Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.1.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-27T13:30:21Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.19-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

hoangzinh · 2025-04-08T19:47:48Z

-            >
-                {content.children}
-            </EmptyStateComponent>
+            <ScrollView showsVerticalScrollIndicator={false}>


We should also migrate the style from the previous EmptyStateComponent, otherwise it will cause an UI issue here

twilight2294 added 4 commits February 28, 2025 11:14

fix 2 scrollViews in a single page

4758501

Merge branch 'Expensify:main' into patch-28

e9f5124

Merge branch 'Expensify:main' into patch-28

fccd8fc

fix scrollview for global empty container view

0005bab

twilight2294 marked this pull request as ready for review March 9, 2025 06:00

twilight2294 requested a review from a team as a code owner March 9, 2025 06:00

melvin-bot Bot requested review from hoangzinh and removed request for a team March 9, 2025 06:00

twilight2294 added 2 commits March 9, 2025 06:12

remove scrollview

1c23cb8

apply scrollview to all pages containing empty view

66e8023

twilight2294 mentioned this pull request Mar 9, 2025

[Due for payment 2025-04-03] [$250] Web - Expensify Card - Expensify Card page in empty state has two scoll bars #56690

Closed

8 tasks

twilight2294 added 3 commits March 9, 2025 13:50

apply overflow hidden

cc160e3

update named imports

102d779

fix device capabilities named import

9a86e0c

shawnborton added the Ready To Build label Mar 10, 2025

Merge branch 'Expensify:main' into patch-28

774a07c

hoangzinh reviewed Mar 11, 2025

View reviewed changes

Merge branch 'main' into patch-28

e218383

twilight2294 commented Mar 24, 2025

View reviewed changes

remove redundant props

f0b3845

hoangzinh approved these changes Mar 24, 2025

View reviewed changes

melvin-bot Bot requested a review from robertjchen March 24, 2025 16:04

robertjchen approved these changes Mar 25, 2025

View reviewed changes

robertjchen merged commit 8c827d7 into Expensify:main Mar 25, 2025

github-actions Bot mentioned this pull request Mar 26, 2025

Deploy Checklist: New Expensify 2025-03-26 #59127

Closed

50 tasks

daledah mentioned this pull request Mar 26, 2025

[Due for payment 2025-04-08] [$250] Reports - Empty state screen is not at the middle #59136

Closed

8 tasks

hoangzinh reviewed Apr 8, 2025

View reviewed changes

	<ScrollView>
	<ScrollView showsVerticalScrollIndicator={false}>

		addBottomSafeAreaPadding={addBottomSafeAreaPadding}
		addOfflineIndicatorBottomSafeAreaPadding={addOfflineIndicatorBottomSafeAreaPadding}

	function ScrollView(
	{
	children,
	scrollIndicatorInsets,
	contentContainerStyle: contentContainerStyleProp,
	addBottomSafeAreaPadding = false,
	addOfflineIndicatorBottomSafeAreaPadding = addBottomSafeAreaPadding,

Conversation

twilight2294 commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 9, 2025

Uh oh!

shawnborton commented Mar 10, 2025

Uh oh!

twilight2294 commented Mar 10, 2025

Uh oh!

shawnborton commented Mar 10, 2025

Uh oh!

github-actions Bot commented Mar 10, 2025

Uh oh!

github-actions Bot commented Mar 10, 2025

Uh oh!

hoangzinh Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

twilight2294 Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

twilight2294 commented Mar 17, 2025

Uh oh!

twilight2294 commented Mar 24, 2025

Uh oh!

twilight2294 Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Mar 24, 2025

Uh oh!

twilight2294 commented Mar 24, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

robertjchen commented Mar 25, 2025

Uh oh!

OSBotify commented Mar 25, 2025

Uh oh!

github-actions Bot commented Mar 26, 2025

Uh oh!

github-actions Bot commented Mar 27, 2025

Uh oh!

hoangzinh Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

twilight2294 commented Feb 28, 2025 •

edited

Loading

hoangzinh commented Mar 24, 2025 •

edited

Loading