[Due for payment 2025-04-03] [$250] Web - Expensify Card - Expensify Card page in empty state has two scoll bars

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+egrdthgfh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Expensify Card feature is set up but no card is assigned.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card.

Expected Result:

There will be one scroll bar in Expensify Card page in empty state.

Actual Result:

There are two scroll bars in Expensify Card page in empty state.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889430675865762724
• Upwork Job ID: 1889430675865762724
• Last Price Increase: 2025-02-18
• Automatic offers:
• twilight2294 | Contributor | 106202611

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Expensify Card - Expensify Card page in empty state has two scoll bars

What is the root cause of that problem?

We are adding unnecessary scroll view in here

App/src/pages/workspace/expensifyCard/EmptyCardView.tsx

Line 30 in 15d9f03

<ScrollView>

What changes do you think we should make in order to solve the problem?

We should remove it as there is a scroll view in the parent component

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[github-actions]

⚠️ @nkdengineer Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card page in empty state has two scoll bars

What is the root cause of that problem?

We do not pass showsVerticalScrollIndicator={false} to EmptyStateComponent in EmptyCardView:

App/src/pages/workspace/expensifyCard/EmptyCardView.tsx

Lines 32 to 34 in 5b05237

	<EmptyStateComponent
	SkeletonComponent={CardRowSkeleton}
	headerMediaType={CONST.EMPTY_STATE_MEDIA.ILLUSTRATION}

This causes us to show double scrollbar

What changes do you think we should make in order to solve the problem?

We should pass showsVerticalScrollIndicator={false} to EmptyStateComponent, and keep the scrollview in EmptyCardView as it is.

showsVerticalScrollIndicator tells the component whether or not to show the verticalScrollIndicator:

EmptyCardView also has a text component:

App/src/pages/workspace/expensifyCard/EmptyCardView.tsx

Lines 53 to 54 in 5b05237

	<Text style={[styles.textMicroSupporting, styles.m5]}>{translate('workspace.expensifyCard.disclaimer')}</Text>
	</ScrollView>

So we need ScrollView for this page.

I think we can totally disable the scroll inside EmptyStateComponent as we already scroll the page in EmptyCardView, this can be done with the help of scrollEnabled prop, we need to introduce a new optional prop for this though, then pass the value as false to EmptyStateComponent which will pass this same value to ScrollView component in EmptyStateComponent:

App/src/components/EmptyStateComponent/index.tsx

Line 87 in 5b05237

<ScrollView

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A This is a UI bug

What alternative solutions did you explore? (Optional)

1. Remove scrollView from the following places:
   

   App/src/pages/workspace/expensifyCard/EmptyCardView.tsx

   Line 30 in 5b05237

   <ScrollView>

App/src/components/EmptyStateComponent/index.tsx

Line 87 in 5b05237

<ScrollView

Replace the use of scrollview with a View

2. Wrap EmptyCardView component with a scrollview:

                <ScrollView>
                    <EmptyCardView isBankAccountVerified={isBankAccountVerified} />
                </ScrollView>

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx

Lines 138 to 140 in a0a2609

	{isEmptyObject(cardsList) ? (
	<EmptyCardView isBankAccountVerified={isBankAccountVerified} />
	) : (

Result:

Screen.Recording.2025-02-13.at.8.26.57.AM.mov

[jliexpensify]

Woah, weird! @Expensify/design - just confirming: is this an Internal issue?

[dannymcclain]

Oh boy—I honestly don't know. @shawnborton you have any ideas? It seems to be somehow related to the empty state + disclaimer message combo.

[shawnborton]

I would think this can be fixed Externally. No idea why it is happening, but we should definitely fix it!

[shawnborton]

cc @fabioh8010 as I think you worked on some of the empty state stuff? I could be making that up though!

[jliexpensify]

Thanks Danny + Shawn, gonna drop the External label then.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021889430675865762724