Skip to content

fix: Approval button is loaded indefinitely #49910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 2 commits into from
Oct 14, 2024
Merged

fix: Approval button is loaded indefinitely #49910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b758daf
fix: Approval button is loaded indefinitely
nkdengineer Sep 30, 2024
d82a253
Merge branch 'main' into fix/48999
nkdengineer Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6526,7 +6526,10 @@ function getReportFromHoldRequestsOnyxData(
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${optimisticExpenseReport.reportID}`,
value: optimisticExpenseReport,
value: {
...optimisticExpenseReport,
unheldTotal: 0,

@jjcoffee jjcoffee Nov 19, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this caused #50932, although this only happened in combination with #50817. Essentially we needed to handle the case where the approval is for a manual expense.

},
},
// add preview report action to main chat
{
Expand Down