[HOLD for payment 2024-11-18] [$250] Hybrid iOS app –IOU –Approval button is missing after payment of the report with hold expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.49-0
Reproducible in staging?: N
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was repro when executing this PR: #49910
Email or phone of affected tester (no customers): applausetester+jp_1151024@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to Hybrid app
2. Log in with your Approver account
3. As employee Go to the room with the two expenses
4. As employee: hold one expense
5. As Approver: Approve just the pending amount
6. As Approver: back to room by click to the header

Expected Result:

The approval button should load after payment of the report with hold expense

Actual Result:

The approval button is missing after payment of the report with hold expense

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6636810_1729099904332.Ap.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848434780732463293
• Upwork Job ID: 1848434780732463293
• Last Price Increase: 2024-10-21
• Automatic offers:
• jjcoffee | Reviewer | 104595665
• ikevin127 | Contributor | 104595666

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hybrid iOS app –IOU –Approval button is missing after payment of the report with hold expense

What is the root cause of that problem?

Right here we check if the unheld total amount is not equal to 0 then we will show the approve button

App/src/libs/actions/IOU.ts

Lines 6990 to 6992 in 66cf824

	const unheldTotalIsZero = iouReport && iouReport.unheldTotal === 0;
	return isCurrentUserManager && !isOpenExpenseReport && !isApproved && !iouSettled && !isArchivedReport && !unheldTotalIsZero;

Since we hold the expense the unheld total amount become 0 which will not show the approve button

What changes do you think we should make in order to solve the problem?

We should remove the unheldTotalIsZero variable and remove the return check condition

App/src/libs/actions/IOU.ts

Lines 6990 to 6992 in 66cf824

	const unheldTotalIsZero = iouReport && iouReport.unheldTotal === 0;
	return isCurrentUserManager && !isOpenExpenseReport && !isApproved && !iouSettled && !isArchivedReport && !unheldTotalIsZero;

[melvin-bot]

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848434780732463293

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)