Repository navigation
[CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time" - #43223
Merged
Conversation
…button for the second time"
6 tasks done
mountiny
changed the title
mountiny
marked this pull request as ready for review
June 6, 2024 21:06
|
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mountiny
approved these changes
Jun 6, 2024
mountiny
left a comment
mountiny
left a comment
Contributor
There was a problem hiding this comment.
Thanks for verifying this, testing real quick too
Contributor
Screen.Recording.2024-06-06.at.23.15.42.mov |
Contributor
|
Straight revert |
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
Straight revert, asked for CP, not emergency |
OSBotify
pushed a commit
that referenced
this pull request
Jun 6, 2024
[CP Staging] Revert "fix: Error message only changes after clicking Split expense button for the second time" (cherry picked from commit c03bdc6)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #42450
Fixes #43216