Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-21] Split - App allows splitting when the sum of splits is not equal to total amount #43216
Description
Activity
Triggered auto assignment to @thienlnam (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-split
This issue is about frontend error handling, so it's not a backend blocker.
To unblock deploy as fast as possible, I will go with the revert
CPing the revert
24 remaining items
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.$75 to @ishpaul777
Reacted by Sonia Liapounova- changed the title
[-][HOLD for payment 2024-06-21] Split - App allows splitting when the sum of splits is not equal to total amount[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-21] Split - App allows splitting when the sum of splits is not equal to total amount[/+]on Jun 21, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
- @ishpaul777 requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
- [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@ishpaul777] Determine if we should create a regression test for this bug.
- [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@sonialiap I have accepted offer, Thanks!
- [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR: fix: Error message only changes after clicking Split expense button for the second time #42450
- [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: Error message only changes after clicking Split expense button for the second time #42450 (comment)
- [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: - Not required
- [@ishpaul777] Determine if we should create a regression test for this bug. -This was caught during staging QA, there must already be a TR for this flow.
- [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Paid ✔️
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.80-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4601034
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The split will not be created because "The sum of splits must equal the total amount."
Actual Result:
The split is created despite the error "The sum of splits must equal the total amount."
Error shows up after the split is created
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6504309_1717701794847.20240607_031950.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @sonialiap