fix: Bank account icon is a green square by dukenv0307 · Pull Request #37450 · Expensify/App

dukenv0307 · 2024-02-28T18:07:46Z

Details

Fixed Issues

$ #37413
PROPOSAL: #37413 (comment)

Tests

Launch New Expensify app.
Go to Profile Settings > Wallet.
Tap Add bank account > Personal bank account.
Add any bank account.
Tap on the added bank account.
Verify that: Bank account icon is rendered without issue.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch New Expensify app.
Go to Profile Settings > Wallet.
Tap Add bank account > Personal bank account.
Add any bank account.
Tap on the added bank account.
Verify that: Bank account icon is rendered without issue.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-29.at.03.14.54.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-02-29.at.03.09.44.mov

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.03.08.44.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-29.at.03.30.21.mov

MacOS: Desktop

Screen.Recording.2024-02-29.at.03.31.39.mov

melvin-bot · 2024-02-28T18:31:34Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

puneetlath · 2024-02-28T18:33:49Z

@dukenv0307 you have lint errors.

dukenv0307 · 2024-02-28T18:43:54Z

@puneetlath Fixed it now.

abdulrahuman5196 · 2024-02-28T18:45:38Z

                                        title={paymentMethod.formattedSelectedPaymentMethod.title}
-                                        icon={paymentMethod.formattedSelectedPaymentMethod.icon}
+                                        icon={paymentMethod.formattedSelectedPaymentMethod.icon?.icon}
+                                        iconHeight={paymentMethod.formattedSelectedPaymentMethod.icon?.iconHeight}


@dukenv0307 Why are we passing iconHeight and iconWidth separately? Its already part of paymentMethod.formattedSelectedPaymentMethod.icon right? Why are we splitting the params and passing?

@abdulrahuman5196

Its already part of paymentMethod.formattedSelectedPaymentMethod.icon right

Yes.

Why are we splitting the params and passing?

Do you mean like this?

{icon, iconWidth, iconHeight, iconStyles} = paymentMethod.formattedSelectedPaymentMethod.icon

and then use this to pass into MenuItem

Sorry, nevermind. Its under conditional rendering. Wouldn't be helpful

abdulrahuman5196 · 2024-02-28T19:26:05Z

@dukenv0307 Other than android native, we don't have any video for other platforms?

dukenv0307 · 2024-02-28T19:29:43Z

I'm preparing other screenshots.

abdulrahuman5196 · 2024-02-28T19:29:58Z

@dukenv0307
The icon size change doesn't seem to be working? I tested in web, even in your video its not working.

dukenv0307 · 2024-02-28T19:40:21Z

~~@abdulrahuman5196 MenuItem doesn't have iconSize prop so I think we should add an extra prop on this.~~

abdulrahuman5196 · 2024-02-28T19:46:29Z

@abdulrahuman5196 MenuItem doesn't have iconSize prop so I think we should add an extra prop on this.

MenuItem has iconHeight and iconWidth ? Shouldn't that be enough as you had pointed out in the proposal?
Then how was the screenshot with proper icon size achieved in the proposal?

abdulrahuman5196 · 2024-02-28T20:04:27Z

@dukenv0307 Any update on this?

dukenv0307 · 2024-02-28T20:04:43Z

@abdulrahuman5196 Sorry missed to fallback iconSize if iconWidth and height are undefined while implementing the PR

dukenv0307 · 2024-02-28T20:06:21Z

updating now.

abdulrahuman5196 · 2024-02-28T20:12:50Z

@dukenv0307 Do let me know once available for re-review

dukenv0307 · 2024-02-28T20:13:52Z

@abdulrahuman5196 Ready for review again and updated other screenshot.

dukenv0307 · 2024-02-28T20:18:28Z

web and desktop don't need screenshot because it only displays delete item when clicking on three-dot.

abdulrahuman5196 · 2024-02-28T20:23:03Z

web and desktop don't need screenshot because it only displays delete item when clicking on three-dot.

@dukenv0307 We can strink it to single page, which will show the popup

dukenv0307 · 2024-02-28T20:29:34Z

@abdulrahuman5196 Do you mean re-size page?

Gonals · 2024-02-28T20:30:48Z

@abdulrahuman5196 Do you mean re-size page?

If you shrink the sides of the window until the LHN hides, you'll see the popup with the icon, yes

dukenv0307 · 2024-02-28T20:32:33Z

@abdulrahuman5196 Updated full screenshot

abdulrahuman5196 · 2024-02-28T20:33:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-29.at.1.58.46.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-02-29.at.1.59.46.AM.mp4

iOS: Native

Screen.Recording.2024-02-29.at.1.57.09.AM.mp4

iOS: mWeb Safari

Screen.Recording.2024-02-29.at.1.57.33.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-02-29.at.1.50.15.AM.mp4

MacOS: Desktop

Screen.Recording.2024-02-29.at.1.51.01.AM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @Gonals / @puneetlath

🎀 👀 🎀
C+ Reviewed

OSBotify · 2024-02-28T20:49:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: Bank account icon is a green square (cherry picked from commit e728878)

OSBotify · 2024-02-28T21:17:17Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.44-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-29T00:01:29Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 3 commits February 29, 2024 01:05

fix: Bank account icon is a green square

31ed26f

fix ts check

3d32ca3

fix ts check

c652ab5

dukenv0307 marked this pull request as ready for review February 28, 2024 18:31

dukenv0307 requested a review from a team as a code owner February 28, 2024 18:31

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team February 28, 2024 18:31

fix lint

056bc1d

abdulrahuman5196 reviewed Feb 28, 2024

View reviewed changes

fallback iconSize

afac4f4

remove console.log

cfb1d61

abdulrahuman5196 approved these changes Feb 28, 2024

View reviewed changes

melvin-bot Bot requested a review from Gonals February 28, 2024 20:38

Gonals approved these changes Feb 28, 2024

View reviewed changes

Gonals merged commit e728878 into Expensify:main Feb 28, 2024

OSBotify pushed a commit that referenced this pull request Feb 28, 2024

Merge pull request #37450 from dukenv0307/fix/37413

8910166

fix: Bank account icon is a green square (cherry picked from commit e728878)

github-actions Bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

melvin-bot Bot mentioned this pull request Feb 29, 2024

[HOLD for payment 2024-03-07] [$500] Wallet - Bank account icon is a green square #37413

Closed

2 of 6 tasks

Conversation

dukenv0307 commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 28, 2024

Uh oh!

puneetlath commented Feb 28, 2024

Uh oh!

dukenv0307 commented Feb 28, 2024

Uh oh!

abdulrahuman5196 Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Feb 28, 2024

Uh oh!

dukenv0307 commented Feb 28, 2024

Uh oh!

abdulrahuman5196 commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Feb 28, 2024

Uh oh!

abdulrahuman5196 commented Feb 28, 2024

Uh oh!

dukenv0307 commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Feb 28, 2024

Uh oh!

abdulrahuman5196 commented Feb 28, 2024

Uh oh!

dukenv0307 commented Feb 28, 2024

Uh oh!

dukenv0307 commented Feb 28, 2024

Uh oh!

abdulrahuman5196 commented Feb 28, 2024

Uh oh!

dukenv0307 commented Feb 28, 2024

Uh oh!

Gonals commented Feb 28, 2024

Uh oh!

dukenv0307 commented Feb 28, 2024

Uh oh!

abdulrahuman5196 commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dukenv0307 commented Feb 28, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 28, 2024 •

edited

Loading

dukenv0307 commented Feb 28, 2024 •

edited

Loading

dukenv0307 commented Feb 28, 2024 •

edited

Loading

abdulrahuman5196 commented Feb 28, 2024 •

edited

Loading