Repository navigation
[HOLD for payment 2024-03-07] [$500] Wallet - Bank account icon is a green square #37413
Description
Activity
- changed the title
[-]Wallet - Bank account icon is a green square[/-][+][$500] Wallet - Bank account icon is a green square[/+]on Feb 28, 2024 Job added to Upwork: https://www.upwork.com/jobs/~01b9e61412591fe6fb
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
24 remaining items
- changed the title
[-][$500] Wallet - Bank account icon is a green square[/-][+][HOLD for payment 2024-03-07] [$500] Wallet - Bank account icon is a green square[/+]on Feb 29, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.45-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-07. 🎊
For reference, here are some details about the assignees on this issue:
- @abdulrahuman5196 requires payment automatic offer (Reviewer)
- @dukenv0307 requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR: N/A
- [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
- [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
- [@abdulrahuman5196] Determine if we should create a regression test for this bug.
- [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A
@abdulrahuman5196 Please complete BZ checklist so we can prep to issue payment
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:Not sure on this. Doesn't have a direct regression PR. Could be caused by some common component changes.
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.No. Wouldn't beneficial since its a UI issue and we would already have test to open this page which should be enough.
@joekaufmanexpensify Completed BZ checklist.
TY! BZ checklist complete.
All set to issue payment. We need to pay:
- @dukenv0307 $500 for PR. Paid via upwork.
- @abdulrahuman5196 $500 for C+. Paid via upwork.
@dukenv0307 $500 sent and contract ended
@abdulrahuman5196 $500 sent and contract ended
Upwork job closed.
All set! thanks everyone
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team
Action Performed:
Expected Result:
Bank account icon is rendered without issue.
Actual Result:
Bank account icon is a green square.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
Upwork Automation - Do Not Edit