Repository navigation
[CP Stag] Update logic for business bank account payment - #31858
Closed
luacmartins wants to merge 3 commits into
Closed
luacmartins wants to merge 3 commits into
luacmartins wants to merge 3 commits into
Conversation
luacmartins
marked this pull request as ready for review
November 24, 2023 21:12
melvin-bot
Bot
requested review from
parasharrajat
and removed request for
a team
November 24, 2023 21:12
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This was referenced Nov 24, 2023
mountiny
requested changes
Nov 27, 2023
Comment on lines
-87
to
+73
| ...(!ReportActionsUtils.hasRequestFromCurrentAccount(lodashGet(iouReport, 'reportID', 0), lodashGet(session, 'accountID', 0)) | ||
| ...(ReportUtils.isExpenseReport(iouReport) |
Contributor
There was a problem hiding this comment.
This is not desired fix, we need this method in place so we can show the Bussiness bank account option in case of IOUs when there is only "one direction"
Contributor
Author
There was a problem hiding this comment.
Ah I see! Thanks for clarifying!
Contributor
|
I have created a new PR for this which brings back the button for workspace chats #31908 we can close this one I believe |
Contributor
Author
|
Closing this PR since it's no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Shows
Business bank accountoption when paying an expense report.cc @mountiny left this comment in the doc https://docs.google.com/document/d/1pFEepu3ih7_NxPxudIXMa5KMF8POp4IM-ZIcANS8srY/edit?disco=AAABBIyzVLE
Fixed Issues
$ #31837
Tests
Business bank accountoptionOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop