The "Copy URL to clipboard" tooltip does not appear when hovering over a task description link by ZhenjaHorbach · Pull Request #28951 · Expensify/App

ZhenjaHorbach · 2023-10-05T19:17:25Z

Details

Private Notes - The strikethrough line of the link is displaying in white on the Private Notes page
The "Copy URL to clipboard" tooltip does not appear when hovering over a task description link
The strikethrough line of the link is displaying in white on the Private Notes page

Fixed Issues

$ #27812
$ #28862
$ #28859
PROPOSAL: #27812 (comment)

Tests

Open a chat.
Navigate to the "Assign task" section.
Enter a title and insert a link in the description, then create the task.
After task creation, right-click on the description link.
Observe that the tooltip for "Copy URL to clipboard" does not appear

Navigate to staging.
Open any chat
Click on the header and go to Private notes
Go to My note > Notes
Add ~https://xyz.com/~ and save
Notice that the strikethrough line appears in white

Go to staging
Go to any chat
Click on the header and navigate to Private notes
Go to My note > Notes
Add # https://xvz.com/ and save it
Notice that the link following the hashtag is not displayed in bold

Verify that no errors appear in the JS console

Offline tests

Open a chat.
Navigate to the "Assign task" section.
Enter a title and insert a link in the description, then create the task.
After task creation, right-click on the description link.
Observe that the tooltip for "Copy URL to clipboard" does not appear

Navigate to staging.
Open any chat
Click on the header and go to Private notes
Go to My note > Notes
Add ~https://xyz.com/~ and save
Notice that the strikethrough line appears in white

Go to staging
Go to any chat
Click on the header and navigate to Private notes
Go to My note > Notes
Add # https://xvz.com/ and save it
Notice that the link following the hashtag is not displayed in bold

QA Steps

Open a chat.
Navigate to the "Assign task" section.
Enter a title and insert a link in the description, then create the task.
After task creation, right-click on the description link.
Observe that the tooltip for "Copy URL to clipboard" does not appear

Navigate to staging.
Open any chat
Click on the header and go to Private notes
Go to My note > Notes
Add ~https://xyz.com/~ and save
Notice that the strikethrough line appears in white

Go to staging
Go to any chat
Click on the header and navigate to Private notes
Go to My note > Notes
Add # https://xvz.com/ and save it
Notice that the link following the hashtag is not displayed in bold

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-10-05.at.20.37.46.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-10-05.at.20.43.56.mov

iOS

Android

melvin-bot · 2023-10-05T19:17:31Z

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2023-10-05T19:25:00Z

@ntdiary
Hello)
You may have been assigned by accident
But here's the approval from @jjcoffee

#27812 (comment)

jjcoffee · 2023-10-06T14:09:43Z

@ZhenjaHorbach Just waiting for you to be assigned on the main issue.

ZhenjaHorbach · 2023-10-09T06:49:09Z

@jjcoffee
Hello
I've already been assigned )

jjcoffee · 2023-10-09T14:58:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari-2023-10-11_13.12.22.mp4

Desktop

mac-desktop-2023-10-11_13.19.43.mp4

iOS

ios-native-2023-10-11_13.15.00.mp4

Android

android-native.mp4

jjcoffee · 2023-10-09T15:15:34Z

Based on @thienlnam's comment on Slack, it sounds like we're wanting to disable the Copy URL to clipboard tooltip on the preview/Confirm Task screen, and possibly even remove the autolink too (maybe markdown generally). @Expensify/design might have an opinion on this?

Confirm Task - Should we disable markdown processing altogether here?

Task detail

ZhenjaHorbach · 2023-10-09T17:43:14Z

@jjcoffee

If there are such thoughts, then we can probably expand the solution and add 3 item menu states )

Only text
Markdown
<Comment> + Markdown

ZhenjaHorbach · 2023-10-09T17:57:08Z

@shawnborton

Hello )
Can you please confirm the suggestions we should make or make new propositions ?)

Based on @thienlnam's comment on Slack, it sounds like we're wanting to disable the Copy URL to clipboard tooltip on the preview/Confirm Task screen, and possibly even remove the autolink too (maybe markdown generally). @Expensify/design might have an opinion on this?

Confirm Task - Should we disable markdown processing altogether here?

Task detail

cc: @jjcoffee

shawnborton · 2023-10-09T18:03:41Z

Ah sorry, I commented in Slack, but it sounds like we want to keep markdown/links in this particular view.

As for the tooltip, I think we should stay consistent with other link tooltips in chat which just shows the URL in the tooltip, right?

ZhenjaHorbach · 2023-10-10T07:06:44Z

Ah sorry, I commented in Slack, but it sounds like we want to keep markdown/links in this particular view.

As for the tooltip, I think we should stay consistent with other link tooltips in chat which just shows the URL in the tooltip, right?

Yes, links have the same tooltip with URL copy )

ZhenjaHorbach · 2023-10-10T07:07:29Z

@jjcoffee
If I understood correctly, the ticket is ready )

ZhenjaHorbach · 2023-10-11T06:54:47Z

@jjcoffee , Bump )

jjcoffee · 2023-10-11T11:07:58Z

@ZhenjaHorbach Did you test with task description on Android? I'm still getting the hashtag rendered (works fine on private notes):

ZhenjaHorbach · 2023-10-11T11:10:24Z

@ZhenjaHorbach Did you test with task description on Android? I'm still getting the hashtag rendered (works fine on private notes):

Strange, I will check

ZhenjaHorbach · 2023-10-11T12:43:54Z

@jjcoffee
You were right )
It's a real problem on Android.
This is due to we parse text for Android with a special character that half of the regular expressions do not understand

This changes was made in this PR
https://github.com/Expensify/App/pull/27462/files

I checked and I didn't find a single reason
Why do we need to add an additional symbol for android during parsing

And it works on private notes, because we get title from props with all tags

jjcoffee · 2023-10-11T13:23:27Z

@ZhenjaHorbach If you look a bit deeper, it's required because of this

It is to force the text to becomes LTR because the style from styles.ltr uses writingDirection which is not supported on native (the comment mentioned Android only but looks like iOS doesn't support that style too).

To be safe maybe we can just do setHtml(convertToLTR(parser.replace(props.title)));?

ZhenjaHorbach · 2023-10-11T13:33:29Z

@ZhenjaHorbach If you look a bit deeper, it's required because of this

It is to force the text to becomes LTR because the style from styles.ltr uses writingDirection which is not supported on native (the comment mentioned Android only but looks like iOS doesn't support that style too).

To be safe maybe we can just do setHtml(convertToLTR(parser.replace(props.title)));?

I have tried )
But then an invisible line will appear on description on task )

Maybe add a prop that disables adding a special character?)

Without convertToLTR

With convertToLTR

jjcoffee · 2023-10-11T13:52:22Z

Ahhh never mind, I see that we do convertToLTR any time we use RenderHTML anyway:

App/src/components/HTMLEngineProvider/BaseHTMLEngineProvider.js

Line 72 in d7b1deb

onText: (text) => (text.data = convertToLTR(text.data)),

So should be safe to remove!

jjcoffee

LGTM!

jjcoffee · 2023-10-11T13:54:41Z

Ready for your review @youssef-lr (automation went a bit weird since this is linked to 3 different issues)!

youssef-lr

LGTM

OSBotify · 2023-10-17T19:38:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-17T23:56:21Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:53:51Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix some bugs with comment tag in memu items

919859e

ZhenjaHorbach requested a review from a team as a code owner October 5, 2023 19:17

melvin-bot Bot requested review from ntdiary and removed request for a team October 5, 2023 19:17

Fix bug on android

a650f1d

jjcoffee approved these changes Oct 11, 2023

View reviewed changes

melvin-bot Bot requested a review from thienlnam October 11, 2023 13:53

jjcoffee mentioned this pull request Oct 12, 2023

[HOLD for payment 2023-10-25] [$500] Dev: Web - The "Copy URL to clipboard" tooltip does not appear when hovering over a task description link #27812

Closed

6 tasks

youssef-lr approved these changes Oct 17, 2023

View reviewed changes

youssef-lr merged commit 62e12c9 into Expensify:main Oct 17, 2023

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

Conversation

ZhenjaHorbach commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 5, 2023

Uh oh!

ZhenjaHorbach commented Oct 5, 2023

Uh oh!

jjcoffee commented Oct 6, 2023

Uh oh!

ZhenjaHorbach commented Oct 9, 2023

Uh oh!

jjcoffee commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Oct 9, 2023

Uh oh!

ZhenjaHorbach commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Oct 9, 2023

Uh oh!

shawnborton commented Oct 9, 2023

Uh oh!

ZhenjaHorbach commented Oct 10, 2023

Uh oh!

ZhenjaHorbach commented Oct 10, 2023

Uh oh!

ZhenjaHorbach commented Oct 11, 2023

Uh oh!

jjcoffee commented Oct 11, 2023

Uh oh!

ZhenjaHorbach commented Oct 11, 2023

Uh oh!

ZhenjaHorbach commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjcoffee commented Oct 11, 2023

Uh oh!

ZhenjaHorbach commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjcoffee commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Oct 11, 2023

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 17, 2023

Uh oh!

OSBotify commented Oct 17, 2023

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZhenjaHorbach commented Oct 5, 2023 •

edited

Loading

jjcoffee commented Oct 9, 2023 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2023 •

edited

Loading

ZhenjaHorbach commented Oct 11, 2023 •

edited

Loading

ZhenjaHorbach commented Oct 11, 2023 •

edited

Loading

jjcoffee commented Oct 11, 2023 •

edited

Loading