[HOLD for payment 2023-10-25] [$500] Private Note - The link following the hashtag is not displayed in bold on the Private Notes page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging
2. Go to any chat
3. Click on the header and navigate to Private notes
4. Go to My note > Notes
5. Add "# https://xvz.com/" and save it
6. Notice that the link following the hashtag is not displayed in bold

Expected Result:

The link following the hashtag should appear in bold

Actual Result:

The link following the hashtag is not displayed in bold

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

safari-.mp4

ios-.mp4

Screen.Recording.2023-10-03.at.10.25.28.PM.mov

-issue.mov

Expensify/Expensify Issue URL:
Issue reported by: @aman-atg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696349893541419

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011597f299ef538062
• Upwork Job ID: 1709670524467359744
• Last Price Increase: 2023-10-04
• Automatic offers:
• ZhenjaHorbach | Contributor | 27032777
• aman-atg | Reporter | 27032783

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011597f299ef538062

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[sicarius97]

@kbecciv Is this the behavior somewhere else in the app where it does work? I can't recall

[aman-atg]

@sicarius97 It works for the messages

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

The link following the hashtag is not displayed in bold

What is the root cause of that problem?

The main problem that we don’t use <comment> tag for HTML in MenuItem now(This tag allows us to use special styles and features like bold font for links )

What changes do you think we should make in order to solve the problem?

We have a special function that used to prepare html to showing

App/src/components/MenuItem.js

Lines 127 to 134 in 09ea179

	const getProcessedTitle = useMemo(() => {
	if (props.shouldRenderAsHTML) {
	return convertToLTR(props.title);
	}
	if (props.shouldParseTitle) {
	return html;
	}

And in this function we can wrap result in a <comment> tag

Or to make the title more functional, we can add a prop that will allow us to disable and enable the use of this tag

#27812

Partially linked ticket
Since the problem is also related to <comment> tag for MenuItem

What alternative solutions did you explore? (Optional)

NA

[chahedmoetaz]

Hello,

I see this error on upwork https://www.upwork.com/jobs/~011597f299ef538062

I think that I have the solution::

First Locate the Code for Rendering Private Notes: 'on javascript code'

function renderPrivateNote(noteContent) {
// Code for rendering private notes
}
Please pay attention to how text formatting and styling are applied.
Check for Styling Rules: 'CSS code'
/* Styling for links /
a {
color: blue; / Default link color /
font-weight: bold; / Make links bold */
}

/* Styling for hashtags /
.hashtag {
font-weight: bold; / Make hashtags bold */
}

and Verify that the HTML tags and attributes for styling are present. Links should be enclosed in tags, and hashtags can have a specific class, e.g., #hashtag

Review JavaScript Interactions
Check for Overrides or Conflicting Styles
Test Different Browsers and Platforms
Use Developer Tools for Debugging: ' javascript code'

function renderPrivateNote(noteContent) {
console.log('Rendering private note:', noteContent);

// Code for rendering private notes

}

Use the browser console to view the debug output and identify any issues with rendering or styling

Hope this can help you
Please keep me updated 'chahedmoetaz@gmail.com'