fix: 23369 back button navigation fixed for ondify steps by vipin87 · Pull Request #23864 · Expensify/App

vipin87 · 2023-07-29T16:51:18Z

Details

Fixed Issues

$ #23369
PROPOSAL: #23369 (comment)

Tests

Open the "Settings" menu.
Click on "Workspaces."
Navigate to "Bank Account."
Click on "Connect bank account."
Proceed through all the steps until you reach the "Personal Information" section (step 3 of 5).
Click on "Save & Continue" in the "Personal Information" section (step 3 of 5).
Click on "Drivers License" in the "Personal Information" section (step 3 of 5) and proceed.
Click on "Get Secure link" in the "Personal Information" section (step 3 of 5) and proceed.
At this point, when you reach the page where "Scan the QR code with your phone" is written, click on the back button.
Observe that the user is directed back to the previous page
Keep clicking back until first page is reached

Verify that no errors appear in the JS console

Offline tests

Onfido flow not available in offline mode. It has to be tested while application is online.

QA Steps

Same as "Tests" section above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mobile-chrome.MP4

Mobile Web - Safari

mobile-safari.MP4

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-07-29T16:51:23Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-07-29T16:51:36Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

vipin87 · 2023-07-29T16:54:32Z

I have read the CLA Document and I hereby sign the CLA

robertKozik

Few things to consider

robertKozik · 2023-07-31T20:01:40Z

+    }
+
+    goBack(...args) {
+        const ondifyBack = document.getElementsByClassName('onfido-sdk-ui-NavigationBar-back');


Can't we use document.querySelector to get the first occurrence of that class? As we won't be having the array this way code would be simplified

Also typo in the const name ondify should be onfido

@robertKozik yes you are right, fixed now.

robertKozik

One minor thing, sorry

robertKozik · 2023-08-01T12:20:52Z

+        this.goBack = this.goBack.bind(this);
+    }
+
+    goBack(...args) {


Didn't saw that one, onBackButtonPress is called inside HeaderWithBackButton without any args, so this spread is redundant in my opinion

Sorry for this

robertKozik · 2023-08-01T12:25:02Z

    }
 }
+
+.onfido-sdk-ui-NavigationBar-back {


if you could add the explanation comment why we are hiding this button

vipin87 · 2023-08-03T11:39:33Z

@robertKozik is there anything still pending on this PR?

robertKozik · 2023-08-03T21:12:58Z

Sorry @vipin87 coming back to this PR now

robertKozik · 2023-08-03T21:16:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- [ X] MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.-.web.mov

Mobile Web - Safari

iOS.-.web.mov

Desktop

desktop.mov

iOS

iOS.-.native.mov

Android

android.-.native.mov

robertKozik · 2023-08-03T21:18:44Z

@vipin87 Could you kindly change the offline test steps, as I believe onfido flow is not accessible while offline? Also please check all the checkboxes in your Author checklist. Thank you in advance

vipin87 · 2023-08-04T03:46:08Z

@robertKozik checked all checkboxes and updated offline steps. Sorry for to many to-and-fro, as it is my first PR.

robertKozik · 2023-08-07T14:35:27Z

@vipin87 gentle bump on updating test steps and checkboxes. TYIA

vipin87 · 2023-08-07T14:37:44Z

@robertKozik I already did those changes.

robertKozik · 2023-08-07T15:25:34Z

Sorry, didn't saw them. I'll proceed with the testing then

robertKozik

Looks good, lets push this forward

francoisl

LGTM

OSBotify · 2023-08-07T23:28:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-09T09:11:47Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:50:30Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

situchan · 2023-08-09T21:59:15Z

+    }
+
+    goBack() {
+        const onfidoBack = document.querySelector('.onfido-sdk-ui-NavigationBar-back');


This caused deploy blocker - #24343.
document doesn't exist on native.

Dang, I didn't encountered this during my testing on offline...
@vipin87 Can you rise the follow-up for the issue with proper platform handling?

OSBotify · 2023-08-10T20:08:56Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: 23369 back button navigation fixed for ondify steps

001804d

vipin87 requested a review from a team as a code owner July 29, 2023 16:51

melvin-bot bot requested review from robertKozik and removed request for a team July 29, 2023 16:51

Trigger Build

eb4b50b

robertKozik suggested changes Jul 31, 2023

View reviewed changes

getElementByClass replaced with querySelector

c7fc624

robertKozik suggested changes Aug 1, 2023

View reviewed changes

robertKozik reviewed Aug 1, 2023

View reviewed changes

comment added in css file and args removed from function call

5671c62

robertKozik approved these changes Aug 7, 2023

View reviewed changes

melvin-bot bot requested a review from francoisl August 7, 2023 22:17

francoisl approved these changes Aug 7, 2023

View reviewed changes

francoisl merged commit 2ce4328 into Expensify:main Aug 7, 2023

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

situchan reviewed Aug 9, 2023

View reviewed changes

This was referenced Aug 9, 2023

[HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline #24343

Closed

Revert "fix: 23369 back button navigation fixed for ondify steps" #24373

Merged

melvin-bot bot mentioned this pull request Aug 10, 2023

[HOLD for payment 2023-08-17] [$1000] Web – Personal Information– Back button is not working accurately in "Personal information" section (step 3 of 5). #23369

Closed

6 tasks

Conversation

vipin87 commented Jul 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 29, 2023

Uh oh!

github-actions bot commented Jul 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vipin87 commented Jul 29, 2023

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vipin87 commented Aug 3, 2023

Uh oh!

robertKozik commented Aug 3, 2023

Uh oh!

robertKozik commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

robertKozik commented Aug 3, 2023

Uh oh!

vipin87 commented Aug 4, 2023

Uh oh!

robertKozik commented Aug 7, 2023

Uh oh!

vipin87 commented Aug 7, 2023

Uh oh!

robertKozik commented Aug 7, 2023

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

francoisl left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

vipin87 commented Jul 29, 2023 •

edited

Loading

github-actions bot commented Jul 29, 2023 •

edited

Loading

robertKozik commented Aug 3, 2023 •

edited

Loading