[HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Start iOS App
2. Login with Expensifail account
3. Go to existing or create new workspace
4. Go to Workspace > Connect bank account
5. Follow the flow for adding a VBA using the credentials [Company - Expensify, First name - First, Last name - Last] until you reach the Onfido screen
6. Onfido first screen loads
7. Go OFFline
8. Go next screen
9. User can’t go next from this 2nd screen offline
10. Tap 'Back' 2 times while staying offline

Expected Result:

User should return to the Personal Information page

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.52.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159354_T3575395-iOS-Onfido-Crash-Offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

@lanitochka17 I see that you're able to reproduce it on iOS. Have you tried the same flow on other platforms and it's working on those platforms? Also, is this a brand new crash that hasn't been on previous versions of the app?

[lanitochka17]

Issue reproducible in only IOS

[situchan]

root cause: https://github.com/Expensify/App/pull/23864/files#r1289249208
I suggest to revert #23864

[tgolen]

@situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?

[situchan]

@situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?

Sure I can do that